From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH 1/2] eal: fix build with glibc < 2.16
Date: Mon, 30 Apr 2018 09:13:29 -0400
Message-ID: <f7tpo2g7s7a.fsf@dhcp-25.97.bos.redhat.com>
References: <20180427024342.24054-1-thomas@monjalon.net>
 <20180427024342.24054-2-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain
Cc: dev@dpdk.org,  tredaelli@redhat.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 64619DD2
 for <dev@dpdk.org>; Mon, 30 Apr 2018 15:13:33 +0200 (CEST)
In-Reply-To: <20180427024342.24054-2-thomas@monjalon.net> (Thomas Monjalon's
 message of "Fri, 27 Apr 2018 04:43:41 +0200")
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thomas Monjalon <thomas@monjalon.net> writes:

> The fake getauxval function does not use its parameter.
> So the compiler raised this error:
> 	lib/librte_eal/common/eal_common_cpuflags.c:25:25: error:
> 	unused parameter 'type'
>
> Fixes: 2ed9bf330709 ("eal: abstract away the auxiliary vector")
> Cc: aconole@redhat.com
> Cc: tredaelli@redhat.com
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Oops - sorry about that.

Acked-by: Aaron Conole <aconole@redhat.com>

>  lib/librte_eal/common/eal_common_cpuflags.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/eal_common_cpuflags.c b/lib/librte_eal/common/eal_common_cpuflags.c
> index a09667563..6a9dbaeb1 100644
> --- a/lib/librte_eal/common/eal_common_cpuflags.c
> +++ b/lib/librte_eal/common/eal_common_cpuflags.c
> @@ -22,7 +22,7 @@
>  
>  #ifndef HAS_AUXV
>  static unsigned long
> -getauxval(unsigned long type)
> +getauxval(unsigned long type __rte_unused)
>  {
>  	errno = ENOTSUP;
>  	return 0;