From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Conole Subject: Re: [PATCH 15/25] eal: do not panic on alarm init Date: Mon, 30 Jan 2017 11:52:15 -0500 Message-ID: References: <1485529023-5486-1-git-send-email-aconole@redhat.com> <1485529023-5486-16-git-send-email-aconole@redhat.com> <20170127083155.71fb20cb@xeon-e3> <20170127164201.GA82692@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Stephen Hemminger , dev@dpdk.org To: Bruce Richardson Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D1E5F2E8A for ; Mon, 30 Jan 2017 17:52:16 +0100 (CET) In-Reply-To: <20170127164201.GA82692@bricha3-MOBL3.ger.corp.intel.com> (Bruce Richardson's message of "Fri, 27 Jan 2017 16:42:02 +0000") List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Bruce Richardson writes: > On Fri, Jan 27, 2017 at 08:31:55AM -0800, Stephen Hemminger wrote: >> On Fri, 27 Jan 2017 09:56:53 -0500 >> Aaron Conole wrote: >> >> > + if (rte_eal_alarm_init() < 0) { >> > + RTE_LOG (ERR, EAL, "Cannot init interrupt-handling thread\n"); >> > + /* rte_eal_alarm_init sets rte_errno on failure. */ >> > + errno = rte_errno; >> >> Hmm. DPDK in general does not reset errno but instead uses error code >> directly on return (best) or in some cases rte_errno > > I think we'll disagree on what way of returning error codes is best :-), but > yes, DPDK does not generally modify errno. Okay, I'll drop the errno set. I think it's a mistake from the first version of the series (as RFC). Thanks for the reviews, Bruce and Stephen!