From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE844C433DF for ; Tue, 14 Jul 2020 11:47:22 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C781E2220D for ; Tue, 14 Jul 2020 11:47:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C781E2220D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jvJOz-0005Np-0N; Tue, 14 Jul 2020 11:47:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jvJOx-0005Nj-Pg for xen-devel@lists.xenproject.org; Tue, 14 Jul 2020 11:47:11 +0000 X-Inumbo-ID: c091a750-c5c7-11ea-8496-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c091a750-c5c7-11ea-8496-bc764e2007e4; Tue, 14 Jul 2020 11:47:11 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1762CAB3D; Tue, 14 Jul 2020 11:47:13 +0000 (UTC) Subject: Re: [PATCH v2 3/7] x86/mce: bring hypercall subop compat checking in sync again To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <5d53a2e3-716c-2213-96e5-9d37371c482c@suse.com> <20200714111900.GI7191@Air-de-Roger> From: Jan Beulich Message-ID: Date: Tue, 14 Jul 2020 13:47:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200714111900.GI7191@Air-de-Roger> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: George Dunlap , "xen-devel@lists.xenproject.org" , Paul Durrant , Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 14.07.2020 13:19, Roger Pau Monné wrote: > On Wed, Jul 01, 2020 at 12:26:54PM +0200, Jan Beulich wrote: >> Use a typedef in struct xen_mc also for the two subops "manually" >> translated in the handler, just for consistency. No functional >> change. > > I'm slightly puzzled by the fact that mc_fetch is marked as needs > checking while mc_physcpuinfo is marked as needs translation, > shouldn't both be marked as needing translation? (since both need to > handle a guest pointer using XEN_GUEST_HANDLE) I guess I'm confused - I see an exclamation mark on both respective lines in xlat.lst. Jan