From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0D12C433F5 for ; Mon, 9 May 2022 05:37:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 730CB83DFE; Mon, 9 May 2022 07:37:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="LrjssQ9b"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7DD1683E59; Mon, 9 May 2022 07:37:13 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062b.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0c::62b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CBF8C83B32 for ; Mon, 9 May 2022 07:37:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bi8sxTnWsTcgFie/OJEBbFdnzN0QxprdreQuPFhU4MT1dp0O39zkrMUEtAr/8sRIgGtvGgvaJu065FJab8GcFeLB11uG2dtVy71fliwOmFV3Qg01u8fAGKG2jJNJSnzVFUt0Tp0uJkEm1Yfh5rfGpd134ST/qKYXlt2zOBV+5I1hIMc3WMLqAzu1xSBlbz/eueOVZp+sHCpp0GM6QFX0PbPkckRWmd7jr07FU21WoRZ9RON81GjJAPwWJyiClB5d6wMl4bZV98HGgcnfsl1VUSG6NWm3InphfqoJCrefOFGySFyXFdi6T6zBfTVRXCgAehr1/eTBNYc/hOYcusDAsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uXbkR0V7YfzHhcR/PD9RS9ifpz0I0UI+YJ0HDnC09+Q=; b=YYY9lf0OfVQqEtfjRuITKg2nDOSYZtaFFuOG7zc7Adajw/cXWSN55BPzulDCXK7ZMLRj3p6ik0ZZlHokGlX9bDCI2aiXY90n37Vas4QZG+rOF+2fIZfl+0mOJRLtq/qGXsMypqrmMhjfxC8tldmYY2nfUnE1AHogmJsJnNQE+/ua+XReUGw/WkbG3i2Q6JkT1W1oONuw94WeJ1H8L4uz+gJveqizK8qzRCKBXwu+Y1MDltNhEBQzRDZSlSw3jUs6LLCQoKBasiWMH57JrYfrCKwnfACDzMh03uM41Qi8yWmUQVT4fsqf2TgWyfA2TAmCHgFnQihhQr70Xo10GRowPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uXbkR0V7YfzHhcR/PD9RS9ifpz0I0UI+YJ0HDnC09+Q=; b=LrjssQ9bzfllygDVEUhzg/Zg5KRzbuzQC38/uzRXOQrKRzv9dKOzBMtAhd+JU+7lclW8Xiq/IyVZ8h2qbf+Y3Xo3IJtWEiKJ/aNnRXBCOCWPwc4ghpOltaf9BJzi2VycGa2v65QKHHuX5l/RNQzV5pkHWlUq0YLVfp80TSFSKgY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by DB6PR04MB3237.eurprd04.prod.outlook.com (2603:10a6:6:c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Mon, 9 May 2022 05:37:07 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::fc66:662f:2a82:1420]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::fc66:662f:2a82:1420%6]) with mapi id 15.20.5227.018; Mon, 9 May 2022 05:37:07 +0000 Subject: Re: [PATCH] mmc: fsl_esdhc: Fix 'Internal clock never stabilised.' error To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Peng Fan , Priyanka Jain , Jaehoon Chung , Sinan Akman , haibo.chen@nxp.com Cc: "u-boot@lists.denx.de" References: <20220429182734.4281-1-pali@kernel.org> From: "Peng Fan (OSS)" Message-ID: Date: Mon, 9 May 2022 13:36:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20220429182734.4281-1-pali@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR01CA0139.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::19) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5635d356-2e71-4db8-c71b-08da317df4a4 X-MS-TrafficTypeDiagnostic: DB6PR04MB3237:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7RGk1aDWVkn7NZ6HKVK4hbviPN/2/y4+JqLxs1P2g57mDaBBy7e79GIBUe2OQrlpg/R14+M4WEvGmB0UOmqlSWlUpFalAdCfP2nkaLHr8CNs2ALvXzrZlwYJoGQ+aLog9Ce59K+Wp41dk3dWQUAcfCWwBG6sK61nl1K9a6kf+D6m0TjXSnfiVxNlCjkPTE02T2RAFERtor9hXPZaAQODNB+JXcaRRcL+yB5IVp1t7KZRNPP5ry9P7AlnXEfTbPKUFucoEw0Eqsam4LLzFRh3sNdpS4AMPmVWuyR4pgO2jGULXJkmwEhyg67y4hN+CczCk1RPfA1/QhTaZDRYoRjtlXuisKNk80NGial2GT+eCz4FruD2m7xz2jAhnj+V9gqrOy/0cXMcxHvpucjeUK8Q41TgA8+Kk+ikPCnaMLosNrthyRAw8fMR7PPQX1NSeqojvLqpebgbwU+GMFd8gwqqBjWhCqAx6KcZHeZLqiSaUOa3HPC+KxpnhL47BbKLzOQGvz+FEaR5PkrZ0k3jwSVMUZJghgc4QNuSWE0eseNSV/9bgAqtV7AzUg6VAi2eA3KX58+9vds2ZLHNFusRTiMFjc6yjimmoYPKp82HuprMafskHHpdFHUhASPOOb+w9M4Z2RpNvMKJtvSpdgePfsPfwSLdzq50XCic/o7HmEU2XQmuQekXLHbpRT1WMNM/zotimIYqNzRJqH886xGryUWDYAoutrqd8z8k6hMbk6FicxFoMpUBK+hgpZWshfot1RtBKoZmckqXOFRMChzwtfqb7w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(26005)(6512007)(86362001)(31696002)(186003)(8936002)(66574015)(5660300002)(53546011)(6666004)(52116002)(2616005)(31686004)(83380400001)(38350700002)(38100700002)(66556008)(66946007)(66476007)(110136005)(4326008)(8676002)(316002)(508600001)(6486002)(2906002)(6506007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TE9KSm9TQ3pVYW5mSnBYVUtjcS9uTXRMUEpTeG9Sc0ZrYjZyQmxWNTN1YnRP?= =?utf-8?B?bmVEWTNIRG5HV1ZLSjBZUkxNUTd5cVV1QXBzdnpoQ0dvRXlBRy9WL2dFdGZD?= =?utf-8?B?K0FnemhYN1h2Z2ZROHg3VWVmeTdrMHgyc2ljWC81amFJOUxmTUZxb01NaDls?= =?utf-8?B?dXRwc0YvcTF5WEl2WHdFS3VHbEtqQ2ZXUG1PQ0wvd2VXMEZUWGd6bjBrVmh3?= =?utf-8?B?Qmd5d0hVWTIyME9RenJrSVhwb21pZm9UQnVYWXVzMWdqemx2TkwyRnFxbERY?= =?utf-8?B?WlZKWXpZM1EzNUJBb3VXS2wrN1lBdzkrRXFhN2lYWTJVL1VIQWh1a1hrTS8z?= =?utf-8?B?T2pFcE9xcEpsWWtYVmxkWVFjSytEWG1ydEpNdUZmTFZ6SUp5QVhvdTAvQXVZ?= =?utf-8?B?Z3gxT0o2OTY1ZVMyRmllNXFWWldoWmNrQmVLVjNhNURFcVI1TzA2ditoUTY5?= =?utf-8?B?VkZJMVkvdU13eVROZXg2VmZMWlg4UmcvVHdvQmh2RWh6bGR1NHAwQjU3K1NF?= =?utf-8?B?clZ4aWR0bTUxUkVJeHhWY2ZPN3YwMzYwNFAvMHR4YWx1RW9ROTE1dk05b3Zx?= =?utf-8?B?ZEVGWmI3R1lSUGVYUUhoZ2EzcjZFcEg2OHFCWVV4amdHVmdhQ0dlc2toM2pO?= =?utf-8?B?M2dMYWhBbUt3UWRYbjk0WHFhYkRqT3QvV0xRem9KTHdpVjZJUHllVS8wREdt?= =?utf-8?B?dWN1UVM5TGFnc0xtZjFKSDBsZElpYUFDTWVJVXlsc1IyVmVub1JsMkFUbjFB?= =?utf-8?B?NGYrUHBhNTdXenBkenF4VFpFWGxtelYxUTM5aE95cm9IdmxRc25kOXYyWlpk?= =?utf-8?B?V2d1cG1FR2pSMUpwRmUvcHIyU2NzUVNlZjRxL3VIRmpmM1U5Y3hPTFBaVllO?= =?utf-8?B?aUdTeWtJZUh5dlp6WTVLdUlpOGNQRXgvQSs2ZHFDWm92M0tnTEJ5bHdEcFJ5?= =?utf-8?B?ZnQvR0tMcDNwRjJYVnpSTTdnVU1FWkpMWkR1M0MwRnFvbWxJcWdKZGNTWFB2?= =?utf-8?B?ZXhhazZ6MElob2tlYUZGSjdCS1pxMjVXdTAzSmpSQlg3cFNKY1paeU9SRmJ4?= =?utf-8?B?WXVGZTFpcWNjcTNodzlzd3UvZ0NwM1dvdVQ2cTNnaStUV0QvNFhmVGVVNVJJ?= =?utf-8?B?YXJKNWd2OHZyWXpxK1k5YWVLK1l6RzRsLzl3ZWdSVlRFa3A0WG1ZSDg4aElZ?= =?utf-8?B?RHFGdExTUDA3ZUR3TElwd0ljUnYvRzVvUUZvQ2pobFo3cWZFR3BsM1prZTFv?= =?utf-8?B?ekdMTXg4UENjdVFRZkd0SUVTMDhKYnVMc05qSzMzaHBFeFZsOVM3NU9HdVdN?= =?utf-8?B?dkZUNTNUbHNqTFMvOG1mN2gvbzY3alVsVGkvck90RHVOUERqS2RoZFNJczE1?= =?utf-8?B?cUJHU0laMjI1em1ibkNSd011b08zTEsrSEFYTXIwdWhtT0ZiWFREWEZxUVNS?= =?utf-8?B?WHBJRVdnZ0U3c29QMGYwQlRFUmxvcG9MVEE1NUJvZ05QQ28zMisvOVBaTEpL?= =?utf-8?B?SjRSUnVFNmJkd09ZdTZsWDYvLzMwS3RUSHpSZUlhQkN2cG0yRjBtZzBLaDBJ?= =?utf-8?B?MktYNzd6UUoveEFyVXExWTRpN2hmS0tWQ3NhU28yb056eE84NDRwSUwvMUNh?= =?utf-8?B?cUMwWWZIRHZpb0NTU1Y1aEJVRW5NUnRGL01VV20wMms1WGxLb0NqWllPVk4r?= =?utf-8?B?K2VkTXl1a3dTUDF2ZWkzaElnN20wOGZpaUFEbmxEZVhaekFwUDFLZmlDMjBN?= =?utf-8?B?NGZNVHp6bWVJOHVnTGljZDNqOGtQN0Y4SG0vYTYzcmVvUjJsczFBdmxQcDVS?= =?utf-8?B?Yk4yVlB3MVVKTEFwL3BpL1A3NDBwbHVkTlQvamN2M2FYZGo5QUdWbGc0djdy?= =?utf-8?B?OXp5WVhVTzhVUTE2TlgrUWR1cExudk5id2ZNVnZnYmNuYm5HV1RaR0IwVndV?= =?utf-8?B?RG14NHhaSGZXZU5oTCtpR2F0blQwY0puNGNycEF6eHkydm1id253TVlSRVpl?= =?utf-8?B?blhUVXd4cUJoelR1T3krZjkvbFJ2RjNOUE9INlNTSDVGS1dQNDhoZzVaSklo?= =?utf-8?B?cDdzL01WZjNvaVpSRkljMXIrRG5IY0ZRZVFHRWYrMEpURWt3SDQxVGdoWUxm?= =?utf-8?B?cmhTc0NQdC84aFM5dVJObEw5MG9sME9OQWJucjUraU1oWTcyaVpGUXREeHpZ?= =?utf-8?B?bXZsRk9pcU5vU1lLU1pqekNaeFFIMCsza0JkQnUrOWRHdVF3Nkk3OGtnb0xv?= =?utf-8?B?cTl2S1gveDB6M2ZRWmk5Z3JacmNMZVpCMDNhS25xMXNRR3A3aE5vcU5kdW1J?= =?utf-8?B?b2g2eGNXZWViVTIyQUVERmlCNkkySUZLdEhVVmZaMGpvRnR1VEc0QT09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5635d356-2e71-4db8-c71b-08da317df4a4 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 05:37:07.4440 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X2P68Vyl2fXg0scf9sZ87prxbOxJnuRaflq+tS0W4LNtvWD5ARfZsBnbI679IltXrp2nwUPpjfqbTckSf28gug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3237 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean +Haibo On 2022/4/30 2:27, Pali Rohár wrote: > Only newer eSDHC controllers set PRSSTAT_SDSTB flag. So do not wait until > flag PRSSTAT_SDSTB is set on old pre-2.2 controllers. Instead sleep for > fixed amount of time like it was before commit 6f883e501b65 ("mmc: > fsl_esdhc: Add emmc hs200 support"). > > This change fixes error 'Internal clock never stabilised.' which is printed > on P2020 board at every access to SD card. > > Fixes: 6f883e501b65 ("mmc: fsl_esdhc: Add emmc hs200 support") > Signed-off-by: Pali Rohár > --- > drivers/mmc/fsl_esdhc.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c > index fdf2cc290e06..3b3587bd8d72 100644 > --- a/drivers/mmc/fsl_esdhc.c > +++ b/drivers/mmc/fsl_esdhc.c > @@ -503,6 +503,7 @@ static void set_sysctl(struct fsl_esdhc_priv *priv, struct mmc *mmc, uint clock) > u32 time_out; > u32 value; > uint clk; > + u32 hostver; > > if (clock < mmc->cfg->f_min) > clock = mmc->cfg->f_min; > @@ -543,6 +544,14 @@ static void set_sysctl(struct fsl_esdhc_priv *priv, struct mmc *mmc, uint clock) > > esdhc_clrsetbits32(®s->sysctl, SYSCTL_CLOCK_MASK, clk); > > + /* Only newer eSDHC controllers set PRSSTAT_SDSTB flag */ > + hostver = esdhc_read32(&priv->esdhc_regs->hostver); > + if (HOSTVER_VENDOR(hostver) <= VENDOR_V_22) { > + udelay(10000); > + esdhc_setbits32(®s->sysctl, SYSCTL_PEREN | SYSCTL_CKEN); > + return; > + } > + > time_out = 20; > value = PRSSTAT_SDSTB; > while (!(esdhc_read32(®s->prsstat) & value)) { > @@ -562,6 +571,7 @@ static void esdhc_clock_control(struct fsl_esdhc_priv *priv, bool enable) > struct fsl_esdhc *regs = priv->esdhc_regs; > u32 value; > u32 time_out; > + u32 hostver; > > value = esdhc_read32(®s->sysctl); > > @@ -572,6 +582,13 @@ static void esdhc_clock_control(struct fsl_esdhc_priv *priv, bool enable) > > esdhc_write32(®s->sysctl, value); > > + /* Only newer eSDHC controllers set PRSSTAT_SDSTB flag */ > + hostver = esdhc_read32(&priv->esdhc_regs->hostver); > + if (HOSTVER_VENDOR(hostver) <= VENDOR_V_22) { > + udelay(10000); > + return; > + } > + > time_out = 20; > value = PRSSTAT_SDSTB; > while (!(esdhc_read32(®s->prsstat) & value)) { >