From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Build request info on stack before printk Date: Tue, 24 Apr 2018 12:57:41 +0100 Message-ID: References: <20180424010136.28329-1-chris@chris-wilson.co.uk> <20180424010839.22860-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 883A86E117 for ; Tue, 24 Apr 2018 11:57:45 +0000 (UTC) In-Reply-To: <20180424010839.22860-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI0LzA0LzIwMTggMDI6MDgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBwcmludGsgdW5oZWxw ZnVsbHkgaW5zZXJ0cyBhICdcbicgYmV0d2VlbiBjb25zZWN1dGl2ZSBjYWxscywgYW5kIHNpbmNl Cj4gb3VyIGRybV9wcmludGYgd3JhcHBlciBtYXkgYmUgZW1pdHRpbmcgaW5mbyBhIHNlcV9maWxl IGluc3RlYWQsCj4gS0VSTl9DT05UIGlzIG5vdCBhbiBvcHRpb24uIFRvIHdvcmsgd2l0aCBhbnkg ZHJtX3ByaW50ZiBkZXN0aW5hdGlvbiwgd2UKPiBuZWVkIHRvIGJ1aWxkIHVwIHRoZSBvdXRwdXQg aW50byBhIHRlbXBvcmFyeSBidWYgb24gdGhlIHN0YWNrIGFuZCB0aGVuCj4gZmVlZCB0aGUgY29t cGxldGUgbGluZSBpbiBhIHNpbmdsZSBjYWxsIHRvIHByaW50ay4KPiAKPiBGaXhlczogYjcyNjhj NWVlZDBhICgiZHJtL2k5MTU6IFBhY2sgcGFyYW1zIHRvIGVuZ2luZS0+c2NoZWR1bGUoKSBpbnRv IGEgc3RydWN0IikKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp bHNvbi5jby51az4KPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXgu aW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2Nz LmMgfCAyNCArKysrKysrKysrKysrKystLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxNSBp bnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2VuZ2luZV9jcy5jCj4gaW5kZXggYmU2MDhmNzExMWY1Li42NmNkZGQwNTk2NjYgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+IEBAIC0xMTEzLDE0ICsxMTEzLDE3 IEBAIHVuc2lnbmVkIGludCBpbnRlbF9lbmdpbmVzX2hhc19jb250ZXh0X2lzb2xhdGlvbihzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPiAgIAlyZXR1cm4gd2hpY2g7Cj4gICB9Cj4gICAK PiAtc3RhdGljIHZvaWQgcHJpbnRfc2NoZWRfYXR0cihzdHJ1Y3QgZHJtX3ByaW50ZXIgKm0sCj4g LQkJCSAgICAgY29uc3Qgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4gLQkJCSAgICAg Y29uc3Qgc3RydWN0IGk5MTVfc2NoZWRfYXR0ciAqYXR0cikKPiArc3RhdGljIGludCBwcmludF9z Y2hlZF9hdHRyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ICsJCQkgICAgY29uc3Qg c3RydWN0IGk5MTVfc2NoZWRfYXR0ciAqYXR0ciwKPiArCQkJICAgIGNoYXIgKmJ1ZiwgaW50IHgs IGludCBsZW4pCj4gICB7Cj4gICAJaWYgKGF0dHItPnByaW9yaXR5ID09IEk5MTVfUFJJT1JJVFlf SU5WQUxJRCkKPiAtCQlyZXR1cm47Cj4gKwkJcmV0dXJuIHg7Cj4gKwo+ICsJeCArPSBzbnByaW50 ZihidWYgKyB4LCBsZW4gLSB4LAo+ICsJCSAgICAgICIgcHJpbz0lZCIsIGF0dHItPnByaW9yaXR5 KTsKPiAgIAo+IC0JZHJtX3ByaW50ZihtLCAicHJpbz0lZCIsIGF0dHItPnByaW9yaXR5KTsKPiAr CXJldHVybiB4Owo+ICAgfQo+ICAgCj4gICBzdGF0aWMgdm9pZCBwcmludF9yZXF1ZXN0KHN0cnVj dCBkcm1fcHJpbnRlciAqbSwKPiBAQCAtMTEyOCwxNCArMTEzMSwxNyBAQCBzdGF0aWMgdm9pZCBw cmludF9yZXF1ZXN0KHN0cnVjdCBkcm1fcHJpbnRlciAqbSwKPiAgIAkJCSAgY29uc3QgY2hhciAq cHJlZml4KQo+ICAgewo+ICAgCWNvbnN0IGNoYXIgKm5hbWUgPSBycS0+ZmVuY2Uub3BzLT5nZXRf dGltZWxpbmVfbmFtZSgmcnEtPmZlbmNlKTsKPiArCWNoYXIgYnVmWzgwXTsKCldvcnRoIHVzaW5n IGxlc3Mgc3RhY2sgc3BhY2U/IDYgY2hhcnMgcGx1cyBtYXggbmVnYXRpdmUgaW50ICgxMikgLSAx OCAKc2hvdWxkIGJlIGVub3VnaD8KCj4gKwlpbnQgeCA9IDA7Cj4gKwo+ICsJeCA9IHByaW50X3Nj aGVkX2F0dHIocnEtPmk5MTUsICZycS0+c2NoZWQuYXR0ciwgYnVmLCB4LCBzaXplb2YoYnVmKSk7 Cgp4IGlzIGVmZmVjdGl2ZWx5IHVudXNlZC4gRHJvcCBpdCBhbmQgc2ltcGxpZnkgdGhlIGhlbHBl ciBhbmQgYWxsPwoKPiAgIAo+IC0JZHJtX3ByaW50ZihtLCAiJXMleCVzIFslbGx4OiV4XSAiLAo+ ICsJZHJtX3ByaW50ZihtLCAiJXMleCVzIFslbGx4OiV4XSVzIEAgJWRtczogJXNcbiIsCj4gICAJ CSAgIHByZWZpeCwKPiAgIAkJICAgcnEtPmdsb2JhbF9zZXFubywKPiAgIAkJICAgaTkxNV9yZXF1 ZXN0X2NvbXBsZXRlZChycSkgPyAiISIgOiAiIiwKPiAtCQkgICBycS0+ZmVuY2UuY29udGV4dCwg cnEtPmZlbmNlLnNlcW5vKTsKPiAtCXByaW50X3NjaGVkX2F0dHIobSwgcnEtPmk5MTUsICZycS0+ c2NoZWQuYXR0cik7Cj4gLQlkcm1fcHJpbnRmKG0sICIgQCAlZG1zOiAlc1xuIiwKPiArCQkgICBy cS0+ZmVuY2UuY29udGV4dCwgcnEtPmZlbmNlLnNlcW5vLAo+ICsJCSAgIGJ1ZiwKPiAgIAkJICAg amlmZmllc190b19tc2VjcyhqaWZmaWVzIC0gcnEtPmVtaXR0ZWRfamlmZmllcyksCj4gICAJCSAg IG5hbWUpOwo+ICAgfQo+IAoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK