All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Privoznik <mprivozn@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: lvivier@redhat.com, thuth@redhat.com, ehabkost@redhat.com,
	mst@redhat.com, libvir-list@redhat.com, cohuck@redhat.com,
	david@redhat.com, dgilbert@redhat.com, armbru@redhat.com,
	pasic@linux.ibm.com, borntraeger@de.ibm.com,
	qemu-s390x@nongnu.org, pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [PATCH v2] cphp: remove deprecated cpu-add command(s)
Date: Mon, 14 Sep 2020 10:07:36 +0200	[thread overview]
Message-ID: <f8406b80-0243-49bf-a384-5c625d9a7974@redhat.com> (raw)
In-Reply-To: <20200914074614.973112-1-imammedo@redhat.com>

On 9/14/20 9:46 AM, Igor Mammedov wrote:
> theses were deprecated since 4.0, remove both HMP and QMP variants.
> 
> Users should use device_add command instead. To get list of
> possible CPUs and options, use 'info hotpluggable-cpus' HMP
> or query-hotpluggable-cpus QMP command.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>   include/hw/boards.h         |   1 -
>   include/hw/i386/pc.h        |   1 -
>   include/monitor/hmp.h       |   1 -
>   docs/system/deprecated.rst  |  25 +++++----
>   hmp-commands.hx             |  15 ------
>   hw/core/machine-hmp-cmds.c  |  12 -----
>   hw/core/machine-qmp-cmds.c  |  12 -----
>   hw/i386/pc.c                |  27 ----------
>   hw/i386/pc_piix.c           |   1 -
>   hw/s390x/s390-virtio-ccw.c  |  12 -----
>   qapi/machine.json           |  24 ---------
>   tests/qtest/cpu-plug-test.c | 100 ++++--------------------------------
>   tests/qtest/test-hmp.c      |   1 -
>   13 files changed, 21 insertions(+), 211 deletions(-)

Thanks to Peter Libvirt uses device_add instead cpu_add whenever 
possible. Hence this is okay from Libvirt's POV.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal



  reply	other threads:[~2020-09-14  8:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14  7:46 [PATCH v2] cphp: remove deprecated cpu-add command(s) Igor Mammedov
2020-09-14  8:07 ` Michal Privoznik [this message]
2020-09-14 10:09   ` Igor Mammedov
2020-09-14 14:55 ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8406b80-0243-49bf-a384-5c625d9a7974@redhat.com \
    --to=mprivozn@redhat.com \
    --cc=armbru@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.