From: Daniel Borkmann <daniel@iogearbox.net>
To: Martin KaFai Lau <kafai@fb.com>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
kernel-team@fb.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 bpf 0/2] bpf: net: Fixes in sk_user_data of reuseport_array
Date: Thu, 9 Jul 2020 22:07:06 +0200 [thread overview]
Message-ID: <f84a5aeb-9040-f7dc-d4ed-63bd6d764878@iogearbox.net> (raw)
In-Reply-To: <20200709061057.4018499-1-kafai@fb.com>
On 7/9/20 8:10 AM, Martin KaFai Lau wrote:
> This set fixes two issues on sk_user_data when a sk is added to
> a reuseport_array.
>
> The first patch is to avoid the sk_user_data being copied
> to a cloned sk. The second patch avoids doing bpf_sk_reuseport_detach()
> on sk_user_data that is not managed by reuseport_array.
>
> Since the changes are mostly related to bpf reuseport_array, so it is
> currently tagged as bpf fixes.
>
> v2:
> - Avoid ~3UL (Andrii)
>
> Martin KaFai Lau (2):
> bpf: net: Avoid copying sk_user_data of reuseport_array during
> sk_clone
> bpf: net: Avoid incorrect bpf_sk_reuseport_detach call
>
> include/net/sock.h | 3 ++-
> kernel/bpf/reuseport_array.c | 14 ++++++++++----
> 2 files changed, 12 insertions(+), 5 deletions(-)
>
Applied, thanks!
prev parent reply other threads:[~2020-07-09 20:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 6:10 [PATCH v2 bpf 0/2] bpf: net: Fixes in sk_user_data of reuseport_array Martin KaFai Lau
2020-07-09 6:11 ` [PATCH v2 bpf 1/2] bpf: net: Avoid copying sk_user_data of reuseport_array during sk_clone Martin KaFai Lau
2020-07-09 16:46 ` Jakub Sitnicki
2020-07-09 20:07 ` Daniel Borkmann
2020-07-09 21:27 ` Martin KaFai Lau
2020-07-09 6:11 ` [PATCH v2 bpf 2/2] bpf: net: Avoid incorrect bpf_sk_reuseport_detach call Martin KaFai Lau
2020-07-09 10:58 ` James Chapman
2020-07-09 18:47 ` Martin KaFai Lau
2020-07-09 20:07 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f84a5aeb-9040-f7dc-d4ed-63bd6d764878@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.