From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 613AEC433F5 for ; Tue, 7 Sep 2021 11:21:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44D906109F for ; Tue, 7 Sep 2021 11:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343679AbhIGLWk (ORCPT ); Tue, 7 Sep 2021 07:22:40 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:19016 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245597AbhIGLWj (ORCPT ); Tue, 7 Sep 2021 07:22:39 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4H3jRJ5ZbqzbmBK; Tue, 7 Sep 2021 19:17:32 +0800 (CST) Received: from dggpeml500025.china.huawei.com (7.185.36.35) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Tue, 7 Sep 2021 19:21:32 +0800 Received: from [10.174.176.117] (10.174.176.117) by dggpeml500025.china.huawei.com (7.185.36.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Tue, 7 Sep 2021 19:21:32 +0800 Subject: Re: [PATCH] ext4: limit the number of blocks in one ADD_RANGE TLV From: Hou Tao To: , , CC: References: <20210820044505.474318-1-houtao1@huawei.com> <0129a56a-2d45-5558-9125-0b3408104b7d@huawei.com> Message-ID: Date: Tue, 7 Sep 2021 19:21:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <0129a56a-2d45-5558-9125-0b3408104b7d@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.176.117] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500025.china.huawei.com (7.185.36.35) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org ping ? On 8/30/2021 3:52 PM, Hou Tao wrote: > ping ? > > On 8/20/2021 12:45 PM, Hou Tao wrote: >> Now EXT4_FC_TAG_ADD_RANGE uses ext4_extent to track the >> newly-added blocks, but the limit on the max value of >> ee_len field is ignored, and it can lead to BUG_ON as >> shown below when running command "fallocate -l 128M file" >> on a fast_commit-enabled fs: >> >> kernel BUG at fs/ext4/ext4_extents.h:199! >> invalid opcode: 0000 [#1] SMP PTI >> CPU: 3 PID: 624 Comm: fallocate Not tainted 5.14.0-rc6+ #1 >> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996) >> RIP: 0010:ext4_fc_write_inode_data+0x1f3/0x200 >> Call Trace: >> ? ext4_fc_write_inode+0xf2/0x150 >> ext4_fc_commit+0x93b/0xa00 >> ? ext4_fallocate+0x1ad/0x10d0 >> ext4_sync_file+0x157/0x340 >> ? ext4_sync_file+0x157/0x340 >> vfs_fsync_range+0x49/0x80 >> do_fsync+0x3d/0x70 >> __x64_sys_fsync+0x14/0x20 >> do_syscall_64+0x3b/0xc0 >> entry_SYSCALL_64_after_hwframe+0x44/0xae >> >> Simply fixing it by limiting the number of blocks >> in one EXT4_FC_TAG_ADD_RANGE TLV. >> >> Fixes: aa75f4d3daae ("ext4: main fast-commit commit path") >> Signed-off-by: Hou Tao >> --- >> fs/ext4/fast_commit.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c >> index e8195229c252..782d05a3f97a 100644 >> --- a/fs/ext4/fast_commit.c >> +++ b/fs/ext4/fast_commit.c >> @@ -893,6 +893,12 @@ static int ext4_fc_write_inode_data(struct inode *inode, u32 *crc) >> sizeof(lrange), (u8 *)&lrange, crc)) >> return -ENOSPC; >> } else { >> + unsigned int max = (map.m_flags & EXT4_MAP_UNWRITTEN) ? >> + EXT_UNWRITTEN_MAX_LEN : EXT_INIT_MAX_LEN; >> + >> + /* Limit the number of blocks in one extent */ >> + map.m_len = min(max, map.m_len); >> + >> fc_ext.fc_ino = cpu_to_le32(inode->i_ino); >> ex = (struct ext4_extent *)&fc_ext.fc_ex; >> ex->ee_block = cpu_to_le32(map.m_lblk); > .