From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-devel@nongnu.org
Cc: David Gibson <david@gibson.dropbear.id.au>,
Markus Armbruster <armbru@redhat.com>,
Andrea Bolognani <abologna@redhat.com>
Subject: Re: [Qemu-devel] [PATCH qemu v3 1/2] qmp: Merge ObjectPropertyInfo and DevicePropertyInfo
Date: Fri, 2 Mar 2018 14:42:24 +0100 [thread overview]
Message-ID: <f8511c97-74c2-94e1-85ce-e03cd2bf2e21@redhat.com> (raw)
In-Reply-To: <3986fcf2-844d-bc49-d297-960f788c3941@redhat.com>
On 02/03/2018 14:37, Eric Blake wrote:
>>
>> index 0262b9f..87327e5 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -1266,10 +1266,12 @@
>> # 3) A link type in the form 'link<subtype>' where subtype is
>> a qdev
>> # device type name. Link properties form the device model
>> graph.
>> #
>> +# @description: if specified, the description of the property.
>
> Missing a '(since 2.12)' tag.
Some of the users had it (in other types that are now unified) before
2.12. I'm not sure whether it is more accurate to have the annotation
or not, especially considering that it is optional. Protocol-wise it is
never an issue to add optional fields, since you cannot distinguish an
implementation that lacks the field from one that never fills it.
Paolo
next prev parent reply other threads:[~2018-03-02 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 13:09 [Qemu-devel] [PATCH qemu v3 0/2] qmp: Add qom-list-properties to list QOM object properties Alexey Kardashevskiy
2018-03-01 13:09 ` [Qemu-devel] [PATCH qemu v3 1/2] qmp: Merge ObjectPropertyInfo and DevicePropertyInfo Alexey Kardashevskiy
2018-03-02 1:00 ` David Gibson
2018-03-02 13:37 ` Eric Blake
2018-03-02 13:42 ` Paolo Bonzini [this message]
2018-03-02 14:10 ` Eric Blake
2018-03-03 0:16 ` Alexey Kardashevskiy
2018-03-01 13:09 ` [Qemu-devel] [PATCH qemu v3 2/2] qmp: Add qom-list-properties to list QOM object properties Alexey Kardashevskiy
2018-03-02 2:05 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8511c97-74c2-94e1-85ce-e03cd2bf2e21@redhat.com \
--to=pbonzini@redhat.com \
--cc=abologna@redhat.com \
--cc=aik@ozlabs.ru \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.