From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 1/3] net/thunderx: disable pmd for older compilers Date: Thu, 6 Apr 2017 15:05:48 +0100 Message-ID: References: <20170406121428.16883-1-ferruh.yigit@intel.com> <20170406134637.4484-1-ferruh.yigit@intel.com> <2608561.Cu0AakAGmg@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Jerin Jacob , Bruce Richardson , Harry van Haaren , dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id EB1992C6E for ; Thu, 6 Apr 2017 16:05:51 +0200 (CEST) In-Reply-To: <2608561.Cu0AakAGmg@xps13> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/6/2017 2:59 PM, Thomas Monjalon wrote: > 2017-04-06 14:46, Ferruh Yigit: >> --- a/mk/toolchain/gcc/rte.toolchain-compat.mk >> +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk >> @@ -89,4 +89,8 @@ else >> ifeq ($(shell test $(GCC_VERSION) -lt 42 && echo 1), 1) >> MACHINE_CFLAGS := $(filter-out -march% -mtune% -msse%,$(MACHINE_CFLAGS)) >> endif >> + >> + ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1) >> + CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=n >> + endif > > In previous version you were disabling the PMD inside the PMD Makefile. > It was better. Agreed, but I that is causing a build error in applications. I have missed it in previous release because an .a file was already created. So, need a way to disable linking pmd against application.