From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH] virtio_ring: fix packed ring event may missing Date: Tue, 22 Oct 2019 21:05:30 +0800 Message-ID: References: <20191021171004.18729-1-yong.liu@intel.com> <78d15397-984d-8679-383d-fb20dc63b449@redhat.com> <86228AFD5BCD8E4EBFD2B90117B5E81E633D74EF@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E633D74EF@SHSMSX103.ccr.corp.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Liu, Yong" , "mst@redhat.com" , "Bie, Tiwei" Cc: "virtualization@lists.linux-foundation.org" List-Id: virtualization@lists.linuxfoundation.org Ck9uIDIwMTkvMTAvMjIg5LiL5Y2IMjo0OCwgTGl1LCBZb25nIHdyb3RlOgo+IEhpIEphc29uLAo+ IE15IGFuc3dlcnMgYXJlIGlubGluZS4KPgo+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ PiBGcm9tOiBKYXNvbiBXYW5nIFttYWlsdG86amFzb3dhbmdAcmVkaGF0LmNvbV0KPj4gU2VudDog VHVlc2RheSwgT2N0b2JlciAyMiwgMjAxOSAxMDo0NSBBTQo+PiBUbzogTGl1LCBZb25nIDx5b25n LmxpdUBpbnRlbC5jb20+OyBtc3RAcmVkaGF0LmNvbTsgQmllLCBUaXdlaQo+PiA8dGl3ZWkuYmll QGludGVsLmNvbT4KPj4gQ2M6IHZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24u b3JnCj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIHZpcnRpb19yaW5nOiBmaXggcGFja2VkIHJpbmcg ZXZlbnQgbWF5IG1pc3NpbmcKPj4KPj4KPj4gT24gMjAxOS8xMC8yMiDkuIrljYgxOjEwLCBNYXJ2 aW4gTGl1IHdyb3RlOgo+Pj4gV2hlbiBjYWxsYmFjayBpcyBkZWxheWVkLCB2aXJ0aW8gZXhwZWN0 IHRoYXQgdmhvc3Qgd2lsbCBraWNrIHdoZW4KPj4+IHJvbGxpbmcgb3ZlciBldmVudCBvZmZzZXQu IFJlY2hlY2sgc2hvdWxkIGJlIHRha2VuIGFzIHVzZWQgaW5kZXggbWF5Cj4+PiBleGNlZWQgZXZl bnQgb2Zmc2V0IGJldHdlZW4gc3RhdHVzIGNoZWNrIGFuZCBkcml2ZXIgZXZlbnQgdXBkYXRlLgo+ Pj4KPj4+IEhvd2V2ZXIsIGl0IGlzIHBvc3NpYmxlIHRoYXQgZmxhZ3Mgd2FzIG5vdCBtb2RpZmll ZCBpZiBkZXNjcmlwdG9ycyBhcmUKPj4+IGNoYWluZWQgb3IgaW5fb3JkZXIgZmVhdHVyZSB3YXMg bmVnb3RpYXRlZC4gU28gZmxhZ3MgYXQgZXZlbnQgb2Zmc2V0Cj4+PiBtYXkgbm90IGJlIHZhbGlk IGZvciBkZXNjcmlwdG9yJ3Mgc3RhdHVzIGNoZWNraW5nLiBGaXggaXQgYnkgdXNpbmcgbGFzdAo+ Pj4gdXNlZCBpbmRleCBhcyByZXBsYWNlbWVudC4gVHggcXVldWUgd2lsbCBiZSBzdG9wcGVkIGlm IHRoZXJlJ3Mgbm90Cj4+PiBlbm91Z2ggZnJlZWQgYnVmZmVycyBhZnRlciByZWNoZWNrLgo+Pj4K Pj4+IFNpZ25lZC1vZmYtYnk6IE1hcnZpbiBMaXUgPHlvbmcubGl1QGludGVsLmNvbT4KPj4+Cj4+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aXJ0aW8vdmlydGlvX3JpbmcuYyBiL2RyaXZlcnMvdmly dGlvL3ZpcnRpb19yaW5nLmMKPj4+IGluZGV4IGJkYzA4MjQ0YTY0OC4uYTgwNDFlNDUxZTllIDEw MDY0NAo+Pj4gLS0tIGEvZHJpdmVycy92aXJ0aW8vdmlydGlvX3JpbmcuYwo+Pj4gKysrIGIvZHJp dmVycy92aXJ0aW8vdmlydGlvX3JpbmcuYwo+Pj4gQEAgLTE0OTksOSArMTQ5OSw2IEBAIHN0YXRp YyBib29sCj4+IHZpcnRxdWV1ZV9lbmFibGVfY2JfZGVsYXllZF9wYWNrZWQoc3RydWN0IHZpcnRx dWV1ZSAqX3ZxKQo+Pj4gICAgCQkgKiBjb3VudGVyIGZpcnN0IGJlZm9yZSB1cGRhdGluZyBldmVu dCBmbGFncy4KPj4+ICAgIAkJICovCj4+PiAgICAJCXZpcnRpb193bWIodnEtPndlYWtfYmFycmll cnMpOwo+Pj4gLQl9IGVsc2Ugewo+Pj4gLQkJdXNlZF9pZHggPSB2cS0+bGFzdF91c2VkX2lkeDsK Pj4+IC0JCXdyYXBfY291bnRlciA9IHZxLT5wYWNrZWQudXNlZF93cmFwX2NvdW50ZXI7Cj4+PiAg ICAJfQo+Pj4KPj4+ICAgIAlpZiAodnEtPnBhY2tlZC5ldmVudF9mbGFnc19zaGFkb3cgPT0gVlJJ TkdfUEFDS0VEX0VWRU5UX0ZMQUdfRElTQUJMRSkKPj4gewo+Pj4gQEAgLTE1MTgsNyArMTUxNSw5 IEBAIHN0YXRpYyBib29sCj4+IHZpcnRxdWV1ZV9lbmFibGVfY2JfZGVsYXllZF9wYWNrZWQoc3Ry dWN0IHZpcnRxdWV1ZSAqX3ZxKQo+Pj4gICAgCSAqLwo+Pj4gICAgCXZpcnRpb19tYih2cS0+d2Vh a19iYXJyaWVycyk7Cj4+Pgo+Pj4gLQlpZiAoaXNfdXNlZF9kZXNjX3BhY2tlZCh2cSwgdXNlZF9p ZHgsIHdyYXBfY291bnRlcikpIHsKPj4+ICsJaWYgKGlzX3VzZWRfZGVzY19wYWNrZWQodnEsCj4+ PiArCQkJCXZxLT5sYXN0X3VzZWRfaWR4LAo+Pj4gKwkJCQl2cS0+cGFja2VkLnVzZWRfd3JhcF9j b3VudGVyKSkgewo+Pj4gICAgCQlFTkRfVVNFKHZxKTsKPj4+ICAgIAkJcmV0dXJuIGZhbHNlOwo+ Pj4gICAgCX0KPj4KPj4gSGkgTWFydmluOgo+Pgo+PiBUd28gcXVlc3Rpb25zOgo+Pgo+PiAxKSBE byB3ZSBzdXBwb3J0IElOX09SREVSIGluIGtlcm5lbCBkcml2ZXI/Cj4+Cj4gTm90IHN1cHBvcnQg Ynkgbm93LiBCdXQgaXNzdWUgc3RpbGwgY2FuIGJlIHBvc3NpYmxlIGlmIGluX2RpcmVjdCBkaXNh YmxlZCBhbmQgbWVhbndoaWxlIGRlc2NzIGFyZSBjaGFpbmVkLgo+IER1ZSB0byBwYWNrZWQgcmlu ZyBkZXNjIHN0YXR1cyBzaG91bGQgY2hlY2sgb25lIGJ5IG9uZSwgY2hvc2UgYXJiaXRyYXJ5IHBv c2l0aW9uIG1heSBjYXVzZSBpc3N1ZS4KCgpSaWdodCwgdGhlbiBpdCdzIGJldHRlciB0byBtZW50 aW9uIElOX09SREVSIGFzIGZ1dHVyZSBmZWF0dXJlcy4KCgo+Cj4+IDIpIFNob3VsZCB3ZSBjaGVj ayBJTl9PUkRFUiBpbiB0aGlzIGNhc2Ugb3RoZXJ3aXNlIHdlIG1heSBlbmQgdXAgd2l0aAo+PiBp bnRlcnJ1cHQgc3Rvcm0gd2hlbiBJTl9PUkRFUiBpcyBub3QgbmVnb3RpYXRlZD8KPiBJbnRlcnJ1 cHQgbnVtYmVyIHdpbGwgbm90IGluY3JlYXNlIGhlcmUsIGV2ZW50IG9mZnNldCB2YWx1ZSBjYWxj dWxhdGVkIGFzIGJlZm9yZS4KPiBIZXJlIGp1c3QgcmVjaGVjayB3aGV0aGVyIG5ldyB1c2VkIGRl c2NzIGlzIGVub3VnaCBmb3IgbmV4dCBhcm91bmQgeG1pdC4KPiBJZiBiYWNrZW5kIHdhcyBzbG93 LCBtb3N0IGxpa2VseSBUeCBxdWV1ZSB3aWxsIHNsZWVwIGZvciBhIHdoaWxlIHVudGlsIHVzZWQg aW5kZXggZ28gb3ZlciBldmVudCBvZmZzZXQuCgoKT2ssIGJ1dCB3aGF0IGlmIHRoZSBiYWNrZW5k IGlzIGFsbW9zdCBhcyBmYXN0IGFzIGd1ZXN0IGRyaXZlcj8gRS5nIGluIAp2aXJ0aW8tbmV0IHdl IGhhZDoKCiDCoMKgwqAgaWYgKHNxLT52cS0+bnVtX2ZyZWUgPCAyK01BWF9TS0JfRlJBR1MpIHsK IMKgwqDCoCDCoMKgwqAgbmV0aWZfc3RvcF9zdWJxdWV1ZShkZXYsIHFudW0pOwogwqDCoMKgIMKg wqDCoCBpZiAoIXVzZV9uYXBpICYmCiDCoMKgwqAgwqDCoMKgIMKgwqDCoCB1bmxpa2VseSghdmly dHF1ZXVlX2VuYWJsZV9jYl9kZWxheWVkKHNxLT52cSkpKSB7CiDCoMKgwqAgwqDCoMKgIMKgwqDC oCAvKiBNb3JlIGp1c3QgZ290IHVzZWQsIGZyZWUgdGhlbSB0aGVuIHJlY2hlY2suICovCiDCoMKg wqAgwqDCoMKgIMKgwqDCoCBmcmVlX29sZF94bWl0X3NrYnMoc3EsIGZhbHNlKTsKIMKgwqDCoCDC oMKgwqAgwqDCoMKgIGlmIChzcS0+dnEtPm51bV9mcmVlID49IDIrTUFYX1NLQl9GUkFHUykgewog wqDCoMKgIMKgwqDCoCDCoMKgwqAgwqDCoMKgIG5ldGlmX3N0YXJ0X3N1YnF1ZXVlKGRldiwgcW51 bSk7CiDCoMKgwqAgwqDCoMKgIMKgwqDCoCDCoMKgwqAgdmlydHF1ZXVlX2Rpc2FibGVfY2Ioc3Et PnZxKTsKIMKgwqDCoCDCoMKgwqAgwqDCoMKgIH0KIMKgwqDCoCDCoMKgwqAgfQogwqDCoMKgIH0K Ckkgd29ycnkgdGhhdCB3ZSBtYXkgZW5kIHVwIHdpdGggdG9nZ2xpbmcgcXVldWUgc3RhdGUgaW4g dGhlIGNhc2UgCihzcS0+dnEtPm51bV9mcmVlIGlzIG5lYXIgMiArIE1BWF9TS0JfRlJBR1MpLgoK SXQgbG9va3MgdG8gbWUgdGhlIGNvcnJlY3QgdGhpbmcgdG8gaW1wbGVtZW50IGlzIHRvIGNhbGN1 bGF0ZSB0aGUgaGVhZCAKZGVzY3JpcHRvciBvZiBhIGNoYWluIHRoYXQgc2l0cyBhdCAzLzQuCgpU aGFua3MKCgo+Cj4gVGhhbmtzLAo+IE1hcnZpbgo+Cj4+IFRoYW5rcwo+PgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGlu ZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8v bGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u