From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF65C48BE9 for ; Mon, 24 Jun 2019 14:48:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F03E32063F for ; Mon, 24 Jun 2019 14:48:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728850AbfFXOsE (ORCPT ); Mon, 24 Jun 2019 10:48:04 -0400 Received: from skedge03.snt-world.com ([91.208.41.68]:43484 "EHLO skedge03.snt-world.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725562AbfFXOsE (ORCPT ); Mon, 24 Jun 2019 10:48:04 -0400 Received: from sntmail12r.snt-is.com (unknown [10.203.32.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by skedge03.snt-world.com (Postfix) with ESMTPS id 7D8DA67A90A; Mon, 24 Jun 2019 16:47:51 +0200 (CEST) Received: from sntmail12r.snt-is.com (10.203.32.182) by sntmail12r.snt-is.com (10.203.32.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 24 Jun 2019 16:47:50 +0200 Received: from sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305]) by sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305%3]) with mapi id 15.01.1713.004; Mon, 24 Jun 2019 16:47:50 +0200 From: Schrempf Frieder To: liaoweixiong , Miquel Raynal , Richard Weinberger , "David Woodhouse" , Brian Norris , Marek Vasut , Vignesh Raghavendra , Boris Brezillon , Frieder Schrempf , Peter Pan , "Chuanhong Guo" CC: "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips Thread-Topic: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips Thread-Index: AQHVKoaYbYsysfnJPUKsxvje/QcCeKaqwQIA Date: Mon, 24 Jun 2019 14:47:50 +0000 Message-ID: References: <1561378534-26119-1-git-send-email-liaoweixiong@allwinnertech.com> In-Reply-To: <1561378534-26119-1-git-send-email-liaoweixiong@allwinnertech.com> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.9.193] x-c2processedorg: 51b406b7-48a2-4d03-b652-521f56ac89f3 Content-Type: text/plain; charset="utf-8" Content-ID: <9FE31BB9AAE8204BAD101611478CAFA2@snt-world.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-SnT-MailScanner-Information: Please contact the ISP for more information X-SnT-MailScanner-ID: 7D8DA67A90A.A00F2 X-SnT-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details X-SnT-MailScanner-SpamCheck: X-SnT-MailScanner-From: frieder.schrempf@kontron.de X-SnT-MailScanner-To: bbrezillon@kernel.org, computersforpeace@gmail.com, dwmw2@infradead.org, frieder.schrempf@exceet.de, gch981213@gmail.com, liaoweixiong@allwinnertech.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, marek.vasut@gmail.com, miquel.raynal@bootlin.com, peterpandong@micron.com, richard@nod.at, stable@vger.kernel.org, vigneshr@ti.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gMjQuMDYuMTkgMTQ6MTUsIGxpYW93ZWl4aW9uZyB3cm90ZToNCj4gSW4gY2FzZSBvZiB0aGUg bGFzdCBwYWdlIGNvbnRhaW5pbmcgYml0ZmxpcHMgKHJldCA+IDApLA0KPiBzcGluYW5kX210ZF9y ZWFkKCkgd2lsbCByZXR1cm4gdGhhdCBudW1iZXIgb2YgYml0ZmxpcHMgZm9yIHRoZSBsYXN0DQo+ IHBhZ2UuIEJ1dCB0byBtZSBpdCBsb29rcyBsaWtlIGl0IHNob3VsZCBpbnN0ZWFkIHJldHVybiBt YXhfYml0ZmxpcHMgbGlrZQ0KPiBpdCBkb2VzIHdoZW4gdGhlIGxhc3QgcGFnZSByZWFkIHJldHVy bnMgd2l0aCAwLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogbGlhb3dlaXhpb25nIDxsaWFvd2VpeGlv bmdAYWxsd2lubmVydGVjaC5jb20+DQo+IEFja2VkLWJ5OiBCb3JpcyBCcmV6aWxsb24gPGJvcmlz LmJyZXppbGxvbkBjb2xsYWJvcmEuY29tPg0KPiBBY2tlZC1ieTogRnJpZWRlciBTY2hyZW1wZiA8 ZnJpZWRlci5zY2hyZW1wZkBrb250cm9uLmRlPg0KDQpXaHkgZGlkIHlvdSBjaGFuZ2Ugb3VyIFJl dmlld2VkLWJ5IHRhZ3MgdG8gQWNrZWQtYnkgdGFncz8NCg0KPiBGaXhlczogNzUyOWRmNDY1MjQ4 ICgibXRkOiBuYW5kOiBBZGQgY29yZSBpbmZyYXN0cnVjdHVyZSB0byBzdXBwb3J0IFNQSSBOQU5E cyIpDQo+IC0tLQ0KPiAgIGRyaXZlcnMvbXRkL25hbmQvc3BpL2NvcmUuYyB8IDIgKy0NCj4gICAx IGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL210ZC9uYW5kL3NwaS9jb3JlLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Nw aS9jb3JlLmMNCj4gaW5kZXggNTU2YmZkYi4uNmI5Mzg4ZCAxMDA2NDQNCj4gLS0tIGEvZHJpdmVy cy9tdGQvbmFuZC9zcGkvY29yZS5jDQo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvc3BpL2NvcmUu Yw0KPiBAQCAtNTExLDEyICs1MTEsMTIgQEAgc3RhdGljIGludCBzcGluYW5kX210ZF9yZWFkKHN0 cnVjdCBtdGRfaW5mbyAqbXRkLCBsb2ZmX3QgZnJvbSwNCj4gICAJCWlmIChyZXQgPT0gLUVCQURN U0cpIHsNCj4gICAJCQllY2NfZmFpbGVkID0gdHJ1ZTsNCj4gICAJCQltdGQtPmVjY19zdGF0cy5m YWlsZWQrKzsNCj4gLQkJCXJldCA9IDA7DQo+ICAgCQl9IGVsc2Ugew0KPiAgIAkJCW10ZC0+ZWNj X3N0YXRzLmNvcnJlY3RlZCArPSByZXQ7DQo+ICAgCQkJbWF4X2JpdGZsaXBzID0gbWF4X3QodW5z aWduZWQgaW50LCBtYXhfYml0ZmxpcHMsIHJldCk7DQo+ICAgCQl9DQo+ICAgDQo+ICsJCXJldCA9 IDA7DQo+ICAgCQlvcHMtPnJldGxlbiArPSBpdGVyLnJlcS5kYXRhbGVuOw0KPiAgIAkJb3BzLT5v b2JyZXRsZW4gKz0gaXRlci5yZXEub29ibGVuOw0KPiAgIAl9DQo+IA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DE3DC43613 for ; Mon, 24 Jun 2019 14:48:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55E0B2063F for ; Mon, 24 Jun 2019 14:48:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VAkM4BvW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55E0B2063F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MaP/xyRLsK3ETk+s7RpcY/UUIiODOGz/OyZaIn/qH3s=; b=VAkM4BvW9QBtma i5Dl4ZRepstA5Q4+JPMUfftD+Qiz4AhLsFMioW+c0qj0skwTYQv/7qWXHc1ENbfur2jDEyVH0k0SM EAYCOVfLF1NHnUEPAZnWak8c9QnJkyair2WMbujh5GnIpX768UBoGeY2eaokUQHo258tzV7OT0oga MEn5Vz1nf5WDtEMv7sKmJE0SDYAOSNXkPoYOS/8HyhKqeKTM6YKLbOk3C6qnZGyGSLHJP+hZmCxeh Gm0n7ahtbpzHU5M59C9VMDBahZyApnlHrRLG7HQMhNuhGx+4aV4Gzfw1sa9L316fNFc9grkWsIMJv IdHtew2IndwvcTWDAkZA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfQGe-0007eE-3E; Mon, 24 Jun 2019 14:48:24 +0000 Received: from skedge03.snt-world.com ([91.208.41.68]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfQGJ-0007Ns-7E for linux-mtd@lists.infradead.org; Mon, 24 Jun 2019 14:48:06 +0000 Received: from sntmail12r.snt-is.com (unknown [10.203.32.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by skedge03.snt-world.com (Postfix) with ESMTPS id 7D8DA67A90A; Mon, 24 Jun 2019 16:47:51 +0200 (CEST) Received: from sntmail12r.snt-is.com (10.203.32.182) by sntmail12r.snt-is.com (10.203.32.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 24 Jun 2019 16:47:50 +0200 Received: from sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305]) by sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305%3]) with mapi id 15.01.1713.004; Mon, 24 Jun 2019 16:47:50 +0200 From: Schrempf Frieder To: liaoweixiong , Miquel Raynal , Richard Weinberger , "David Woodhouse" , Brian Norris , Marek Vasut , Vignesh Raghavendra , Boris Brezillon , Frieder Schrempf , Peter Pan , "Chuanhong Guo" Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips Thread-Topic: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips Thread-Index: AQHVKoaYbYsysfnJPUKsxvje/QcCeKaqwQIA Date: Mon, 24 Jun 2019 14:47:50 +0000 Message-ID: References: <1561378534-26119-1-git-send-email-liaoweixiong@allwinnertech.com> In-Reply-To: <1561378534-26119-1-git-send-email-liaoweixiong@allwinnertech.com> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.9.193] x-c2processedorg: 51b406b7-48a2-4d03-b652-521f56ac89f3 Content-ID: <9FE31BB9AAE8204BAD101611478CAFA2@snt-world.com> MIME-Version: 1.0 X-SnT-MailScanner-Information: Please contact the ISP for more information X-SnT-MailScanner-ID: 7D8DA67A90A.A00F2 X-SnT-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details X-SnT-MailScanner-SpamCheck: X-SnT-MailScanner-From: frieder.schrempf@kontron.de X-SnT-MailScanner-To: bbrezillon@kernel.org, computersforpeace@gmail.com, dwmw2@infradead.org, frieder.schrempf@exceet.de, gch981213@gmail.com, liaoweixiong@allwinnertech.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, marek.vasut@gmail.com, miquel.raynal@bootlin.com, peterpandong@micron.com, richard@nod.at, stable@vger.kernel.org, vigneshr@ti.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_074803_688912_215CB5B1 X-CRM114-Status: GOOD ( 16.97 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 24.06.19 14:15, liaoweixiong wrote: > In case of the last page containing bitflips (ret > 0), > spinand_mtd_read() will return that number of bitflips for the last > page. But to me it looks like it should instead return max_bitflips like > it does when the last page read returns with 0. > > Signed-off-by: liaoweixiong > Acked-by: Boris Brezillon > Acked-by: Frieder Schrempf Why did you change our Reviewed-by tags to Acked-by tags? > Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") > --- > drivers/mtd/nand/spi/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index 556bfdb..6b9388d 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -511,12 +511,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from, > if (ret == -EBADMSG) { > ecc_failed = true; > mtd->ecc_stats.failed++; > - ret = 0; > } else { > mtd->ecc_stats.corrected += ret; > max_bitflips = max_t(unsigned int, max_bitflips, ret); > } > > + ret = 0; > ops->retlen += iter.req.datalen; > ops->oobretlen += iter.req.ooblen; > } > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/