From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D51C433E0 for ; Thu, 4 Feb 2021 12:36:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7FF764F53 for ; Thu, 4 Feb 2021 12:36:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236068AbhBDMgA (ORCPT ); Thu, 4 Feb 2021 07:36:00 -0500 Received: from foss.arm.com ([217.140.110.172]:57632 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235990AbhBDMf5 (ORCPT ); Thu, 4 Feb 2021 07:35:57 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B58ABD6E; Thu, 4 Feb 2021 04:35:11 -0800 (PST) Received: from [10.37.8.15] (unknown [10.37.8.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B65A63F73B; Thu, 4 Feb 2021 04:35:08 -0800 (PST) Subject: Re: [PATCH 10/12] arm64: kasan: simplify and inline MTE functions To: Andrew Morton , Andrey Konovalov Cc: Catalin Marinas , Dmitry Vyukov , Alexander Potapenko , Marco Elver , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <17d6bef698d193f5fe0d8baee0e232a351e23a32.1612208222.git.andreyknvl@google.com> <20210201144407.dd603ec4edcd589643654057@linux-foundation.org> From: Vincenzo Frascino Message-ID: Date: Thu, 4 Feb 2021 12:39:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210201144407.dd603ec4edcd589643654057@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On 2/1/21 10:44 PM, Andrew Morton wrote: > On Mon, 1 Feb 2021 20:43:34 +0100 Andrey Konovalov wrote: > >> This change provides a simpler implementation of mte_get_mem_tag(), >> mte_get_random_tag(), and mte_set_mem_tag_range(). >> >> Simplifications include removing system_supports_mte() checks as these >> functions are onlye called from KASAN runtime that had already checked >> system_supports_mte(). Besides that, size and address alignment checks >> are removed from mte_set_mem_tag_range(), as KASAN now does those. >> >> This change also moves these functions into the asm/mte-kasan.h header >> and implements mte_set_mem_tag_range() via inline assembly to avoid >> unnecessary functions calls. >> >> Co-developed-by: Vincenzo Frascino >> Signed-off-by: Andrey Konovalov > > Co-developed-by requires a Signed-off-by: as well. Vincenzo, please > send us one? > > I added my Signed-off-by to the patch. -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F33D8C433DB for ; Thu, 4 Feb 2021 12:36:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DCA864DE9 for ; Thu, 4 Feb 2021 12:36:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DCA864DE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QaS9QZCJ3+PFuDCnwIbrfzauar3EP58F6E/XkUYVr/E=; b=L25OhUxs5eeYLHbzAmNPYbT5C APQsl8gSLZ5pYkFPBc1ZbXYw0CQ5zRdzh90yk3myUmmvDYvADolrxhnzNZkYju2CabdPvfJbApY4Z 0T1UYWv8dWaucO1PHc9ohWIt3DmAmK6RaF6aaL6AUjMUpVKSzKLvAUHdImj9Jx5cctyKY1RUGosyg ezQ0esnkk0pkTvLh2nCAzZhOet69AM/Sx+AGIjjkaQYKQpYui5xe3tmJT4TQ/fPWe/BpNxOnd9jzY +cENQo1bKFB46WdsTgdHTtSqUqOlQ/mj/Lq0DrPznDb7Ix/ks25yZcB4rpXE7JiXEkIfrCnkwtTqL yt1yml6Qg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7dqt-0000kF-Pv; Thu, 04 Feb 2021 12:35:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7dqr-0000jD-4L for linux-arm-kernel@lists.infradead.org; Thu, 04 Feb 2021 12:35:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B58ABD6E; Thu, 4 Feb 2021 04:35:11 -0800 (PST) Received: from [10.37.8.15] (unknown [10.37.8.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B65A63F73B; Thu, 4 Feb 2021 04:35:08 -0800 (PST) Subject: Re: [PATCH 10/12] arm64: kasan: simplify and inline MTE functions To: Andrew Morton , Andrey Konovalov References: <17d6bef698d193f5fe0d8baee0e232a351e23a32.1612208222.git.andreyknvl@google.com> <20210201144407.dd603ec4edcd589643654057@linux-foundation.org> From: Vincenzo Frascino Message-ID: Date: Thu, 4 Feb 2021 12:39:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210201144407.dd603ec4edcd589643654057@linux-foundation.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210204_073513_237664_1AA17542 X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Catalin Marinas , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Peter Collingbourne , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, On 2/1/21 10:44 PM, Andrew Morton wrote: > On Mon, 1 Feb 2021 20:43:34 +0100 Andrey Konovalov wrote: > >> This change provides a simpler implementation of mte_get_mem_tag(), >> mte_get_random_tag(), and mte_set_mem_tag_range(). >> >> Simplifications include removing system_supports_mte() checks as these >> functions are onlye called from KASAN runtime that had already checked >> system_supports_mte(). Besides that, size and address alignment checks >> are removed from mte_set_mem_tag_range(), as KASAN now does those. >> >> This change also moves these functions into the asm/mte-kasan.h header >> and implements mte_set_mem_tag_range() via inline assembly to avoid >> unnecessary functions calls. >> >> Co-developed-by: Vincenzo Frascino >> Signed-off-by: Andrey Konovalov > > Co-developed-by requires a Signed-off-by: as well. Vincenzo, please > send us one? > > I added my Signed-off-by to the patch. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel