From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840C2C433B4 for ; Fri, 16 Apr 2021 14:41:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 603F761166 for ; Fri, 16 Apr 2021 14:41:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245252AbhDPOl3 (ORCPT ); Fri, 16 Apr 2021 10:41:29 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:40313 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245223AbhDPOke (ORCPT ); Fri, 16 Apr 2021 10:40:34 -0400 Received: from mail-ej1-f71.google.com ([209.85.218.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lXPdg-0008Ub-HO for linux-kernel@vger.kernel.org; Fri, 16 Apr 2021 14:40:08 +0000 Received: by mail-ej1-f71.google.com with SMTP id ne22-20020a1709077b96b02903803a047edeso771885ejc.3 for ; Fri, 16 Apr 2021 07:40:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GSjWTZ/Z5DNODKF+c0WPTkeFDX79xKYMxkTcm2HoLd4=; b=aaqI+EPIwPxx5J4ODT6DBsUK01ZCL4PBnGOi74cEm85ybMjPDMHdAlDesvwU0vBmbH fnRWA/bmC+NKI4BNU3558H2APvAfJKhPbhgEQZdp0XWJIbNjSxHQXnemsU0jWajiS1hz z9awMRL5gjJU3RHQ4fIvyMQO1ic+A6V88sUb6uLdeKJzFUy+mW0tcnhYRACzdXAXdr7r B0lzU+wgbHT0rGEPMMDnCEmoWtxRXaNSxRimVVtBPUYwYSjgVPG7xkEuP/CSi30v7Fq6 WBmrnDDXuZV5JP928dNBMm0lhddWBmpnquJ6tSiVxEX8wkpChkQm7ikM1fS5rI3y2WYZ 3jZA== X-Gm-Message-State: AOAM531Wwg4YZMkpU87iTOK+mYOEBbkPddRB6/lFwFmJ45cSigh2QFrR WNs6m3sjZUX2MmcKGdEWp8cH2Glq79eagNARV/Og2OXStmz0A3mp94+JDT8jRNSAEUYpvNekcEh f6LkOurMPN0P1WpZbLPNiHUiqTrElA2naBECeuJREDA== X-Received: by 2002:a05:6402:3592:: with SMTP id y18mr10107026edc.360.1618584008186; Fri, 16 Apr 2021 07:40:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqIT1TOvyHKrbuARFcYx9jG1/j3L7k9n1N225zWDszydFHt4CPZHqWrxmI/gzjjqbJS3IMcg== X-Received: by 2002:a05:6402:3592:: with SMTP id y18mr10107011edc.360.1618584008076; Fri, 16 Apr 2021 07:40:08 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id m14sm1832815edc.18.2021.04.16.07.40.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Apr 2021 07:40:07 -0700 (PDT) Subject: Re: [PATCH 34/40] drm/exynos/exynos_drm_fimd: Realign function name with its header To: Lee Jones Cc: linux-kernel@vger.kernel.org, Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20210416143725.2769053-1-lee.jones@linaro.org> <20210416143725.2769053-35-lee.jones@linaro.org> From: Krzysztof Kozlowski Message-ID: Date: Fri, 16 Apr 2021 16:40:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210416143725.2769053-35-lee.jones@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/04/2021 16:37, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/exynos/exynos_drm_fimd.c:734: warning: expecting prototype for shadow_protect_win(). Prototype was for fimd_shadow_protect_win() instead > > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: David Airlie > Cc: Daniel Vetter > Cc: Krzysztof Kozlowski > Cc: dri-devel@lists.freedesktop.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi Lee, I already sent a fix for this one on 5th of April: https://lore.kernel.org/lkml/20210405181524.52426-1-krzysztof.kozlowski@canonical.com/ Best regards, Krzysztof > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 49a2e0c539187..ae576122873e0 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -723,7 +723,7 @@ static void fimd_win_set_colkey(struct fimd_context *ctx, unsigned int win) > } > > /** > - * shadow_protect_win() - disable updating values from shadow registers at vsync > + * fimd_shadow_protect_win() - disable updating values from shadow registers at vsync > * > * @ctx: local driver data > * @win: window to protect registers for > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C24C433ED for ; Fri, 16 Apr 2021 14:42:41 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0245A610CE for ; Fri, 16 Apr 2021 14:42:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0245A610CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iGIkrifehXX2BjAzpOVZP5Xj5CedgyxhzLEQRZHo2B4=; b=Jrq3IGkA31HV0zA6aRxm5Fzlg 9G7voCFtlPkQQwuNFpAPX3FsW0kTpZTdMjJTfjPOR1ilNA0NMmoOLf0qkQ8EYXeOb21ube0fGbnVb /ZpSYDA0kIQbu0Nff0wUoaYTp1Dh8K/DPaI8Wj0NENy+RcJXmXrzvJUVHgujeQaR8bHZ23+kPQM+e j/YhMo5PMe96j/c0IJGOktjmPgDnsVSmxd0Fhbg0utKcdGbaSxDKeGqcUmcB+lXon1fSHsnVtelxr viYF86ldmlkE5fFpO9bwbbMn1NTQD9pSg0RumpbfVxUe73MjPkvwQUn/FbLhS1GjX5ALHGo32qNGH ImdWmsJLg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXPeU-002RhG-8t; Fri, 16 Apr 2021 14:40:58 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXPdq-002RPy-Sg for linux-arm-kernel@desiato.infradead.org; Fri, 16 Apr 2021 14:40:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=GSjWTZ/Z5DNODKF+c0WPTkeFDX79xKYMxkTcm2HoLd4=; b=Dnp+PoPikg14Bug1zAwJOsri+v +Wt5EhR1jU1ChbuC1xi5G5Qjp0SK8XzrG51dkSngrd2DocuLwsd7cF3nUTm5z0evHuAcWXz36xLZ4 qzFeBrOAv+z2ok3ezf2k33dMaMXgz60NreDIJ4vwbI4+DWluq9m9MuZAm9gTMaV7auJKIQYFcCtiJ fH0bx090KlyqS19QaaxVUWko80c0CBYs6Rv98lmOmqY+Sn8pm0ErQ0sXhF1nJIzNLxldQ3NMy3oQL MKRg+5HL+hP+ENR78pb/st45gXeCvxZ7ukV0OwII5Ys0ZcjHfIl1Hwgo6GQ4kePrmZRZUq/CYbS8I mamruzDQ==; Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXPdk-009SfB-ML for linux-arm-kernel@lists.infradead.org; Fri, 16 Apr 2021 14:40:17 +0000 Received: from mail-ej1-f70.google.com ([209.85.218.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lXPdg-0008UV-DK for linux-arm-kernel@lists.infradead.org; Fri, 16 Apr 2021 14:40:08 +0000 Received: by mail-ej1-f70.google.com with SMTP id jl27-20020a17090775dbb029037ccdce96e6so2075296ejc.21 for ; Fri, 16 Apr 2021 07:40:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GSjWTZ/Z5DNODKF+c0WPTkeFDX79xKYMxkTcm2HoLd4=; b=d7GBRwL/xWzzUbJQYWigryztu69Vwi5BWSQwqZ9JQrcVd5uHZeydXJyvqZFDKjeszh OzHSobH2ifEKYgA9pOLj06W0Ek2JCWTAXM1WKEX4Z7XMBY3qzLKyJ0nqLWyBIpmJBaIM 2SvesXDGI8eA7s+K0ggcOB8/1q4wZDzdRIDLlNsx/2ELd3I/Ygr9y0qxIztekMGsxS+u iLjejER5uHUSM/X6Zwi4j4GHWb18yE1Q54HH2509NXorS6I4JuZ5udXomudFY5TH11q2 ytFQq0CLjlYgwZxZvKk/5jDW80wpLUdMH0LjPKODunqP3tqh04VC1TShFDtrXXcMApvf kUMw== X-Gm-Message-State: AOAM530Wad+TvLyS338Cz8hRRyHeBVILkvzHHaKEp4VL/TDzZtGwQzic rQ/otBcIPf9kh4/IgtPCXVlNHQeRNvc7tF07hM8b59Znbqx/c5yiF9Qnyd/klI9PBWXptzuqt2P cJNNjX0aLexgn1Udo2Etp3KnHhj+GkCz5jdDEXpzIDMwUKflmW8/W X-Received: by 2002:a05:6402:3592:: with SMTP id y18mr10107023edc.360.1618584008186; Fri, 16 Apr 2021 07:40:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqIT1TOvyHKrbuARFcYx9jG1/j3L7k9n1N225zWDszydFHt4CPZHqWrxmI/gzjjqbJS3IMcg== X-Received: by 2002:a05:6402:3592:: with SMTP id y18mr10107011edc.360.1618584008076; Fri, 16 Apr 2021 07:40:08 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id m14sm1832815edc.18.2021.04.16.07.40.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Apr 2021 07:40:07 -0700 (PDT) Subject: Re: [PATCH 34/40] drm/exynos/exynos_drm_fimd: Realign function name with its header To: Lee Jones Cc: linux-kernel@vger.kernel.org, Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20210416143725.2769053-1-lee.jones@linaro.org> <20210416143725.2769053-35-lee.jones@linaro.org> From: Krzysztof Kozlowski Message-ID: Date: Fri, 16 Apr 2021 16:40:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210416143725.2769053-35-lee.jones@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_074012_892478_7A3B974C X-CRM114-Status: GOOD ( 19.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/04/2021 16:37, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/exynos/exynos_drm_fimd.c:734: warning: expecting prototype for shadow_protect_win(). Prototype was for fimd_shadow_protect_win() instead > > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: David Airlie > Cc: Daniel Vetter > Cc: Krzysztof Kozlowski > Cc: dri-devel@lists.freedesktop.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi Lee, I already sent a fix for this one on 5th of April: https://lore.kernel.org/lkml/20210405181524.52426-1-krzysztof.kozlowski@canonical.com/ Best regards, Krzysztof > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 49a2e0c539187..ae576122873e0 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -723,7 +723,7 @@ static void fimd_win_set_colkey(struct fimd_context *ctx, unsigned int win) > } > > /** > - * shadow_protect_win() - disable updating values from shadow registers at vsync > + * fimd_shadow_protect_win() - disable updating values from shadow registers at vsync > * > * @ctx: local driver data > * @win: window to protect registers for > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEEC4C43461 for ; Fri, 16 Apr 2021 14:40:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 792156113D for ; Fri, 16 Apr 2021 14:40:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 792156113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CA1326EC18; Fri, 16 Apr 2021 14:40:10 +0000 (UTC) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D16C6EC18 for ; Fri, 16 Apr 2021 14:40:10 +0000 (UTC) Received: from mail-ej1-f72.google.com ([209.85.218.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lXPdg-0008Uh-M4 for dri-devel@lists.freedesktop.org; Fri, 16 Apr 2021 14:40:08 +0000 Received: by mail-ej1-f72.google.com with SMTP id p25-20020a1709061419b0290378364a6464so2083133ejc.15 for ; Fri, 16 Apr 2021 07:40:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GSjWTZ/Z5DNODKF+c0WPTkeFDX79xKYMxkTcm2HoLd4=; b=L6gs0DwEx6qXu/S3A7IAIct4becAHcalZyNzzeuIP2o5ucoFb4/UUvz4+tItDp/iNC 8M7o0GZ1d0GzGnrf/0gc6pqR9tgksUJQRsdK+XfXuMq/Pq2B2QV55cnho+vjZZccxefZ VUav4l95HbEJYiCqHyKcxziUaUDVA1ouiHTN32l4IiQlaXdV6k+mphZtpN94F3Kc59zX N+kqCJ3+2xiivOsN1x3NBV0H30AFIuFvFaSNb7vTmWeW2v8r7uwRWUMTR5/ylI93il+U tkxJUvvaKRV416Z6eFsWu0iS95VyZnZjIJWIONzEOgUkZIxB5IbWigGnTh4q/lNy6Hmj eMiQ== X-Gm-Message-State: AOAM530RBOd314nCit3cvHahZ+FTTHHDbPY0tDqe2e+y6ardufETdE8i LoylGZ7mhic08r60FK9NlH3scG48NIFDuGXMFfjtNPBtAL42f9VRngceOCKsgGzf3DHWvYzj+Gq AYmxyiG8WIOxWu1llcDtAcmGlkg37lvimRwLh8FGJxKjYCA== X-Received: by 2002:a05:6402:3592:: with SMTP id y18mr10107028edc.360.1618584008186; Fri, 16 Apr 2021 07:40:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqIT1TOvyHKrbuARFcYx9jG1/j3L7k9n1N225zWDszydFHt4CPZHqWrxmI/gzjjqbJS3IMcg== X-Received: by 2002:a05:6402:3592:: with SMTP id y18mr10107011edc.360.1618584008076; Fri, 16 Apr 2021 07:40:08 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id m14sm1832815edc.18.2021.04.16.07.40.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Apr 2021 07:40:07 -0700 (PDT) Subject: Re: [PATCH 34/40] drm/exynos/exynos_drm_fimd: Realign function name with its header To: Lee Jones References: <20210416143725.2769053-1-lee.jones@linaro.org> <20210416143725.2769053-35-lee.jones@linaro.org> From: Krzysztof Kozlowski Message-ID: Date: Fri, 16 Apr 2021 16:40:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210416143725.2769053-35-lee.jones@linaro.org> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Joonyoung Shim , David Airlie , Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 16/04/2021 16:37, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/exynos/exynos_drm_fimd.c:734: warning: expecting prototype for shadow_protect_win(). Prototype was for fimd_shadow_protect_win() instead > > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: David Airlie > Cc: Daniel Vetter > Cc: Krzysztof Kozlowski > Cc: dri-devel@lists.freedesktop.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi Lee, I already sent a fix for this one on 5th of April: https://lore.kernel.org/lkml/20210405181524.52426-1-krzysztof.kozlowski@canonical.com/ Best regards, Krzysztof > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 49a2e0c539187..ae576122873e0 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -723,7 +723,7 @@ static void fimd_win_set_colkey(struct fimd_context *ctx, unsigned int win) > } > > /** > - * shadow_protect_win() - disable updating values from shadow registers at vsync > + * fimd_shadow_protect_win() - disable updating values from shadow registers at vsync > * > * @ctx: local driver data > * @win: window to protect registers for > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel