From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?WGlhb3RvbmcgTHUgKOWNouWwj+mAmik=?= Subject: RE: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver Date: Sat, 5 May 2018 06:04:28 +0000 Message-ID: References: <1bf5bc3e007d237477d740f47ed63f05aa71b348.1525427961.git.baolin.wang@linaro.org> <201805051300.jy5SNVta%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <201805051300.jy5SNVta%fengguang.wu@intel.com> Content-Language: zh-CN Sender: linux-kernel-owner@vger.kernel.org To: kbuild test robot Cc: "kbuild-all@01.org" , "jacek.anaszewski@gmail.com" , "pavel@ucw.cz" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "baolin.wang@linaro.org" , "broonie@kernel.org" , "linux-leds@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-leds@vger.kernel.org SGkgbGtwLA0KVGhhbmtzIGZvciB5b3VyIGFkdmlzZS4gSSB3aWxsIGltcHJvdmUgaW4gbmV4dCB2 ZXJzaW9uLg0KDQpCZXN0IFJlZ2FyZHMsDQrljaLlsI/pgJogWGlhb3RvbmcgTHUNCkNQU0QgRGVw dC4NClVuaWdyb3VwIFNwcmVhZHRydW0gJlJEQSBUZWNobm9sb2dpZXMgQ28uLEx0ZC4NClRlbDrC oCA4Ni0yMS0yMDM2MDYwMCBFeHQuIDI0OTYNCkZheDogODYtMjEtMjAzNjA3MDANCkUtbWFpbDog eGlhb3RvbmcubHVAdW5pc29jLmNvbQ0KSHR0cDovL3d3dy5zcHJlYWR0cnVtLmNvbSANCg0KDQot LS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbToga2J1aWxkIHRlc3Qgcm9ib3QgW21haWx0 bzpsa3BAaW50ZWwuY29tXSANClNlbnQ6IFNhdHVyZGF5LCBNYXkgMDUsIDIwMTggMToyNyBQTQ0K VG86IEJhb2xpbiBXYW5nDQpDYzoga2J1aWxkLWFsbEAwMS5vcmc7IGphY2VrLmFuYXN6ZXdza2lA Z21haWwuY29tOyBwYXZlbEB1Y3cuY3o7IHJvYmgrZHRAa2VybmVsLm9yZzsgbWFyay5ydXRsYW5k QGFybS5jb207IFhpYW90b25nIEx1ICjljaLlsI/pgJopOyBiYW9saW4ud2FuZ0BsaW5hcm8ub3Jn OyBicm9vbmllQGtlcm5lbC5vcmc7IGxpbnV4LWxlZHNAdmdlci5rZXJuZWwub3JnOyBkZXZpY2V0 cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZw0KU3ViamVj dDogUmU6IFtQQVRDSCAyLzJdIGxlZHM6IEFkZCBTcHJlYWR0cnVtIFNDMjd4eCBicmVhdGhpbmcg bGlnaHQgY29udHJvbGxlciBkcml2ZXINCg0KSGkgWGlhb3RvbmcsDQoNClRoYW5rIHlvdSBmb3Ig dGhlIHBhdGNoISBQZXJoYXBzIHNvbWV0aGluZyB0byBpbXByb3ZlOg0KDQpbYXV0byBidWlsZCB0 ZXN0IFdBUk5JTkcgb24gcm9iaC9mb3ItbmV4dF0gW2Fsc28gYnVpbGQgdGVzdCBXQVJOSU5HIG9u IHY0LjE3LXJjMyBuZXh0LTIwMTgwNTA0XSBbY2Fubm90IGFwcGx5IHRvIGouYW5hc3pld3NraS1s ZWRzL2Zvci1uZXh0XSBbaWYgeW91ciBwYXRjaCBpcyBhcHBsaWVkIHRvIHRoZSB3cm9uZyBnaXQg dHJlZSwgcGxlYXNlIGRyb3AgdXMgYSBub3RlIHRvIGhlbHAgaW1wcm92ZSB0aGUgc3lzdGVtXQ0K DQp1cmw6ICAgIGh0dHBzOi8vZ2l0aHViLmNvbS8wZGF5LWNpL2xpbnV4L2NvbW1pdHMvQmFvbGlu LVdhbmcvZHQtYmluZGluZ3MtbGVkcy1BZGQtU0MyN3h4LWJyZWF0aGluZy1saWdodC1jb250cm9s bGVyLWRvY3VtZW50YXRpb24vMjAxODA1MDQtMjAwODMwDQpiYXNlOiAgIGh0dHBzOi8vZ2l0Lmtl cm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3JvYmgvbGludXguZ2l0IGZvci1uZXh0 DQoNCnNtYXRjaCB3YXJuaW5nczoNCmRyaXZlcnMvbGVkcy9sZWRzLXNjMjd4eC1ibHRjLmM6MzM3 IHNjMjd4eF9sZWRfcHJvYmUoKSB3YXJuOiB1bnNpZ25lZCAncmVnJyBpcyBuZXZlciBsZXNzIHRo YW4gemVyby4NCg0KdmltICsvcmVnICszMzcgZHJpdmVycy9sZWRzL2xlZHMtc2MyN3h4LWJsdGMu Yw0KDQogICAyOTkJDQogICAzMDAJc3RhdGljIGludCBzYzI3eHhfbGVkX3Byb2JlKHN0cnVjdCBw bGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQogICAzMDEJew0KICAgMzAyCQlzdHJ1Y3QgZGV2aWNlICpk ZXYgPSAmcGRldi0+ZGV2Ow0KICAgMzAzCQlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wID0gZGV2LT5v Zl9ub2RlLCAqY2hpbGQ7DQogICAzMDQJCXN0cnVjdCBzYzI3eHhfbGVkX3ByaXYgKnByaXY7DQog ICAzMDUJCXUzMiBiYXNlLCBjb3VudCwgcmVnOw0KICAgMzA2CQlpbnQgZXJyOw0KICAgMzA3CQ0K ICAgMzA4CQljb3VudCA9IG9mX2dldF9jaGlsZF9jb3VudChucCk7DQogICAzMDkJCWlmICghY291 bnQgfHwgY291bnQgPiBTQzI3WFhfTEVEU19NQVgpDQogICAzMTAJCQlyZXR1cm4gLUVJTlZBTDsN CiAgIDMxMQkNCiAgIDMxMgkJZXJyID0gb2ZfcHJvcGVydHlfcmVhZF91MzIobnAsICJyZWciLCAm YmFzZSk7DQogICAzMTMJCWlmIChlcnIpIHsNCiAgIDMxNAkJCWRldl9lcnIoZGV2LCAiZmFpbCB0 byBnZXQgcmVnIG9mIHByb3BlcnR5XG4iKTsNCiAgIDMxNQkJCXJldHVybiBlcnI7DQogICAzMTYJ CX0NCiAgIDMxNwkNCiAgIDMxOAkJcHJpdiA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqcHJp diksIEdGUF9LRVJORUwpOw0KICAgMzE5CQlpZiAoIXByaXYpDQogICAzMjAJCQlyZXR1cm4gLUVO T01FTTsNCiAgIDMyMQkNCiAgIDMyMgkJcHJpdi0+YmFzZSA9IGJhc2U7DQogICAzMjMJCXByaXYt PnJlZ21hcCA9IGRldl9nZXRfcmVnbWFwKGRldi0+cGFyZW50LCBOVUxMKTsNCiAgIDMyNAkJaWYg KElTX0VSUihwcml2LT5yZWdtYXApKSB7DQogICAzMjUJCQllcnIgPSBQVFJfRVJSKHByaXYtPnJl Z21hcCk7DQogICAzMjYJCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBnZXQgcmVnbWFwOiAlZFxu IiwgZXJyKTsNCiAgIDMyNwkJCXJldHVybiBlcnI7DQogICAzMjgJCX0NCiAgIDMyOQkNCiAgIDMz MAkJZm9yX2VhY2hfY2hpbGRfb2Zfbm9kZShucCwgY2hpbGQpIHsNCiAgIDMzMQkJCWVyciA9IG9m X3Byb3BlcnR5X3JlYWRfdTMyKGNoaWxkLCAicmVnIiwgJnJlZyk7DQogICAzMzIJCQlpZiAoZXJy KSB7DQogICAzMzMJCQkJb2Zfbm9kZV9wdXQoY2hpbGQpOw0KICAgMzM0CQkJCXJldHVybiBlcnI7 DQogICAzMzUJCQl9DQogICAzMzYJDQogPiAzMzcJCQlpZiAocmVnIDwgMCB8fCByZWcgPj0gU0My N1hYX0xFRFNfTUFYDQogICAzMzgJCQkgICAgfHwgcHJpdi0+bGVkc1tyZWddLmFjdGl2ZSkgew0K ICAgMzM5CQkJCW9mX25vZGVfcHV0KGNoaWxkKTsNCiAgIDM0MAkJCQlyZXR1cm4gLUVJTlZBTDsN CiAgIDM0MQkJCX0NCiAgIDM0MgkNCiAgIDM0MwkJCXByaXYtPmxlZHNbcmVnXS5hY3RpdmUgPSB0 cnVlOw0KICAgMzQ0CQkJcHJpdi0+bGVkc1tyZWddLmxkZXYubmFtZSA9DQogICAzNDUJCQkJb2Zf Z2V0X3Byb3BlcnR5KGNoaWxkLCAibGFiZWwiLCBOVUxMKSA/IDogY2hpbGQtPm5hbWU7DQogICAz NDYJCX0NCiAgIDM0NwkNCiAgIDM0OAkJcmV0dXJuIHNjMjd4eF9sZWRfcmVnaXN0ZXIoZGV2LCBw cml2KTsNCiAgIDM0OQl9DQogICAzNTAJDQoNCi0tLQ0KMC1EQVkga2VybmVsIHRlc3QgaW5mcmFz dHJ1Y3R1cmUgICAgICAgICAgICAgICAgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXINCmh0 dHBzOi8vbGlzdHMuMDEub3JnL3BpcGVybWFpbC9rYnVpbGQtYWxsICAgICAgICAgICAgICAgICAg IEludGVsIENvcnBvcmF0aW9uDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751839AbeEEHQn (ORCPT ); Sat, 5 May 2018 03:16:43 -0400 Received: from sci-ig2.spreadtrum.com ([222.66.158.135]:57120 "EHLO SHSQR01.unisoc.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751508AbeEEHQj (ORCPT ); Sat, 5 May 2018 03:16:39 -0400 From: =?utf-8?B?WGlhb3RvbmcgTHUgKOWNouWwj+mAmik=?= To: kbuild test robot , Baolin Wang CC: "kbuild-all@01.org" , "jacek.anaszewski@gmail.com" , "pavel@ucw.cz" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "baolin.wang@linaro.org" , "broonie@kernel.org" , "linux-leds@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver Thread-Topic: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver Thread-Index: AQHT45A6o0mwesjvskOs7gJNr+krdKQgFhAAgACQEvA= Date: Sat, 5 May 2018 06:04:28 +0000 Message-ID: References: <1bf5bc3e007d237477d740f47ed63f05aa71b348.1525427961.git.baolin.wang@linaro.org> <201805051300.jy5SNVta%fengguang.wu@intel.com> In-Reply-To: <201805051300.jy5SNVta%fengguang.wu@intel.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.0.1.200] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-MAIL: SHSQR01.spreadtrum.com w45648VL032585 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w457Gmgf020138 Hi lkp, Thanks for your advise. I will improve in next version. Best Regards, 卢小通 Xiaotong Lu CPSD Dept. Unigroup Spreadtrum &RDA Technologies Co.,Ltd. Tel:  86-21-20360600 Ext. 2496 Fax: 86-21-20360700 E-mail: xiaotong.lu@unisoc.com Http://www.spreadtrum.com -----Original Message----- From: kbuild test robot [mailto:lkp@intel.com] Sent: Saturday, May 05, 2018 1:27 PM To: Baolin Wang Cc: kbuild-all@01.org; jacek.anaszewski@gmail.com; pavel@ucw.cz; robh+dt@kernel.org; mark.rutland@arm.com; Xiaotong Lu (卢小通); baolin.wang@linaro.org; broonie@kernel.org; linux-leds@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver Hi Xiaotong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on v4.17-rc3 next-20180504] [cannot apply to j.anaszewski-leds/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Baolin-Wang/dt-bindings-leds-Add-SC27xx-breathing-light-controller-documentation/20180504-200830 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next smatch warnings: drivers/leds/leds-sc27xx-bltc.c:337 sc27xx_led_probe() warn: unsigned 'reg' is never less than zero. vim +/reg +337 drivers/leds/leds-sc27xx-bltc.c 299 300 static int sc27xx_led_probe(struct platform_device *pdev) 301 { 302 struct device *dev = &pdev->dev; 303 struct device_node *np = dev->of_node, *child; 304 struct sc27xx_led_priv *priv; 305 u32 base, count, reg; 306 int err; 307 308 count = of_get_child_count(np); 309 if (!count || count > SC27XX_LEDS_MAX) 310 return -EINVAL; 311 312 err = of_property_read_u32(np, "reg", &base); 313 if (err) { 314 dev_err(dev, "fail to get reg of property\n"); 315 return err; 316 } 317 318 priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); 319 if (!priv) 320 return -ENOMEM; 321 322 priv->base = base; 323 priv->regmap = dev_get_regmap(dev->parent, NULL); 324 if (IS_ERR(priv->regmap)) { 325 err = PTR_ERR(priv->regmap); 326 dev_err(dev, "failed to get regmap: %d\n", err); 327 return err; 328 } 329 330 for_each_child_of_node(np, child) { 331 err = of_property_read_u32(child, "reg", ®); 332 if (err) { 333 of_node_put(child); 334 return err; 335 } 336 > 337 if (reg < 0 || reg >= SC27XX_LEDS_MAX 338 || priv->leds[reg].active) { 339 of_node_put(child); 340 return -EINVAL; 341 } 342 343 priv->leds[reg].active = true; 344 priv->leds[reg].ldev.name = 345 of_get_property(child, "label", NULL) ? : child->name; 346 } 347 348 return sc27xx_led_register(dev, priv); 349 } 350 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation