From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Fabiano Rosas <farosas@suse.de>,
Juan Quintela <quintela@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
qemu-arm@nongnu.org
Subject: Re: [PATCH v3 00/11] tests/qtest: Allow running boot-serial / migration with TCG disabled
Date: Fri, 20 Jan 2023 12:09:26 +0100 [thread overview]
Message-ID: <f876042f-6b6c-4c5f-7f90-3bd76ad7b6e9@linaro.org> (raw)
In-Reply-To: <718784c3-43c5-b621-d5a0-a8aafa492a6e@redhat.com>
On 20/1/23 10:18, Thomas Huth wrote:
> On 20/01/2023 09.23, Philippe Mathieu-Daudé wrote:
>> Missing review: #7
>>
>> Two test were failing on Darwin when testing Fabiano's series
>> which allows building ARM targets without TCG accelerator:
>> https://lore.kernel.org/qemu-devel/20230118193518.26433-1-farosas@suse.de/
>>
>> These patches allow boot-serial / migration tests to run without
>> TCG / KVM.
>
> I just started reviewing while you were sending v3 ... please see my
> mails in reply to v2 for some comments.
Sure.
> Also, I don't quite understand why this is necessary. If you specify
> both, "-accel kvm -accel tcg" on the command line, QEMU should simply
> fall back to the second accelerator if the first one is not available?
> What's exactly the problem you are trying to solve here?
When testing Fabiano's series two tests hang, i.e. [*]:
18/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/boot-serial-test
qemu-system-aarch64: -accel tcg: invalid accelerator tcg
Maybe it is just a matter of adding HVF to the test? I'll see
when I switch back to that. Anyhow the "invalid accelerator"
warning is annoying noise when looking for real problems in the
output.
[*]
https://lore.kernel.org/qemu-devel/ab32e4db-2a6d-69f8-4b69-62a1f1c0f6ba@linaro.org/
prev parent reply other threads:[~2023-01-20 11:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 8:23 [PATCH v3 00/11] tests/qtest: Allow running boot-serial / migration with TCG disabled Philippe Mathieu-Daudé
2023-01-20 8:23 ` [PATCH v3 01/11] tests/qtest/boot-serial-test: Constify tests[] array Philippe Mathieu-Daudé
2023-01-20 8:23 ` [PATCH v3 02/11] tests/qtest/boot-serial-test: Simplify test_machine() a bit Philippe Mathieu-Daudé
2023-01-20 8:23 ` [PATCH v3 03/11] tests/qtest/boot-serial-test: Build command line using GString API Philippe Mathieu-Daudé
2023-01-20 8:23 ` [PATCH v3 04/11] tests/qtest/boot-serial-test: Only use available accelerators Philippe Mathieu-Daudé
2023-01-20 8:23 ` [PATCH v3 05/11] tests/qtest/migration-test: Inverse #ifdef'ry ladders Philippe Mathieu-Daudé
2023-01-30 4:43 ` Juan Quintela
2023-01-20 8:23 ` [PATCH v3 06/11] tests/qtest/migration-test: Reduce 'cmd_source' string scope Philippe Mathieu-Daudé
2023-01-30 4:44 ` Juan Quintela
2023-01-31 14:23 ` Thomas Huth
2023-02-01 13:07 ` Juan Quintela
2023-01-20 8:23 ` [PATCH v3 07/11] tests/qtest/migration-test: Build command line using GString API (1/4) Philippe Mathieu-Daudé
2023-01-23 10:57 ` Dr. David Alan Gilbert
2023-01-30 4:45 ` Juan Quintela
2023-01-20 8:23 ` [PATCH v3 08/11] tests/qtest/migration-test: Build command line using GString API (2/4) Philippe Mathieu-Daudé
2023-01-30 4:46 ` Juan Quintela
2023-01-20 8:23 ` [PATCH v3 09/11] tests/qtest/migration-test: Build command line using GString API (3/4) Philippe Mathieu-Daudé
2023-01-23 10:59 ` Dr. David Alan Gilbert
2023-01-30 4:47 ` Juan Quintela
2023-01-20 8:23 ` [PATCH v3 10/11] tests/qtest/migration-test: Build command line using GString API (4/4) Philippe Mathieu-Daudé
2023-01-30 4:48 ` Juan Quintela
2023-01-20 8:23 ` [PATCH v3 11/11] tests/qtest/migration-test: Only use available accelerators Philippe Mathieu-Daudé
2023-01-30 4:49 ` Juan Quintela
2023-01-20 9:18 ` [PATCH v3 00/11] tests/qtest: Allow running boot-serial / migration with TCG disabled Thomas Huth
2023-01-20 11:09 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f876042f-6b6c-4c5f-7f90-3bd76ad7b6e9@linaro.org \
--to=philmd@linaro.org \
--cc=dgilbert@redhat.com \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.