From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 696C1C4361B for ; Sun, 6 Dec 2020 10:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32F422310B for ; Sun, 6 Dec 2020 10:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726623AbgLFK5u (ORCPT ); Sun, 6 Dec 2020 05:57:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:40067 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbgLFK5t (ORCPT ); Sun, 6 Dec 2020 05:57:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607252183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zb05xp01BEyQm5LEh62oLhnL6kPgxUW55TugbE4oo4M=; b=OIzdyX3pM6H9Xey4luTP2WCVUDsv7QeNSp2Wz17G6BZcBYq/pzLgF0rJFWN5nmlsqhQF17 Bu0KLcrgzddPfSn4if0xK5AdehrziCyusGS/HPtxnlAyRno4yblBMWKyzcnq/kCVn3uaa6 ZKjc7aoW+38Igr6Udjuap3WtSZTlLbk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-332-TdiRe3hJMQeUegLYyCSYZA-1; Sun, 06 Dec 2020 05:56:21 -0500 X-MC-Unique: TdiRe3hJMQeUegLYyCSYZA-1 Received: by mail-wm1-f72.google.com with SMTP id r5so4058077wma.2 for ; Sun, 06 Dec 2020 02:56:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zb05xp01BEyQm5LEh62oLhnL6kPgxUW55TugbE4oo4M=; b=ZvX6nKk9X0UPe0xHu6hVWy/M5M/UtgNuwfhQJ5vCu7bV7pkSDFWmC1pC2f4PDPaSe3 73ud3YdVeeUaCK9mrM0AszPv44bI4Q/PR7E6qK0I7zeuKH4bfSCsBG46l++4xcYX/RX6 bRM/DEw0DndXrS+RJNNyEBrVTa75q+Mk9686GdtJJJDRitG78LlFwB8emyFh4PRxhKW1 un9U6fn5iaUKgAmYW7sc2Sse4S4QOqE1HHN3m5TrDJSgFP6TWiUJdQgLIj3pFM2ZhF9G fZ5Ao3A4SfcFYr16wJuyiqPwhAHEJZs/BZyXYwiQ6NsZRvM1wIyKyayH7f9WdrcyC/qg y2JQ== X-Gm-Message-State: AOAM533lUW0QevYQ5gJUQN1+42PXyZNApbr3Z24LzGPpaDHIRAXarG9N gqdyqFPsavMel+NnwEi45DZW3hO3DIiYveqdExJ9fDuR2xOK/E/kTUvGWXiGE3FGxniIQgPrWB8 XqrVtxoZhjiTm X-Received: by 2002:a7b:cf37:: with SMTP id m23mr12991479wmg.37.1607252180121; Sun, 06 Dec 2020 02:56:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyGX3cca6nPagY2g70Cl2YOoYgsl0EaRP4WwTL7DXdmVUAvbBY8Gmu27mN+p01TBovcAihFAA== X-Received: by 2002:a7b:cf37:: with SMTP id m23mr12991464wmg.37.1607252179933; Sun, 06 Dec 2020 02:56:19 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id w17sm10634246wru.82.2020.12.06.02.56.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Dec 2020 02:56:18 -0800 (PST) Subject: Re: [GIT PULL] KVM/arm64 fixes for 5.10, take #5 To: Marc Zyngier Cc: Keqian Zhu , Will Deacon , Yanan Wang , kernel-team@android.com, James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20201204181914.783445-1-maz@kernel.org> From: Paolo Bonzini Message-ID: Date: Sun, 6 Dec 2020 11:56:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201204181914.783445-1-maz@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 04/12/20 19:19, Marc Zyngier wrote: > Hi Paolo, > > A week ago, I was hoping being done with the 5.10 fixes. I should > obviously know better. > > Thanks to Yanan's excellent work, we have another set of page table > fixes, all plugging issues introduced with our new page table code. > The problems range from memory leak to TLB conflicts, all of which are > serious enough to be squashed right away. > > Are we done yet? Fingers crossed. Pulled, thanks. I am not sure I'll get my own pull request to Linus today, though. Paolo > Please pull, > > M. > > The following changes since commit 23bde34771f1ea92fb5e6682c0d8c04304d34b3b: > > KVM: arm64: vgic-v3: Drop the reporting of GICR_TYPER.Last for userspace (2020-11-17 18:51:09 +0000) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git tags/kvmarm-fixes-5.10-5 > > for you to fetch changes up to 7d894834a305568a0168c55d4729216f5f8cb4e6: > > KVM: arm64: Add usage of stage 2 fault lookup level in user_mem_abort() (2020-12-02 09:53:29 +0000) > > ---------------------------------------------------------------- > kvm/arm64 fixes for 5.10, take #5 > > - Don't leak page tables on PTE update > - Correctly invalidate TLBs on table to block transition > - Only update permissions if the fault level matches the > expected mapping size > > ---------------------------------------------------------------- > Yanan Wang (3): > KVM: arm64: Fix memory leak on stage2 update of a valid PTE > KVM: arm64: Fix handling of merging tables into a block entry > KVM: arm64: Add usage of stage 2 fault lookup level in user_mem_abort() > > arch/arm64/include/asm/esr.h | 1 + > arch/arm64/include/asm/kvm_emulate.h | 5 +++++ > arch/arm64/kvm/hyp/pgtable.c | 17 ++++++++++++++++- > arch/arm64/kvm/mmu.c | 11 +++++++++-- > 4 files changed, 31 insertions(+), 3 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C3DC433FE for ; Sun, 6 Dec 2020 10:56:31 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 8761F22D2C for ; Sun, 6 Dec 2020 10:56:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8761F22D2C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E9A024B1B5; Sun, 6 Dec 2020 05:56:29 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pPBqDVp+ds-g; Sun, 6 Dec 2020 05:56:28 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E3E2E4B1D7; Sun, 6 Dec 2020 05:56:28 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2A60C4B1AF for ; Sun, 6 Dec 2020 05:56:27 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OEZAqRTFj171 for ; Sun, 6 Dec 2020 05:56:25 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 511B04B150 for ; Sun, 6 Dec 2020 05:56:25 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607252185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zb05xp01BEyQm5LEh62oLhnL6kPgxUW55TugbE4oo4M=; b=Ktt6kk5NrOvCO8vcK7SSxx3aE5umzFoOgtKNVDWTazxiBV20+540r9E6yywj2ru7tZYryP C2TB2POScsNJrsmgSqD99HO5REL9EmrYebmM26kESg3paQOBNpp8D+RalfKnuoaGWFHJaT AkGXWzGpbytCDvONoAtpDGUwqlnnkeE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-WT2hq-FCPQalaqLeIAzdlw-1; Sun, 06 Dec 2020 05:56:21 -0500 X-MC-Unique: WT2hq-FCPQalaqLeIAzdlw-1 Received: by mail-wr1-f69.google.com with SMTP id p18so4118254wro.9 for ; Sun, 06 Dec 2020 02:56:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zb05xp01BEyQm5LEh62oLhnL6kPgxUW55TugbE4oo4M=; b=PPwizT4aZYZ0wFhHYicrKF5tGxskB5DfX5vMe3SHm3yZkOYCMBhtgZ5hR4FCnbNxu1 2VwMPvksivFFKeuNXecT5dnWv2XmA3YwWNYm0VTpZvu8PI+gpDHJUMSnwlo4VbruR2p6 pB1Gm4qppEEZtXOUJHNAX4iSAb0Afs+++6sgPL65w7iGw4P3vLludbvy95cMGeXqlFia yBWWW1qgXiDau5vjBZnnkjtNJNrxP542AGIrq2zXwki3EUPVuefLX/TPBRJpVdhKGyut QcpiORS+Qp6ZwdNNEm6iKavLNcq+TJRoECpGP/XpI13P430UWGsLh0f3DdYSPHmvOB4V +tuA== X-Gm-Message-State: AOAM532vSB7OKKP/N4hWRmTZQZSWtPcy8wbeigPYPO9mAnXD1zT/uQgK nq4vVs4j5H1kjKlHXPmaJmtOTA2/6erP3gqrdY5R2vCFxffuFEoe8qEHWZrKyhhP06peWOw9uwo VpB6WNj2jVJWCQFqWGrK/pRk4 X-Received: by 2002:a7b:cf37:: with SMTP id m23mr12991482wmg.37.1607252180121; Sun, 06 Dec 2020 02:56:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyGX3cca6nPagY2g70Cl2YOoYgsl0EaRP4WwTL7DXdmVUAvbBY8Gmu27mN+p01TBovcAihFAA== X-Received: by 2002:a7b:cf37:: with SMTP id m23mr12991464wmg.37.1607252179933; Sun, 06 Dec 2020 02:56:19 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id w17sm10634246wru.82.2020.12.06.02.56.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Dec 2020 02:56:18 -0800 (PST) Subject: Re: [GIT PULL] KVM/arm64 fixes for 5.10, take #5 To: Marc Zyngier References: <20201204181914.783445-1-maz@kernel.org> From: Paolo Bonzini Message-ID: Date: Sun, 6 Dec 2020 11:56:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201204181914.783445-1-maz@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: kvm@vger.kernel.org, kernel-team@android.com, Yanan Wang , linux-arm-kernel@lists.infradead.org, Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 04/12/20 19:19, Marc Zyngier wrote: > Hi Paolo, > > A week ago, I was hoping being done with the 5.10 fixes. I should > obviously know better. > > Thanks to Yanan's excellent work, we have another set of page table > fixes, all plugging issues introduced with our new page table code. > The problems range from memory leak to TLB conflicts, all of which are > serious enough to be squashed right away. > > Are we done yet? Fingers crossed. Pulled, thanks. I am not sure I'll get my own pull request to Linus today, though. Paolo > Please pull, > > M. > > The following changes since commit 23bde34771f1ea92fb5e6682c0d8c04304d34b3b: > > KVM: arm64: vgic-v3: Drop the reporting of GICR_TYPER.Last for userspace (2020-11-17 18:51:09 +0000) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git tags/kvmarm-fixes-5.10-5 > > for you to fetch changes up to 7d894834a305568a0168c55d4729216f5f8cb4e6: > > KVM: arm64: Add usage of stage 2 fault lookup level in user_mem_abort() (2020-12-02 09:53:29 +0000) > > ---------------------------------------------------------------- > kvm/arm64 fixes for 5.10, take #5 > > - Don't leak page tables on PTE update > - Correctly invalidate TLBs on table to block transition > - Only update permissions if the fault level matches the > expected mapping size > > ---------------------------------------------------------------- > Yanan Wang (3): > KVM: arm64: Fix memory leak on stage2 update of a valid PTE > KVM: arm64: Fix handling of merging tables into a block entry > KVM: arm64: Add usage of stage 2 fault lookup level in user_mem_abort() > > arch/arm64/include/asm/esr.h | 1 + > arch/arm64/include/asm/kvm_emulate.h | 5 +++++ > arch/arm64/kvm/hyp/pgtable.c | 17 ++++++++++++++++- > arch/arm64/kvm/mmu.c | 11 +++++++++-- > 4 files changed, 31 insertions(+), 3 deletions(-) > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE69C4361B for ; Sun, 6 Dec 2020 10:58:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B23122D2C for ; Sun, 6 Dec 2020 10:58:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B23122D2C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r7cgpTW8LIN006r3UnEXPbZArvdpG6AdRTPa5G1iypQ=; b=xRshe94gO3jf/7FX7BlMMJ/jT 5i29hTYTY1DCL7Ab+UD+o6kJYOHXQ9XsK+k7FG4Xe5d26g+0YdCzxCyvv64iWzVCXpicYJdCYt2h1 F7i1bBrpARA5KwK0CFCd5JMAUfzapyrh6p76CaeQ8CYxN+5y0UnGnnGK/heOzpBHq50/pTHBtR9Hw Iv7VX3M2QrUDpE/4zR5p3P49TqimuUWqna3SKKpqybuFJ8t6+LzoAxG4S3NzH6RGL9wWkW+/j8CjT IKKWgv7ZzmWLa52utGzxh6bL8I8T2GJVX0W93cXyL15YtwqtDVlDDPpfnxAiVEXfP9M915fO39BUU 7uNZn2iVg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klriP-0004RS-Aq; Sun, 06 Dec 2020 10:56:29 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klriM-0004Qy-Kj for linux-arm-kernel@lists.infradead.org; Sun, 06 Dec 2020 10:56:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607252183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zb05xp01BEyQm5LEh62oLhnL6kPgxUW55TugbE4oo4M=; b=OIzdyX3pM6H9Xey4luTP2WCVUDsv7QeNSp2Wz17G6BZcBYq/pzLgF0rJFWN5nmlsqhQF17 Bu0KLcrgzddPfSn4if0xK5AdehrziCyusGS/HPtxnlAyRno4yblBMWKyzcnq/kCVn3uaa6 ZKjc7aoW+38Igr6Udjuap3WtSZTlLbk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-268-qx_Yq_jcM4u1DbNvUjzc0Q-1; Sun, 06 Dec 2020 05:56:21 -0500 X-MC-Unique: qx_Yq_jcM4u1DbNvUjzc0Q-1 Received: by mail-wm1-f72.google.com with SMTP id a130so7914455wmf.0 for ; Sun, 06 Dec 2020 02:56:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zb05xp01BEyQm5LEh62oLhnL6kPgxUW55TugbE4oo4M=; b=CeKrOaFsSDad3NySyvWBLKaBiOyBpbQ2YjVVNxTiNH3di6tsTJqa1ET7Ob0OI0EnVs fPjVZWUf/YueNt2uoGtCKPIWQw90+FhlS98nbVv7eK80gVYtLDfMs7rl1LwZUSA2ReMT +vETMZYo4LC8q6DdvMbUMY1HNytVoTnSMI39ruchfPbZFpAAAp6KdITvZVGWaAfMg76W SSo2veCZR7KDZpLDKkC/PNXX1+im0+qM2eVOSUOc19OKHw/MbZU3Ze/GOqrJxrQNQ1Qs xfklmS5/Pem2BtojUsa9tE/BX/pwG2EoHA6uhXhaQTzqsc214tQK5aLLkUEQjdn59ZAF ftlQ== X-Gm-Message-State: AOAM531E8+V2VIrhLuc9GcZMRv/iwsU1/wbGe4LPkt19I+2XuDojY170 2j+m0SpWxxnNYDZ+UYe2iPXMbbqjyg7yekVUMk6TWc05tuhpT0TlDAotUtRMB3ZU6D7FcJGBsPg 525dh+Ovf9GC1JziP8kEr+2eMkYab9tUCyatRPefssUqvkToDFgRjO7RWJf5z2rMktALVI8J+mh r1iTDDvI4Rcak= X-Received: by 2002:a7b:cf37:: with SMTP id m23mr12991489wmg.37.1607252180165; Sun, 06 Dec 2020 02:56:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyGX3cca6nPagY2g70Cl2YOoYgsl0EaRP4WwTL7DXdmVUAvbBY8Gmu27mN+p01TBovcAihFAA== X-Received: by 2002:a7b:cf37:: with SMTP id m23mr12991464wmg.37.1607252179933; Sun, 06 Dec 2020 02:56:19 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id w17sm10634246wru.82.2020.12.06.02.56.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Dec 2020 02:56:18 -0800 (PST) Subject: Re: [GIT PULL] KVM/arm64 fixes for 5.10, take #5 To: Marc Zyngier References: <20201204181914.783445-1-maz@kernel.org> From: Paolo Bonzini Message-ID: Date: Sun, 6 Dec 2020 11:56:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201204181914.783445-1-maz@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201206_055626_770502_6E6E5F32 X-CRM114-Status: GOOD ( 20.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, Suzuki K Poulose , kernel-team@android.com, Keqian Zhu , Yanan Wang , James Morse , linux-arm-kernel@lists.infradead.org, Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/12/20 19:19, Marc Zyngier wrote: > Hi Paolo, > > A week ago, I was hoping being done with the 5.10 fixes. I should > obviously know better. > > Thanks to Yanan's excellent work, we have another set of page table > fixes, all plugging issues introduced with our new page table code. > The problems range from memory leak to TLB conflicts, all of which are > serious enough to be squashed right away. > > Are we done yet? Fingers crossed. Pulled, thanks. I am not sure I'll get my own pull request to Linus today, though. Paolo > Please pull, > > M. > > The following changes since commit 23bde34771f1ea92fb5e6682c0d8c04304d34b3b: > > KVM: arm64: vgic-v3: Drop the reporting of GICR_TYPER.Last for userspace (2020-11-17 18:51:09 +0000) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git tags/kvmarm-fixes-5.10-5 > > for you to fetch changes up to 7d894834a305568a0168c55d4729216f5f8cb4e6: > > KVM: arm64: Add usage of stage 2 fault lookup level in user_mem_abort() (2020-12-02 09:53:29 +0000) > > ---------------------------------------------------------------- > kvm/arm64 fixes for 5.10, take #5 > > - Don't leak page tables on PTE update > - Correctly invalidate TLBs on table to block transition > - Only update permissions if the fault level matches the > expected mapping size > > ---------------------------------------------------------------- > Yanan Wang (3): > KVM: arm64: Fix memory leak on stage2 update of a valid PTE > KVM: arm64: Fix handling of merging tables into a block entry > KVM: arm64: Add usage of stage 2 fault lookup level in user_mem_abort() > > arch/arm64/include/asm/esr.h | 1 + > arch/arm64/include/asm/kvm_emulate.h | 5 +++++ > arch/arm64/kvm/hyp/pgtable.c | 17 ++++++++++++++++- > arch/arm64/kvm/mmu.c | 11 +++++++++-- > 4 files changed, 31 insertions(+), 3 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel