From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC6A0C433EF for ; Tue, 30 Nov 2021 06:20:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0405E83025; Tue, 30 Nov 2021 07:20:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1638253238; bh=M0RXSJSUm6hbNdZQiT/jf4o8smkr/rgBYZbaROf0niY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gCAdc1VFyD9c9S+bXKYEEqii/5lmyPRFfRIbKNDBgOzowJRyK4GTaXslEWHIbV1mW cVUIXPDQuqdtwB0HiejYHLVCWwjI+fxO9uPtDkXYwaysmEr3AlJqXP1AjQa7AutJoJ zwJaUX3jJrECnyICuNZznUKo4U34CBSCaBeLsebA90BInTgJNS8IqCARpzxzXiCW3R ryoIUIGLxSwXHuMD+IX6+jvTBKrGGuolzRraxSjIsbe1+1irPkwFDCvhODBD2lk7W8 FVZFbuqSaser7fuHh+NScwu//aIO2jTIFBd2Ole4xRql73bIFp9HUAsvzJRG1dIUsn 1K+WYwaSGpeUQ== Received: by phobos.denx.de (Postfix, from userid 109) id 3F0A38302A; Tue, 30 Nov 2021 07:20:36 +0100 (CET) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [IPv6:2001:67c:2050:1::465:107]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 181A082F98 for ; Tue, 30 Nov 2021 07:20:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp202.mailbox.org (unknown [91.198.250.118]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4J3Bsr5HyyzQkJ7; Tue, 30 Nov 2021 07:20:32 +0100 (CET) Message-ID: Date: Tue, 30 Nov 2021 07:20:28 +0100 MIME-Version: 1.0 Subject: Re: [PATCH u-boot-marvell v2 6/9] arm: mvebu: spl: Print srcaddr in error message Content-Language: en-US To: =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: u-boot@lists.denx.de, =?UTF-8?Q?Pali_Roh=c3=a1r?= , =?UTF-8?Q?Marek_Beh=c3=ban?= References: <20211126143738.23830-1-kabel@kernel.org> <20211126143738.23830-7-kabel@kernel.org> From: Stefan Roese In-Reply-To: <20211126143738.23830-7-kabel@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 11/26/21 15:37, Marek Behún wrote: > From: Marek Behún > > Print the wrong srcaddr (spl_image->offset) in error message also for > SATA case. > > Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > arch/arm/mach-mvebu/spl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c > index af9e45ac7a..8c8cbc833f 100644 > --- a/arch/arm/mach-mvebu/spl.c > +++ b/arch/arm/mach-mvebu/spl.c > @@ -190,7 +190,8 @@ int spl_parse_board_header(struct spl_image_info *spl_image, > */ > if (mhdr->blockid == IBR_HDR_SATA_ID) { > if (spl_image->offset < 1) { > - printf("ERROR: Wrong SATA srcaddr in kwbimage\n"); > + printf("ERROR: Wrong SATA srcaddr (%u) in kwbimage\n", > + spl_image->offset); > return -EINVAL; > } > spl_image->offset -= 1; > Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de