From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 884D9C433F5 for ; Thu, 12 May 2022 07:12:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350795AbiELHMv (ORCPT ); Thu, 12 May 2022 03:12:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350793AbiELHMu (ORCPT ); Thu, 12 May 2022 03:12:50 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01B2A663F1; Thu, 12 May 2022 00:12:48 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3C01C1F8FB; Thu, 12 May 2022 07:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652339567; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N3SKGREacY/VZBxYZlWA43Qo1T3ZVt4EPSxKDt+TYNo=; b=tK6l9WwA0S3PYmB83LyohRnziZGNdrjikwc2NiSvkj9v/02/UHhKq6906sz9EWoIs24eD7 6/bfR5jEhcqo1FzFJQEBOvt4KA8craSSf1sHtjUEjXHVZssxZZjSbvWZr84jhNhDFYzb9Q PJEvOpQG627Vr8dQ1G5Q/s8TGqzyxrM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652339567; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N3SKGREacY/VZBxYZlWA43Qo1T3ZVt4EPSxKDt+TYNo=; b=bIHsZks6iw/+lICFtztoZf/xNSAVEqTUNvof1oyPQL9oiyWayPAIFVyqGQDn9jCBdHI4J0 BWJ7nDDFbMFi6PCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1951213A97; Thu, 12 May 2022 07:12:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KGCpBW+zfGJEYAAAMHmgww (envelope-from ); Thu, 12 May 2022 07:12:47 +0000 Message-ID: Date: Thu, 12 May 2022 09:12:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 21/23] ata: ahci-dwc: Add platform-specific quirks support Content-Language: en-US To: Serge Semin , Damien Le Moal , Hans de Goede , Jens Axboe , Serge Semin Cc: Alexey Malahov , Pavel Parkhomenko , Rob Herring , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220511231810.4928-1-Sergey.Semin@baikalelectronics.ru> <20220511231810.4928-22-Sergey.Semin@baikalelectronics.ru> From: Hannes Reinecke In-Reply-To: <20220511231810.4928-22-Sergey.Semin@baikalelectronics.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 5/12/22 01:18, Serge Semin wrote: > Some DWC AHCI SATA IP-core derivatives require to perform small platform > or IP-core specific setups. They are too small to be placed in a dedicated > driver. It's just much easier to have a set of quirks for them right in > the DWC AHCI driver code. Since we are about to add such platform support, > as a pre-requisite we introduce a platform-data based DWC AHCI quirks API. > The platform data can be used to define the flags passed to the > ahci_platform_get_resources() method, additional AHCI host-flags and a set > of callbacks to initialize, re-initialize and clear the platform settings. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Change the local objects prefix from 'dwc_ahci_' to 'ahci_dwc_'. > (@Damien) > --- > drivers/ata/ahci_dwc.c | 52 ++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 48 insertions(+), 4 deletions(-) > This really could be merged with patch 19; as you're adding a new driver you might as well fold this patch in to avoid further modifications. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer