All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Urs Fässler" <urs.fassler@bbv.ch>,
	"bitbake-devel@lists.openembedded.org"
	<bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH 0/7] Add symlinks for git (shallow) tarballs when name differs due to mirror rewrite rules
Date: Tue, 16 Oct 2018 21:19:50 +0100	[thread overview]
Message-ID: <f8a9b0cd632c8561496b3928b3b2e49775063ae4.camel@linuxfoundation.org> (raw)
In-Reply-To: <20181015134255.4634-1-urs.fassler@bbv.ch>

On Mon, 2018-10-15 at 13:43 +0000, Urs Fässler wrote:
> The git (shallow) tarballs are not found when certain mirror rewrite rules are
> in use. This is due to the fact that the tarball is named according to the url
> where it is downloaded from. The error occurs in the unpack step where BitBake
> looks for a tarball named after the url as specified in the recipe. By adding
> the symlinks BitBake finds the tarballs in the unpack step.
> 
> This is an alternative to the patches "Always use the url specified in the
> recipe as a base for the git shallow tarball naming" from the 23.07.2018. This
> solution is more aligned to the current implementation of BitBake.

This patch series does look much more in keeping with the way bitbake
is written and is easier to review.

I tried it on the autobuilder and it resulted in:


https://autobuilder.yoctoproject.org/typhoon/#/builders/23/builds/120/steps/7/logs/step2b

I'm a bit nervous about accepting these in right now given we're so
close to releasing 2.6 :/.

Cheers,

Richard




      parent reply	other threads:[~2018-10-16 20:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-15 13:43 [PATCH 0/7] Add symlinks for git (shallow) tarballs when name differs due to mirror rewrite rules Urs Fässler
2018-10-15 13:43 ` [PATCH 1/7] fetch2/git: add tests to capture existing behavior wrt. naming of clone directories Urs Fässler
2018-10-15 13:43 ` [PATCH 3/7] fetch2/git: add tests to capture existing behavior wrt. naming of git shallow tarball Urs Fässler
2018-10-15 13:43 ` [PATCH 2/7] fetch2/git: add tests to capture existing behavior wrt. naming of mirror tarball Urs Fässler
2018-10-15 13:43 ` [PATCH 4/7] fetch2/git: use intention revealing names for premirror tests Urs Fässler
2018-10-15 13:43 ` [PATCH 5/7] fetch2: extract the function which ensures that a valid symlink exists Urs Fässler
2018-10-15 13:43 ` [PATCH 6/7] fetch2: add symlinks for mirror tarballs Urs Fässler
2018-10-15 13:43 ` [PATCH 7/7] fetch2: add symlink for shallow " Urs Fässler
2018-10-16 20:19 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8a9b0cd632c8561496b3928b3b2e49775063ae4.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=urs.fassler@bbv.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.