From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A0C8C00140 for ; Fri, 12 Aug 2022 18:58:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238546AbiHLS6U (ORCPT ); Fri, 12 Aug 2022 14:58:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238680AbiHLS6S (ORCPT ); Fri, 12 Aug 2022 14:58:18 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADF7878BF5 for ; Fri, 12 Aug 2022 11:58:16 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id v2so2494792lfi.6 for ; Fri, 12 Aug 2022 11:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=0T4LEUf9g9JExx3ypW6bMQEGQ4KwlOj22ZYnNW8hJ0M=; b=qlbem+f5/BkpCRDfrefN/n7Y9dO49InR2/wWpo/bdPKeSsUH1jpYLpjn0TcZW5ihka I0RqqTpdQxurQHvmOlTixWFmVPikSrNm9N0T+LLiUIZlEOuC1s87gXWa4AkeLnYq53z5 sy6kpPQTHE11PQmOhAa2LjMLkscK0Bo2CYn8PAvQew1o7whi6NgehPba/xzXO9nTb8hP urpXQeiNnueerXLr7xR2C4xjhLIqWR1aWQPrAmNAEENWwEUFsyU2F6yrhdvG34XD+X2N FShYWucn/2YxeBTLHE3zueskvhOwIpch3X8jMQyl/ihwlYojLW+p8pGl8IP98zJNUWIk Am+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=0T4LEUf9g9JExx3ypW6bMQEGQ4KwlOj22ZYnNW8hJ0M=; b=RIEmlHB0SMenh13B1MIhb9HjPDDrUrs/WEGMSb8pDsp24jP0dtY1RWZZRQT8oDZmuo ycWH1Hdd/WTYgYwXQ6KZhO1GKWi2PwiBZUPhFSRKTecnF59pVWREHc51/oDH00AL0T7w PGgbfo2UB6LpPw/cSwo97rNTwk3UoZ/ALp6qX/CQcBFly0IG3gETNwb2VOGY60mCO5g0 RWDjrTKaDbOyATA9Ln3k0Ius2u8f+IDBiYf95/HswRhQL/xh3Z9JL5Yq8NCdEmsecfnj uVNGO9HUk/hak1HOaa8HJKVBB9XNOVTkRPOTDq/ofeApBf1NHYhSNt9goWrDUi5gyCYH 7oZA== X-Gm-Message-State: ACgBeo2yes9pazMu7tY+a/AgpUYW6FYGOu3Gm7/QIxknaJqfV9GML13g QaPT55gf+VhygJrUv851xLq0/w== X-Google-Smtp-Source: AA6agR5wj+d2nQJtyJqxzr4mCH5yDVT3DYcZmKTqO46NuZSod1ujbmiKuERxRAG8Ds2Z97ywhBR63w== X-Received: by 2002:a05:6512:2a8d:b0:48b:7f1:fe46 with SMTP id dt13-20020a0565122a8d00b0048b07f1fe46mr1543360lfb.261.1660330695069; Fri, 12 Aug 2022 11:58:15 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id p20-20020ac24ed4000000b0048b998be041sm293755lfr.309.2022.08.12.11.58.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 11:58:14 -0700 (PDT) Message-ID: Date: Fri, 12 Aug 2022 21:58:10 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 6/6] i2c: imx-lpi2c: handle IPG clock Content-Language: en-US From: Krzysztof Kozlowski To: "Peng Fan (OSS)" , aisheng.dong@nxp.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xiaoning.wang@nxp.com, Peng Fan References: <20220812043424.4078034-1-peng.fan@oss.nxp.com> <20220812043424.4078034-7-peng.fan@oss.nxp.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/08/2022 13:13, Krzysztof Kozlowski wrote: >> + >> + lpi2c_imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg"); >> + if (IS_ERR(lpi2c_imx->clk_ipg)) { >> + dev_err(&pdev->dev, "can't get I2C ipg clock\n"); >> + return PTR_ERR(lpi2c_imx->clk_ipg); >> } > > You just broke all DTS... And Rob's bot agrees (through bindings): https://lore.kernel.org/all/1660317233.465911.168987.nullmailer@robh.at.kernel.org/ Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72CC5C00140 for ; Fri, 12 Aug 2022 18:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qi0D0XK1eDmSAh6JYxmkJwBZPJ+tDoO+R7PH8iHLoZA=; b=wZl4M5cnHtMukd SwYHbNtwqrIR11h0phlxZpLbf+hZZwyOiLyyVxBT6EUAW3rmr7+1SdnPc8k5uDKFUEcbJkNb+Xuwf dZkmEKhoAoQ4w3aGdWZj0wG3jj+0Be17PSljY+yEUV/vtXQyMUOVrGRrRrt8KkWdfTTvEwOEmjqrP g+cwkZ5lR7HFGQLq3lGuBcaeX7Li/eRODX/Ztv9QJzUkW/q4CzmfvILhri8e0En2Z8JTKOsuo75PD 6sNlynOm3070UxddRfk1Sn7DSe/Y56LZFZJrZ+yab00NqsyenbuJmixVSE6kQZF3tjUjyf8tyVMWF 7DlhZ8e4Apqi4xGdAW0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMZrR-00CIp1-DM; Fri, 12 Aug 2022 18:58:21 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMZrN-00CImh-U9 for linux-arm-kernel@lists.infradead.org; Fri, 12 Aug 2022 18:58:19 +0000 Received: by mail-lf1-x132.google.com with SMTP id x19so2491282lfq.7 for ; Fri, 12 Aug 2022 11:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=0T4LEUf9g9JExx3ypW6bMQEGQ4KwlOj22ZYnNW8hJ0M=; b=qlbem+f5/BkpCRDfrefN/n7Y9dO49InR2/wWpo/bdPKeSsUH1jpYLpjn0TcZW5ihka I0RqqTpdQxurQHvmOlTixWFmVPikSrNm9N0T+LLiUIZlEOuC1s87gXWa4AkeLnYq53z5 sy6kpPQTHE11PQmOhAa2LjMLkscK0Bo2CYn8PAvQew1o7whi6NgehPba/xzXO9nTb8hP urpXQeiNnueerXLr7xR2C4xjhLIqWR1aWQPrAmNAEENWwEUFsyU2F6yrhdvG34XD+X2N FShYWucn/2YxeBTLHE3zueskvhOwIpch3X8jMQyl/ihwlYojLW+p8pGl8IP98zJNUWIk Am+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=0T4LEUf9g9JExx3ypW6bMQEGQ4KwlOj22ZYnNW8hJ0M=; b=hu4p20XViV7c3FXS6bfYR6juUjIEMzf0Zp4p8Ve85rzkqXWaZQPYagft/jkYU00NnM jMCg4CBbLpNZIFeZ1XGlGSwirPR2L80xLLoEdVIWhLP3F+JKDykx9tq0C3B8xSTkQHxW Zved94Fn2Vis1WkaZbq8cnIrOCMWU5wXeEj81i1NTo4+5gmpXYLw/FqoBuk/N1pGFSyF FqXrTi4hiipqZmJO41Y+enuKQe51vAAFpTJ6KbNLxOxpoy79mZ/V9zrBtMRPgb7/oLpO RzWjX1AccZB1wMsLK4l26DXOnwQ/D5+OFMaGUziQ4lPnVGIbS5MhpiX/Cc5kBEWtm1N9 PjZw== X-Gm-Message-State: ACgBeo1QAR5j6r9Vpq6B5zSbxnsOV8DS9t9WDge8QaJXJ2QgoTh5drW8 xCO6zWdJWK5/s1eiya4IMZmSnaEphX/ilSgO X-Google-Smtp-Source: AA6agR5wj+d2nQJtyJqxzr4mCH5yDVT3DYcZmKTqO46NuZSod1ujbmiKuERxRAG8Ds2Z97ywhBR63w== X-Received: by 2002:a05:6512:2a8d:b0:48b:7f1:fe46 with SMTP id dt13-20020a0565122a8d00b0048b07f1fe46mr1543360lfb.261.1660330695069; Fri, 12 Aug 2022 11:58:15 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id p20-20020ac24ed4000000b0048b998be041sm293755lfr.309.2022.08.12.11.58.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 11:58:14 -0700 (PDT) Message-ID: Date: Fri, 12 Aug 2022 21:58:10 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 6/6] i2c: imx-lpi2c: handle IPG clock Content-Language: en-US From: Krzysztof Kozlowski To: "Peng Fan (OSS)" , aisheng.dong@nxp.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xiaoning.wang@nxp.com, Peng Fan References: <20220812043424.4078034-1-peng.fan@oss.nxp.com> <20220812043424.4078034-7-peng.fan@oss.nxp.com> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220812_115818_011185_6833595F X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/08/2022 13:13, Krzysztof Kozlowski wrote: >> + >> + lpi2c_imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg"); >> + if (IS_ERR(lpi2c_imx->clk_ipg)) { >> + dev_err(&pdev->dev, "can't get I2C ipg clock\n"); >> + return PTR_ERR(lpi2c_imx->clk_ipg); >> } > > You just broke all DTS... And Rob's bot agrees (through bindings): https://lore.kernel.org/all/1660317233.465911.168987.nullmailer@robh.at.kernel.org/ Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel