From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D89CEC433EF for ; Thu, 19 May 2022 03:08:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233068AbiESDI5 (ORCPT ); Wed, 18 May 2022 23:08:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233028AbiESDIu (ORCPT ); Wed, 18 May 2022 23:08:50 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6B76AD9E86 for ; Wed, 18 May 2022 20:08:49 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ACE9023A; Wed, 18 May 2022 20:08:48 -0700 (PDT) Received: from [10.162.42.8] (unknown [10.162.42.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 347F83F73D; Wed, 18 May 2022 20:08:45 -0700 (PDT) Message-ID: Date: Thu, 19 May 2022 08:38:43 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] amba: Drop builtin_amba_driver() Content-Language: en-US To: Arnd Bergmann Cc: Linux ARM , Catalin Marinas , Will Deacon , Russell King , Wang Kefeng , Linux Kernel Mailing List References: <20220517062929.3109873-1-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/18/22 17:50, Arnd Bergmann wrote: > On Tue, May 17, 2022 at 7:29 AM Anshuman Khandual > wrote: >> >> Drop builtin_amba_driver() which is not used anymore. > > The patch looks correct, but I don't see the purpose. Are you trying > to discourage > having amba drivers as built-in? Otherwise the next time we get an amba > driver that cannot be a loadable module, someone might want to add back the > same macro. Right, then it should be added back. But for now this is just dead code and not being used, hence why keep it ? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE0D9C433F5 for ; Thu, 19 May 2022 03:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W63Kex+C0r9VfBYA1sWWhM5Nx7iVuGVvAhiuC1bX6RQ=; b=gUw2KFptVhdMDv D5hQYIWaGDr7WATiutXBaRPngGqiMr+hoWc9vGs1xlS32L5D8hUeurGP4j5bukiFWa7AYVrDTNvvJ 0xgLOsxGxkrLjswsGGCk1884k2MCqW6YwHTW8nFUw21jtL6glPFzyYSVHpCMSSJ8HPfIuDn0ngwhx RXC3g42q7AW0ibqwD0b7j7YYISlKVfgN4LUHl6QXn8hFk8eTDenuQzxwMOu6OCC9G+DXPL2avwG5j k4MKOYJo19+lSIQvHFDgmITv0ElAOEEtWaAZMS9RR0My32iL10zTYysqWFmNh5u7DnHP4AMLS/dxG 3yteCjM8TiKnXX0+LG7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrWWz-004lcm-RT; Thu, 19 May 2022 03:08:53 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrWWw-004lbS-Qo for linux-arm-kernel@lists.infradead.org; Thu, 19 May 2022 03:08:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ACE9023A; Wed, 18 May 2022 20:08:48 -0700 (PDT) Received: from [10.162.42.8] (unknown [10.162.42.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 347F83F73D; Wed, 18 May 2022 20:08:45 -0700 (PDT) Message-ID: Date: Thu, 19 May 2022 08:38:43 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] amba: Drop builtin_amba_driver() Content-Language: en-US To: Arnd Bergmann Cc: Linux ARM , Catalin Marinas , Will Deacon , Russell King , Wang Kefeng , Linux Kernel Mailing List References: <20220517062929.3109873-1-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_200850_993432_62961F31 X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/18/22 17:50, Arnd Bergmann wrote: > On Tue, May 17, 2022 at 7:29 AM Anshuman Khandual > wrote: >> >> Drop builtin_amba_driver() which is not used anymore. > > The patch looks correct, but I don't see the purpose. Are you trying > to discourage > having amba drivers as built-in? Otherwise the next time we get an amba > driver that cannot be a loadable module, someone might want to add back the > same macro. Right, then it should be added back. But for now this is just dead code and not being used, hence why keep it ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel