All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: Maitreyee Rao <maitreye@codeaurora.org>,
	quic_khsieh@quicinc.com, swboyd@chromium.org,
	igt-dev@lists.freedesktop.org, nganji@codeaurora.org,
	seanpaul@chromium.org, aravindh@codeaurora.org
Subject: Re: [igt-dev] [PATCH i-g-t v2] Add an api to support the CTA range color square video test pattern as explained in section 3.2.5.3 of the DP CTS specification. This pattern is required for supporting the CTA range for RGB formats.
Date: Fri, 25 Feb 2022 19:16:04 -0800	[thread overview]
Message-ID: <f8bddb56-e7ce-2fc8-264c-2438fdbc428e@quicinc.com> (raw)
In-Reply-To: <YhNlt9Dpzx4EQSDe@platvala-desk.ger.corp.intel.com>

Hi Petri

On 2/21/2022 2:13 AM, Petri Latvala wrote:
> On Wed, Feb 16, 2022 at 03:03:42PM -0800, Abhinav Kumar wrote:
>> From: Maitreyee Rao <maitreye@codeaurora.org>
>>
>> Also rename the existing api igt_fill_cts_framebuffer to
>> igt_fill_cts_color_ramp_framebuffer to higlight the
>> pattern type.
>>
>> changes in v2:
>> 	- removed redundant pointers
>> 	- fixed overall formatting issues
>> 	- Fixed author name
>>
>> Signed-off-by: Maitreyee Rao <maitreye@codeaurora.org>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> 
> 
> ../lib/igt_fb.c: In function ‘igt_fill_cts_color_square_framebuffer’:
> ../lib/igt_fb.c:1515:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
>   1515 |  uint32_t colors[8][3] = {
>        |  ^~~~~~~~
> ../lib/igt_fb.c:1555:19: warning: initialization of ‘uint8_t *’ {aka ‘unsigned char *’} from incompatible pointer type ‘uint32_t *’ {aka ‘unsigned int *’} [-Wincompatible-pointer-types]
>   1555 |   uint8_t *temp = pixmap;
>        |                   ^~~~~~
> 
> 
> 

I have addressed these and pushed 
https://patchwork.freedesktop.org/patch/476306/.

Somehow the chrome compiler didnt catch these.

Thanks

Abhinav

      reply	other threads:[~2022-02-26  3:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16 23:03 [igt-dev] [PATCH i-g-t v2] Add an api to support the CTA range color square video test pattern as explained in section 3.2.5.3 of the DP CTS specification. This pattern is required for supporting the CTA range for RGB formats Abhinav Kumar
2022-02-16 23:58 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-02-17  8:37 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-02-21 10:13 ` [igt-dev] [PATCH i-g-t v2] " Petri Latvala
2022-02-26  3:16   ` Abhinav Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8bddb56-e7ce-2fc8-264c-2438fdbc428e@quicinc.com \
    --to=quic_abhinavk@quicinc.com \
    --cc=aravindh@codeaurora.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=maitreye@codeaurora.org \
    --cc=nganji@codeaurora.org \
    --cc=petri.latvala@intel.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=seanpaul@chromium.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.