From: Michael Wood <michael.g.wood@intel.com>
To: toaster@yoctoproject.org
Subject: Re: [PATCH 2/3] toaster: Update oe-core fixture for Morty plus master release
Date: Wed, 2 Nov 2016 12:02:04 +0000 [thread overview]
Message-ID: <f8bec757-9907-5abd-38b5-b75e1d554205@intel.com> (raw)
In-Reply-To: <4c90ddb64a4833912ee45b06906e7c074eb0e8d2.1477948776.git.brian.avery@intel.com>
This commit subject line does not match the content of this patch. I
think you've accidentally duplicated it from the first patch.
On 31/10/16 21:22, brian avery wrote:
> Update the poky fixture to include the master and Morty
> releases.
>
> Signed-off-by: brian avery <brian.avery@intel.com>
> ---
> lib/toaster/orm/fixtures/poky.xml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/lib/toaster/orm/fixtures/poky.xml b/lib/toaster/orm/fixtures/poky.xml
> index c192baa..8324071 100644
> --- a/lib/toaster/orm/fixtures/poky.xml
> +++ b/lib/toaster/orm/fixtures/poky.xml
> @@ -7,6 +7,12 @@
> </object>
>
> <!-- Bitbake versions which correspond to the metadata release -->
> + <object model="orm.bitbakeversion" pk="3">
> + <field type="CharField" name="name">master</field>
> + <field type="CharField" name="giturl">git://git.yoctoproject.org/poky</field>
> + <field type="CharField" name="branch">master</field>
> + <field type="CharField" name="dirpath">bitbake</field>
> + </object>
It's a small thing but please also order the objects in the fixtures
sequentially (rather than 3 .. 1.. 2).
> <object model="orm.bitbakeversion" pk="1">
> <field type="CharField" name="name">morty</field>
> <field type="CharField" name="giturl">git://git.yoctoproject.org/poky</field>
> @@ -21,6 +27,13 @@
> </object>
>
> <!-- Releases available -->
> + <object model="orm.release" pk="3">
> + <field type="CharField" name="name">master</field>
> + <field type="CharField" name="description">Yocto Project master</field>
> + <field rel="ManyToOneRel" to="orm.bitbakeversion" name="bitbake_version">3</field>
> + <field type="CharField" name="branch_name">morty</field>
Release master but you've got the branch_name set to "morty" this won't
work!
> + <field type="TextField" name="helptext">Toaster will run your builds using the tip of the <a href="http://git.yoctoproject.org/cgit/cgit.cgi/poky/log/">Yocto Project master branch</a>, where active development takes place. This is not a stable branch, so your builds might not work as expected.</field>
> + </object>
> <object model="orm.release" pk="1">
> <field type="CharField" name="name">morty</field>
> <field type="CharField" name="description">Yocto Project 2.2 "Morty"</field>
As mentioned on the Toaster call last week I've already had a go at
doing these patches already. See
https://bugzilla.yoctoproject.org/show_bug.cgi?id=10497 and the
attachment. This bug is unresolved, when you create a new project it
won't pick up the correct default layers, your patches also don't
address this issue.
Michael
next prev parent reply other threads:[~2016-11-02 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 21:22 [PATCH 0/3] toaster: add master branch back in to releases brian avery
2016-10-31 21:22 ` [PATCH 1/3] toaster: Update oe-core fixture for Morty plus master release brian avery
2016-10-31 21:22 ` [PATCH 2/3] " brian avery
2016-11-02 12:02 ` Michael Wood [this message]
2016-11-02 14:47 ` Brian Avery
2016-10-31 21:22 ` [PATCH 3/3] toaster: Update default release to master brian avery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8bec757-9907-5abd-38b5-b75e1d554205@intel.com \
--to=michael.g.wood@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.