From: Vadim Fedorenko <vfedorenko@novek.ru>
To: David Howells <dhowells@redhat.com>
Cc: syzbot+df400f2f24a1677cd7e0@syzkaller.appspotmail.com,
netdev@vger.kernel.org, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix deadlock around release of dst cached on udp tunnel
Date: Fri, 29 Jan 2021 19:53:42 +0000 [thread overview]
Message-ID: <f8c2e8be-7a5a-83a0-fc86-2bdd1095c33d@novek.ru> (raw)
In-Reply-To: <3834976.1611942088@warthog.procyon.org.uk>
On 29.01.2021 17:41, David Howells wrote:
> Vadim Fedorenko <vfedorenko@novek.ru> wrote:
>
>> You missed the call to dst_release(sk->sk_rx_dst) in
>> rxrpc_sock_destructor. Without it we are still leaking the dst.
>
> Hmmm... I no longer get the messages appearing with this patch. I'll have
> another look.
Sorry, my bad. rxrpc_sock_destructor destroys AF_RXRPC sockets, which are
totally different from the UDP kernel socket used as a transport and which are
destroyed as usual UDP sockets.
Ack-by: Vadim Fedorenko <vfedorenko@novek.ru>
next prev parent reply other threads:[~2021-01-29 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 16:44 [PATCH net] rxrpc: Fix deadlock around release of dst cached on udp tunnel David Howells
2021-01-29 17:30 ` Vadim Fedorenko
2021-01-29 17:36 ` Vadim Fedorenko
2021-01-29 17:41 ` David Howells
2021-01-29 19:53 ` Vadim Fedorenko [this message]
2021-01-29 23:53 David Howells
2021-01-30 5:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8c2e8be-7a5a-83a0-fc86-2bdd1095c33d@novek.ru \
--to=vfedorenko@novek.ru \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+df400f2f24a1677cd7e0@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.