From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C6CC56202 for ; Thu, 26 Nov 2020 18:25:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B89F20B80 for ; Thu, 26 Nov 2020 18:25:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404028AbgKZSZ2 (ORCPT ); Thu, 26 Nov 2020 13:25:28 -0500 Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214]:59502 "EHLO ciao.gmane.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403953AbgKZSZ2 (ORCPT ); Thu, 26 Nov 2020 13:25:28 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1kiLxO-0003AQ-2v for linux-crypto@vger.kernel.org; Thu, 26 Nov 2020 19:25:26 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: linux-crypto@vger.kernel.org From: Christophe JAILLET Subject: Re: [PATCH] crypto: qat - Use dma_set_mask_and_coherent to simplify code Date: Thu, 26 Nov 2020 19:25:20 +0100 Message-ID: References: <20201121071359.1320167-1-christophe.jaillet@wanadoo.fr> <20201126120408.GA21666@silpixa00400314> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 In-Reply-To: <20201126120408.GA21666@silpixa00400314> Content-Language: fr Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Le 26/11/2020 à 13:04, Giovanni Cabiddu a écrit : > Hi Christophe, > > On Sat, Nov 21, 2020 at 07:13:59AM +0000, Christophe JAILLET wrote: >> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by >> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. >> >> While at it, also remove some unless extra () in the 32 bits case. >> >> Signed-off-by: Christophe JAILLET >> --- >> Instead of returning -EFAULT, we could also propagate the error returned >> by dma_set_mask_and_coherent() > I'm going to re-submit implementing the comment above and also including > qat_4xxx. > > Regards, > Sure, sorry for missing this one. CJ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7496DC63697 for ; Thu, 26 Nov 2020 18:25:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17B9A20B80 for ; Thu, 26 Nov 2020 18:25:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404729AbgKZSZb (ORCPT ); Thu, 26 Nov 2020 13:25:31 -0500 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:32628 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404443AbgKZSZb (ORCPT ); Thu, 26 Nov 2020 13:25:31 -0500 Received: from [192.168.42.210] ([81.185.169.32]) by mwinf5d14 with ME id x6RL230040iH0YH036RMEn; Thu, 26 Nov 2020 19:25:26 +0100 X-ME-Helo: [192.168.42.210] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Thu, 26 Nov 2020 19:25:26 +0100 X-ME-IP: 81.185.169.32 Subject: Re: [PATCH] crypto: qat - Use dma_set_mask_and_coherent to simplify code To: Giovanni Cabiddu Cc: "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "andriy.shevchenko@linux.intel.com" , "Trahe, Fiona" , "Ziemba, Wojciech" , "Chiappero, Marco" , qat-linux , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Newsgroups: gmane.linux.kernel.cryptoapi,gmane.linux.kernel,gmane.linux.kernel.janitors References: <20201121071359.1320167-1-christophe.jaillet@wanadoo.fr> <20201126120408.GA21666@silpixa00400314> From: Christophe JAILLET Message-ID: Date: Thu, 26 Nov 2020 19:25:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201126120408.GA21666@silpixa00400314> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Message-ID: <20201126182520.TKpUfvCJFH-z1Zqeud0B9rCMRuQSr_GPuIbzmR7xZLM@z> Le 26/11/2020 à 13:04, Giovanni Cabiddu a écrit : > Hi Christophe, > > On Sat, Nov 21, 2020 at 07:13:59AM +0000, Christophe JAILLET wrote: >> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by >> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. >> >> While at it, also remove some unless extra () in the 32 bits case. >> >> Signed-off-by: Christophe JAILLET >> --- >> Instead of returning -EFAULT, we could also propagate the error returned >> by dma_set_mask_and_coherent() > I'm going to re-submit implementing the comment above and also including > qat_4xxx. > > Regards, > Sure, sorry for missing this one. CJ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe JAILLET Date: Thu, 26 Nov 2020 18:25:20 +0000 Subject: Re: [PATCH] crypto: qat - Use dma_set_mask_and_coherent to simplify code Message-Id: List-Id: References: <20201121071359.1320167-1-christophe.jaillet@wanadoo.fr> <20201126120408.GA21666@silpixa00400314> In-Reply-To: <20201126120408.GA21666@silpixa00400314> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: linux-crypto@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Le 26/11/2020 à 13:04, Giovanni Cabiddu a écrit : > Hi Christophe, > > On Sat, Nov 21, 2020 at 07:13:59AM +0000, Christophe JAILLET wrote: >> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by >> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. >> >> While at it, also remove some unless extra () in the 32 bits case. >> >> Signed-off-by: Christophe JAILLET >> --- >> Instead of returning -EFAULT, we could also propagate the error returned >> by dma_set_mask_and_coherent() > I'm going to re-submit implementing the comment above and also including > qat_4xxx. > > Regards, > Sure, sorry for missing this one. CJ