From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81EF1C07E9B for ; Tue, 20 Jul 2021 11:42:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1BFD6113A for ; Tue, 20 Jul 2021 11:42:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1BFD6113A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5o8N-0006IK-RV for qemu-devel@archiver.kernel.org; Tue, 20 Jul 2021 07:41:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5N-00039g-R2 for qemu-devel@nongnu.org; Tue, 20 Jul 2021 07:38:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56409) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5L-00076u-FK for qemu-devel@nongnu.org; Tue, 20 Jul 2021 07:38:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626781129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OY4qLW9DIK1kqooda4jUaoSUW7TA+DoSTtq57cSXRuQ=; b=SmssYuNF+0ESuYzioDpcBFEeOw3fWZmo6YUP2bC8urYIDHcDdgtHq3NOTVU60OQhfBL/Xm n/y1n41qTliYbQ2Em/XnjxMTaZFpSt6Cc4qPy0LRwdpglpuJX+Phia5Z9kDNmpGY6z4yZ0 uy5Tx0LtbUVJPF7Gfs814oafQ+o4smU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-ROv4GmP4OBmgowVSWrXYzw-1; Tue, 20 Jul 2021 07:38:48 -0400 X-MC-Unique: ROv4GmP4OBmgowVSWrXYzw-1 Received: by mail-wr1-f71.google.com with SMTP id y15-20020a5d614f0000b029013cd60e9baaso10178443wrt.7 for ; Tue, 20 Jul 2021 04:38:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OY4qLW9DIK1kqooda4jUaoSUW7TA+DoSTtq57cSXRuQ=; b=FCx24mwTINHmMreCVKgrtf/+zHGcKwsFKvCqYmyhFVcqBtN27MsNPhqFh/GqxP06Ix K67PFMEBDHmk8+vHu0GQOFzC+0nR0MqwDvEvnx+uZmdbh3YyvXu1M8M2f6RhYKGklm6i PqPAdMicNjVpbRY3EcufWUUabTHesQL0stIQ+WDKCn1Nnx/MR2WNWWkFHGxNcjXQv8LV 74EL9Jv35UTzyX1M3BrW9DniJYSFbQ0Sp4bXa3IQMAkTOdkYPUlhc2pCLf9mbf/zASLQ 8wm8sGhQ5nQQKyvFcMDMV6MXkIdmQGi4/aTbXqv/kzyKTetBYLGPRNS/RSy9jkIM4dFO dnoQ== X-Gm-Message-State: AOAM531ySz4Sq2o5uF5nSZspkyJzXPbs7ThADdS6NTEQaRZOGty772xt ausW8TfAilmmp6c1OvqFk4lswz3nrcK8Xhq+/g7wvIm28dWyecZEXhukw0V/0kGO14ySZQzn06o wUBRUsoG/gqLNZQA= X-Received: by 2002:a7b:c76b:: with SMTP id x11mr37919191wmk.79.1626781126269; Tue, 20 Jul 2021 04:38:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdynYhBiLxIFD1ic/bvPKLux8bt1OJ0lyQM6hEBmD36uFdLfV7YJv3+TvqHQuQ3pLAm0ODAw== X-Received: by 2002:a7b:c76b:: with SMTP id x11mr37919169wmk.79.1626781126031; Tue, 20 Jul 2021 04:38:46 -0700 (PDT) Received: from [192.168.100.42] ([82.142.17.146]) by smtp.gmail.com with ESMTPSA id b16sm24703753wrs.51.2021.07.20.04.38.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jul 2021 04:38:45 -0700 (PDT) Subject: Re: [PULL v3 05/19] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35 To: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Julia Suvorova References: <20210716151416.155127-1-mst@redhat.com> <20210716151416.155127-6-mst@redhat.com> From: Laurent Vivier Message-ID: Date: Tue, 20 Jul 2021 13:38:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210716151416.155127-6-mst@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lvivier@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.474, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Richard Henderson , Igor Mammedov , Paolo Bonzini , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 16/07/2021 17:15, Michael S. Tsirkin wrote: > From: Julia Suvorova > > Q35 has three different types of PCI devices hot-plug: PCIe Native, > SHPC Native and ACPI hot-plug. This patch changes the default choice > for cold-plugged bridges from PCIe Native to ACPI Hot-plug with > ability to use SHPC and PCIe Native for hot-plugged bridges. > > This is a list of the PCIe Native hot-plug issues that led to this > change: > * no racy behavior during boot (see 110c477c2ed) > * no delay during deleting - after the actual power off software > must wait at least 1 second before indicating about it. This case > is quite important for users, it even has its own bug: > https://bugzilla.redhat.com/show_bug.cgi?id=1594168 > * no timer-based behavior - in addition to the previous example, > the attention button has a 5-second waiting period, during which > the operation can be canceled with a second press. While this > looks fine for manual button control, automation will result in > the need to queue or drop events, and the software receiving > events in all sort of unspecified combinations of attention/power > indicator states, which is racy and uppredictable. > * fixes: > * https://bugzilla.redhat.com/show_bug.cgi?id=1752465 > * https://bugzilla.redhat.com/show_bug.cgi?id=1690256 > > To return to PCIe Native hot-plug: > -global ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off > > Known issue: older linux guests need the following flag > to allow hotplugged pci express devices to use io: > -device pcie-root-port,io-reserve=4096. > io is unusual for pci express so this seems minor. > We'll fix this by a follow up patch. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > Message-Id: <20210713004205.775386-6-jusual@redhat.com> > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > Reviewed-by: David Gibson > --- > hw/acpi/ich9.c | 2 +- > hw/i386/pc.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c > index 2f4eb453ac..778e27b659 100644 > --- a/hw/acpi/ich9.c > +++ b/hw/acpi/ich9.c > @@ -427,7 +427,7 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm) > pm->disable_s3 = 0; > pm->disable_s4 = 0; > pm->s4_val = 2; > - pm->use_acpi_hotplug_bridge = false; > + pm->use_acpi_hotplug_bridge = true; > > object_property_add_uint32_ptr(obj, ACPI_PM_PROP_PM_IO_BASE, > &pm->pm_io_base, OBJ_PROP_FLAG_READ); > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index aa79c5e0e6..f4c7a78362 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -99,6 +99,7 @@ GlobalProperty pc_compat_6_0[] = { > { "qemu64" "-" TYPE_X86_CPU, "model", "6" }, > { "qemu64" "-" TYPE_X86_CPU, "stepping", "3" }, > { TYPE_X86_CPU, "x-vendor-cpuid-only", "off" }, > + { "ICH9-LPC", "acpi-pci-hotplug-with-bridge-support", "off" }, > }; > const size_t pc_compat_6_0_len = G_N_ELEMENTS(pc_compat_6_0); > > There is an issue with this patch. When I try to unplug a VFIO device I have the following error and the device is not unplugged: (qemu) device_del hostdev0 [ 34.116714] ACPI BIOS Error (bug): Could not resolve symbol [^S0B.PCNT], AE_NOT_FOUND (20201113/psargs-330) [ 34.117987] ACPI Error: Aborting method \_SB.PCI0.PCNT due to previous error (AE_NOT_FOUND) (20201113/psparse-531) [ 34.119318] ACPI Error: Aborting method \_GPE._E01 due to previous error (AE_NOT_FOUND) (20201113/psparse-531) [ 34.120600] ACPI Error: AE_NOT_FOUND, while evaluating GPE method [_E01] (20201113/evgpe-515) We can see device is not unplugged (03:00.0) # lspci -v -s 03:00.0 03:00.0 Ethernet controller: Intel Corporation Ethernet Virtual Function 700 Series (rev 02) Subsystem: Intel Corporation Device 0000 Flags: bus master, fast devsel, latency 0 Memory at fe800000 (64-bit, prefetchable) [size=64K] Memory at fe810000 (64-bit, prefetchable) [size=16K] Capabilities: [70] MSI-X: Enable+ Count=5 Masked- Capabilities: [a0] Express Endpoint, MSI 00 Capabilities: [100] Advanced Error Reporting Capabilities: [1a0] Transaction Processing Hints Capabilities: [1d0] Access Control Services Kernel driver in use: iavf Kernel modules: iavf My guest kernel is from RHEL 8.5 (4.18.0-310.el8.x86_64) and my command line is: $QEMU \ -L .../pc-bios \ -nodefaults \ -nographic \ -machine q35 \ -device pcie-root-port,id=pcie-root-port-0,multifunction=on,bus=pcie.0,addr=0x1,chassis=1 \ -device pcie-pci-bridge,id=pcie-pci-bridge-0,addr=0x0,bus=pcie-root-port-0 \ -device pcie-root-port,id=pcie-root-port-1,port=0x1,addr=0x1.0x1,bus=pcie.0,chassis=2 \ -device pcie-root-port,id=pcie-root-port-2,port=0x2,addr=0x1.0x2,bus=pcie.0,chassis=3 \ -device pcie-root-port,id=pcie-root-port-3,port=0x3,addr=0x1.0x3,bus=pcie.0,chassis=4 \ -device pcie-root-port,id=pcie_extra_root_port_0,multifunction=on,bus=pcie.0,addr=0x3,chassis=5 \ -nodefaults \ -m 4066 \ -smp 4 \ -device virtio-scsi-pci,id=virtio_scsi_pci0,bus=pcie-root-port-2,addr=0x0 \ -blockdev node-name=file_image1,driver=file,auto-read-only=on,discard=unmap,aio=threads,filename=$IMAGE,cache.direct=on,cache.no-fl\ -blockdev node-name=drive_image1,driver=qcow2,read-only=off,cache.direct=on,cache.no-flush=off,file=file_image1 \ -device scsi-hd,id=image1,drive=drive_image1,write-cache=on \ -enable-kvm \ -serial mon:stdio \ -device vfio-pci,host=04:02.0,bus=pcie-root-port-1,addr=0x0,id=hostdev0 PCI 04:02.0 is: $ lspci -v -s 04:02.0 04:02.0 Ethernet controller: Intel Corporation Ethernet Virtual Function 700 Series (rev 02) Subsystem: Intel Corporation Device 0000 Flags: fast devsel, NUMA node 0, IOMMU group 53 Memory at 92400000 (64-bit, prefetchable) [virtual] [size=64K] Memory at 92910000 (64-bit, prefetchable) [virtual] [size=16K] Capabilities: Kernel driver in use: vfio-pci Kernel modules: iavf Any idea? Thanks, Laurent