All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heyi Guo <guoheyi@linux.alibaba.com>
To: openbmc <openbmc@lists.ozlabs.org>
Subject: Does it make sense to create a centralized fan control module?
Date: Fri, 11 Jun 2021 09:14:04 +0800	[thread overview]
Message-ID: <f8e08249-d0e4-d632-c76b-495b8ce968d2@linux.alibaba.com> (raw)

Hi All,

Right now fan related data like tacho and PWM is fetched in 
dbus-sensors, and published to d-bus as sensor data, while fan control 
is made in another module like pid-control, which can fetch data and set 
value via d-bus.

In some common sense, we may think about putting all fan related work 
into one single module (which may be based on pid-control), i.e. it can 
read tacho and PWM from hardware directly, calculate the required PWM by 
some algorithm like PID, and then write to PWM hardware directly; the 
data will also be published to d-bus for other modules to consume, like 
fansensor from dbus-sensors.

Does it make sense to do that? Or is there any reason for the current 
design?

I'm new to OpenBMC and some of my understanding may be totally wrong.

Looking forward to your expert advice.

Thanks,

Heyi


             reply	other threads:[~2021-06-11  1:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11  1:14 Heyi Guo [this message]
2021-06-11  1:23 ` Does it make sense to create a centralized fan control module? Heyi Guo
2021-06-16  2:02   ` Heyi Guo
2021-06-16  2:49     ` [Phishing Risk] [External] " John Wang
2021-06-16 11:03       ` Heyi Guo
2021-06-16 16:26 ` Ed Tanous
2021-06-20  8:48   ` Heyi Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8e08249-d0e4-d632-c76b-495b8ce968d2@linux.alibaba.com \
    --to=guoheyi@linux.alibaba.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.