All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Emilio G. Cota" <cota@braap.org>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 1/2] translator: pass max_insns to tb_start
Date: Mon, 19 Feb 2018 11:31:25 -0800	[thread overview]
Message-ID: <f8f48954-e803-c8ba-9b84-5ebb68da006d@linaro.org> (raw)
In-Reply-To: <1518751105-17211-2-git-send-email-cota@braap.org>

On 02/15/2018 07:18 PM, Emilio G. Cota wrote:
> sh4 will need it.
> 
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  accel/tcg/translator.c     | 2 +-
>  include/exec/translator.h  | 3 ++-
>  target/alpha/translate.c   | 3 ++-
>  target/arm/translate-a64.c | 4 +++-
>  target/arm/translate.c     | 4 +++-
>  target/hppa/translate.c    | 4 +++-
>  target/i386/translate.c    | 3 ++-
>  7 files changed, 16 insertions(+), 7 deletions(-)

There is another possibility, which is to move max_insns into DisasContextBase
where it can be modified.  This would allow the gusa sequence to be handled
differently as an instance of the translate_insn hook, which would allow a
breakpoint to be placed on the first insn of a gusa sequence.

I guess I don't have strong feelings either way.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

  reply	other threads:[~2018-02-19 19:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16  3:18 [Qemu-devel] [PATCH 0/2] target/sh4: translator loop conversion Emilio G. Cota
2018-02-16  3:18 ` [Qemu-devel] [PATCH 1/2] translator: pass max_insns to tb_start Emilio G. Cota
2018-02-19 19:31   ` Richard Henderson [this message]
2018-02-19 19:34     ` Richard Henderson
2018-02-19 21:14       ` Emilio G. Cota
2018-02-16  3:18 ` [Qemu-devel] [PATCH 2/2] target/sh4: convert to TranslatorOps Emilio G. Cota
2018-02-19 19:32   ` Richard Henderson
2018-02-23  5:43 ` [Qemu-devel] [PATCH 0/2] target/sh4: translator loop conversion no-reply
2018-02-23 23:44 ` no-reply
2018-02-24 20:36 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8f48954-e803-c8ba-9b84-5ebb68da006d@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=cota@braap.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.