All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Sakoman <steve@sakoman.com>
To: openembedded-core@lists.openembedded.org
Subject: [OE-core][kirkstone 22/34] terminal.py: Restore error output from Terminal
Date: Fri, 29 Apr 2022 06:00:41 -1000	[thread overview]
Message-ID: <f8f8e2e159a5ac03f619e6d0882011445e6a2545.1651246310.git.steve@sakoman.com> (raw)
In-Reply-To: <cover.1651246310.git.steve@sakoman.com>

From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>

In bitbake commit 1ecc1d94 (process: Do not mix stderr with stdout),
bb.process.Popen() was changed to no longer combine stdout and stderr by
default. However, the Terminal class was not updated to reflect this and
subsequently only output stdout in case of failures.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 116d0bb07ba044cf8847bf3d5c3996ad7e58b7ae)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 meta/lib/oe/terminal.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
index 53186c4a3e..de8dcebf94 100644
--- a/meta/lib/oe/terminal.py
+++ b/meta/lib/oe/terminal.py
@@ -30,9 +30,10 @@ class Registry(oe.classutils.ClassRegistry):
 
 class Terminal(Popen, metaclass=Registry):
     def __init__(self, sh_cmd, title=None, env=None, d=None):
+        from subprocess import STDOUT
         fmt_sh_cmd = self.format_command(sh_cmd, title)
         try:
-            Popen.__init__(self, fmt_sh_cmd, env=env)
+            Popen.__init__(self, fmt_sh_cmd, env=env, stderr=STDOUT)
         except OSError as exc:
             import errno
             if exc.errno == errno.ENOENT:
-- 
2.25.1



  parent reply	other threads:[~2022-04-29 16:02 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 16:00 [OE-core][kirkstone 00/34] Patch review Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 01/34] e2fsprogs: fix CVE-2022-1304 Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 02/34] python3: ignore CVE-2015-20107 Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 03/34] cve_check: skip remote patches that haven't been fetched when searching for CVE tags Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 04/34] apt: upgrade 2.4.4 -> 2.4.5 Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 05/34] subversion: upgrade to 1.14.2 Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 06/34] glib: upgrade 2.72.0 -> 2.72.1 Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 07/34] glibc: ptest: Fix glibc-tests package issue Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 08/34] seatd: Disable overflow warning as error on ppc64/musl Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 09/34] package.bbclass: Prevent perform_packagecopy from removing /sysroot-only Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 10/34] kernel-yocto.bbclass: Fixup do_kernel_configcheck usage of KMETA Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 11/34] linux-firmware: correct license for ar3k firmware Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 12/34] arch-armv8-2a.inc: fix a typo in TUNEVALID variable Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 13/34] musl: Fix build when usrmerge distro feature is enabled Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 14/34] gcompat: " Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 15/34] wic: do not use PARTLABEL for msdos partition tables Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 16/34] libc-glibc: Use libxcrypt to provide virtual/crypt Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 17/34] qemu.bbclass: Extend ppc/ppc64 extra options Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 18/34] busybox: Use base_bindir instead of hardcoding /bin path Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 19/34] gstreamer1.0-plugins-good: Fix libsoup dependency Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 20/34] gstreamer1.0: Minor documentation addition Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 21/34] gstreamer1.0-plugins-bad: drop patch Steve Sakoman
2022-04-29 16:00 ` Steve Sakoman [this message]
2022-04-29 16:00 ` [OE-core][kirkstone 23/34] devshell.bbclass: Allow devshell & pydevshell to use the network Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 24/34] cases/buildepoxy.py: fix typo Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 25/34] create-spdx: delete virtual/kernel dependency to fix FreeRTOS build Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 26/34] go.bbclass: disable the use of the default configuration file Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 27/34] install/devshell: Introduce git intercept script due to fakeroot issues Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 28/34] base: Drop git intercept Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 29/34] bitbake.conf: mark all directories as safe for git to read Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 30/34] neard: Switch SRC_URI to git repo Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 31/34] sanity: skip make 4.2.1 warning for debian Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 32/34] util-linux: Create u-a symlink for findfs utility Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 33/34] staging: Ensure we filter out ourselves Steve Sakoman
2022-04-29 16:00 ` [OE-core][kirkstone 34/34] libxml2: update patch status Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8f8e2e159a5ac03f619e6d0882011445e6a2545.1651246310.git.steve@sakoman.com \
    --to=steve@sakoman.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.