From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1da1M0-00031t-82 for qemu-devel@nongnu.org; Tue, 25 Jul 2017 11:02:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1da1Lz-0002tj-AQ for qemu-devel@nongnu.org; Tue, 25 Jul 2017 11:02:32 -0400 Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= References: <20170714123341.373857-1-vsementsov@virtuozzo.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Tue, 25 Jul 2017 12:02:20 -0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qcow2-bitmap: fix bitmap_free List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: kwolf@redhat.com, den@openvz.org, peter.maydell@linaro.org, Eric Blake Maybe worth adding "Coverity: CID 1377700" On 07/14/2017 01:00 PM, Max Reitz wrote: > On 2017-07-14 14:33, Vladimir Sementsov-Ogievskiy wrote: >> Fix possible crash on error path in >> qcow2_remove_persistent_dirty_bitmap. Although bitmap_free was added in >> 88ddffae8fc the bug was introduced later in commit 469c71edc72 (when >> qcow2_remove_persistent_dirty_bitmap was added). >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> Reviewed-by: Eric Blake >> --- >> block/qcow2-bitmap.c | 4 ++++ >> 1 file changed, 4 insertions(+) > > Thanks, applied to my block branch: > > https://github.com/XanClic/qemu/commits/block > > Max >