From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2087C43461 for ; Mon, 7 Sep 2020 15:00:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B61B1206D4 for ; Mon, 7 Sep 2020 15:00:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730064AbgIGPAq (ORCPT ); Mon, 7 Sep 2020 11:00:46 -0400 Received: from jptosegrel01.sonyericsson.com ([124.215.201.71]:2715 "EHLO JPTOSEGREL01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730056AbgIGOxj (ORCPT ); Mon, 7 Sep 2020 10:53:39 -0400 Subject: Re: [PATCH v7 3/3] binder: add transaction latency tracer To: Frankie Chang , Todd Kjos CC: Greg Kroah-Hartman , Joel Fernandes , Martijn Coenen , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Christian Brauner , , , , Jian-Min Liu References: <1596509145.5207.21.camel@mtkswgap22> <1596549552-5466-1-git-send-email-Frankie.Chang@mediatek.com> <1596549552-5466-4-git-send-email-Frankie.Chang@mediatek.com> From: peter enderborg Message-ID: Date: Mon, 7 Sep 2020 16:41:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1596549552-5466-4-git-send-email-Frankie.Chang@mediatek.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-SEG-SpamProfiler-Analysis: v=2.3 cv=FfdJO626 c=1 sm=1 tr=0 a=CGteIMthFL3x4Fb36c5kWA==:117 a=IkcTkHD0fZMA:10 a=reM5J-MqmosA:10 a=9zETfiKQeoRBRZLemOoA:9 a=QEXdDO2ut3YA:10 X-SEG-SpamProfiler-Score: 0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/4/20 3:59 PM, Frankie Chang wrote: > +void probe_binder_txn_latency_free(void *ignore, struct binder_transaction *t, > + int from_proc, int from_thread, > + int to_proc, int to_thread) > +{ > + struct rtc_time tm; > + struct timespec64 *startime; > + struct timespec64 cur, sub_t; > + > + ktime_get_ts64(&cur); I think sched_clock is what you want. > + startime = &t->timestamp; > + sub_t = timespec64_sub(cur, *startime); > + > + /* if transaction time is over than binder_txn_latency_threshold (sec), > + * show timeout warning log. > + */ > + if (sub_t.tv_sec < binder_txn_latency_threshold) > + return; > + > + rtc_time_to_tm(t->tv.tv_sec, &tm); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE73C433E2 for ; Mon, 7 Sep 2020 14:42:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B1EC215A4 for ; Mon, 7 Sep 2020 14:42:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N7a4iVNQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B1EC215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=sony.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DSkLD+QPWCC/GcldvUpuNv4g+YU+7b5iHbYqa2WXez0=; b=N7a4iVNQSRP2MHqrjk3wyR66U 65kcl9qch3CjJTCFZPd8Xvpmmmbw0HTvbE/3JrGlN9R7UNG8dV4c3OhNWQxXogt60ZK2jtSYCKLOI 7ji18+4ORHodjrQoKqN3yzu2lXYw9jSc0cCWIok3O2RF6qz4GMCcH6fJJSfqmt07uWvIRygegTy6Q 3pMQTdCFzMTyAc3rbYq/+Py/MMZw/+34MiIDGwrmfQiSmqolQuqtWQ3g0nHhpz4couvyDyh3tgNWz bIat0L2qEzA09nDeOdX5qMwO1euX11ZZZSxpV9cpNpmVAUEyR9t6hoYEPzvbqonw962XuzDfPr+pV ZWmNWYewg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFILS-0008Pb-LB; Mon, 07 Sep 2020 14:42:10 +0000 Received: from jptosegrel01.sonyericsson.com ([124.215.201.71]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFILP-0008Ou-Ow for linux-mediatek@lists.infradead.org; Mon, 07 Sep 2020 14:42:09 +0000 Subject: Re: [PATCH v7 3/3] binder: add transaction latency tracer To: Frankie Chang , Todd Kjos References: <1596509145.5207.21.camel@mtkswgap22> <1596549552-5466-1-git-send-email-Frankie.Chang@mediatek.com> <1596549552-5466-4-git-send-email-Frankie.Chang@mediatek.com> From: peter enderborg Message-ID: Date: Mon, 7 Sep 2020 16:41:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1596549552-5466-4-git-send-email-Frankie.Chang@mediatek.com> Content-Language: en-GB X-SEG-SpamProfiler-Analysis: v=2.3 cv=FfdJO626 c=1 sm=1 tr=0 a=CGteIMthFL3x4Fb36c5kWA==:117 a=IkcTkHD0fZMA:10 a=reM5J-MqmosA:10 a=9zETfiKQeoRBRZLemOoA:9 a=QEXdDO2ut3YA:10 X-SEG-SpamProfiler-Score: 0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_104207_985289_ACD27F41 X-CRM114-Status: GOOD ( 10.21 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsd_upstream@mediatek.com, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Jian-Min Liu , linux-mediatek@lists.infradead.org, Joel Fernandes , Martijn Coenen , Christian Brauner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 8/4/20 3:59 PM, Frankie Chang wrote: > +void probe_binder_txn_latency_free(void *ignore, struct binder_transaction *t, > + int from_proc, int from_thread, > + int to_proc, int to_thread) > +{ > + struct rtc_time tm; > + struct timespec64 *startime; > + struct timespec64 cur, sub_t; > + > + ktime_get_ts64(&cur); I think sched_clock is what you want. > + startime = &t->timestamp; > + sub_t = timespec64_sub(cur, *startime); > + > + /* if transaction time is over than binder_txn_latency_threshold (sec), > + * show timeout warning log. > + */ > + if (sub_t.tv_sec < binder_txn_latency_threshold) > + return; > + > + rtc_time_to_tm(t->tv.tv_sec, &tm); _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek