All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
To: Masahisa Kojima <masahisa.kojima@linaro.org>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Simon Glass <sjg@chromium.org>, Alexander Graf <agraf@csgraf.de>,
	u-boot@lists.denx.de
Subject: Re: [PATCH] efi_loader: fix BootOrder variable measurement handling
Date: Tue, 9 Nov 2021 12:00:04 +0100	[thread overview]
Message-ID: <f9029c6f-7c99-97b6-536c-0a86a5b8d454@canonical.com> (raw)
In-Reply-To: <20211109094454.32570-1-masahisa.kojima@linaro.org>

On 11/9/21 10:44, Masahisa Kojima wrote:
> UEFI specification does not require that BootOrder is defined.
> In current implementation, boot variable measurement fails and
> returns EFI_NOT_FOUND if BootOrder is not defined.
> 
> This commit correcly handles this case, skip the boot variable
> measurement if BootOrder is not defined.
> 
> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>

=> tpm2 init && tpm2 startup TPM2_SU_CLEAR
=> efidebug boot order 1000
Found 0 disks
Missing RNG device for EFI_RNG_PROTOCOL
No EFI system partition
No EFI system partition
Failed to persist EFI variables
=> efidebug boot order
  1: Boot1000: (not defined)
=> bootefi hello
Booting /MemoryMapped(0x0,0x7ff9b1f0,0x11e0)
Boot1000 not found
Hello, world!
Running on UEFI 2.8
Have SMBIOS table
Have device tree
Load options: <none>
Boot device: /MemoryMapped(0x0,0x7ff9b1f0,0x11e0)
File path: <none>
=>

The message "Boot1000 not found" is created in
lib/efi_loader/efi_tcg2.c(1475) tcg2_measure_boot_variable().
That message should be log_debug(). But that can be done in a separate 
patch.

Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

      parent reply	other threads:[~2021-11-09 11:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09  9:44 [PATCH] efi_loader: fix BootOrder variable measurement handling Masahisa Kojima
2021-11-09  9:44 ` Ilias Apalodimas
2021-11-09 11:00 ` Heinrich Schuchardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9029c6f-7c99-97b6-536c-0a86a5b8d454@canonical.com \
    --to=heinrich.schuchardt@canonical.com \
    --cc=agraf@csgraf.de \
    --cc=ilias.apalodimas@linaro.org \
    --cc=masahisa.kojima@linaro.org \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.