From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C034BC433F5 for ; Tue, 5 Apr 2022 15:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m3QBX/R7CxWk+8LIaNqYX70/Ae8Xav4VWTBLcBlKyjQ=; b=edypIFWQdYPFUU 4ah0/vG5P27E5I9LJ62WKOw6ThaqlHszqUE2zB70lpF8v3QaJZ/GfN8KXOWbl3sApPIUigV/rlWyZ eor7J6UxhohAC/hUVtrYe73W+O3p6kny2TTqje8++N+RbMCeMtHPVFnmjlECzXDk0rDWG19rZMNS4 Ttff3kDtOz5gjntp8cMlFLHGFlNkp+OMLBR+Q97fGEB3T11YCmJL4ii51sg/UJtMNO8aZQuATnfuE ZD/U68hIuniwhCZHl7vc2IAW86BV6ltnYjNSKo7kkeeIvaYaf75Z4LBqt61AyLq7a88vcuNea+jeT 27USZUEu/eyOzmopOy/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbktr-001e6M-Cy; Tue, 05 Apr 2022 15:15:19 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbkto-001e5K-Ce for linux-arm-kernel@lists.infradead.org; Tue, 05 Apr 2022 15:15:18 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbktf-0008C6-St; Tue, 05 Apr 2022 17:15:07 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nbktg-001FZW-En; Tue, 05 Apr 2022 17:15:07 +0200 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1nbkte-0007xb-A6; Tue, 05 Apr 2022 17:15:06 +0200 Message-ID: Subject: Re: [PATCH 6/8] power: reset: at91-reset: add reset_controller_dev support From: Philipp Zabel To: Claudiu.Beznea@microchip.com, robh+dt@kernel.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, sre@kernel.org Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Date: Tue, 05 Apr 2022 17:15:06 +0200 In-Reply-To: <9683a951-160a-b4e4-9494-c2e6ee51582e@microchip.com> References: <20220405112724.2760905-1-claudiu.beznea@microchip.com> <20220405112724.2760905-7-claudiu.beznea@microchip.com> <0ff9a7cd2e6261a0de32db3bf16901e3737efef8.camel@pengutronix.de> <9683a951-160a-b4e4-9494-c2e6ee51582e@microchip.com> User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220405_081516_624359_E7DB2B16 X-CRM114-Status: GOOD ( 27.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQ2xhdWRpbywKCk9uIERpLCAyMDIyLTA0LTA1IGF0IDE0OjQ3ICswMDAwLCBDbGF1ZGl1LkJl em5lYUBtaWNyb2NoaXAuY29tIHdyb3RlOgo+IEhpLCBQaGlsaXBwLAo+IAo+IE9uIDA1LjA0LjIw MjIgMTQ6NDcsIFBoaWxpcHAgWmFiZWwgd3JvdGU6Cj4gPiBFWFRFUk5BTCBFTUFJTDogRG8gbm90 IGNsaWNrIGxpbmtzIG9yIG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlvdQo+ID4ga25vdyB0aGUg Y29udGVudCBpcyBzYWZlCj4gPiAKPiA+IEhpIENsYXVkaXUsCj4gPiAKPiA+IE9uIERpLCAyMDIy LTA0LTA1IGF0IDE0OjI3ICswMzAwLCBDbGF1ZGl1IEJlem5lYSB3cm90ZToKPiA+ID4gU0FNQTdH NSByZXNldCBjb250cm9sbGVyIGhhcyA1IGV4dHJhIGxpbmVzIHRoYXQgZ29lcyB0byBkaWZmZXJl bnQKPiA+ID4gZGV2aWNlcwo+ID4gPiAoMyBsaW5lcyB0byBVU0IgUEhZcywgMSBsaW5lIHRvIERE UiBjb250cm9sbGVyLCBvbmUgbGluZSBERFIgUEhZCj4gPiA+IGNvbnRyb2xsZXIpLiBUaGVzZSBy ZXNldCBsaW5lcyBjb3VsZCBiZSByZXF1ZXN0ZWQgYnkgZGlmZmVyZW50Cj4gPiA+IGNvbnRyb2xs ZXIKPiA+ID4gZHJpdmVycyAoZS5nLiBVU0IgUEhZIGRyaXZlcikgYW5kIHRoZXNlIGNvbnRyb2xs ZXJzJyBkcml2ZXJzCj4gPiA+IGNvdWxkCj4gPiA+IGFzc2VydC9kZWFzc2VydCB0aGVzZSBsaW5l cyB3aGVuIG5lY2Vzc2FyeS4gVGh1cyBhZGQgc3VwcG9ydCBmb3IKPiA+ID4gcmVzZXRfY29udHJv bGxlcl9kZXYgd2hpY2ggYnJpbmdzIHRoaXMgZnVuY3Rpb25hbGl0eS4KPiA+ID4gCj4gPiA+IFNp Z25lZC1vZmYtYnk6IENsYXVkaXUgQmV6bmVhIDxjbGF1ZGl1LmJlem5lYUBtaWNyb2NoaXAuY29t Pgo+ID4gPiAtLS0KPiA+ID4gwqBkcml2ZXJzL3Bvd2VyL3Jlc2V0L2F0OTEtcmVzZXQuYyB8IDky Cj4gPiA+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4gPiA+IMKgMSBmaWxlIGNo YW5nZWQsIDg4IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9wb3dlci9yZXNldC9hdDkxLXJlc2V0LmMKPiA+ID4gYi9kcml2ZXJz L3Bvd2VyL3Jlc2V0L2F0OTEtcmVzZXQuYwo+ID4gPiBpbmRleCAwZDcyMWUyN2Y1NDUuLmIwNGRm NTRjMTVkMiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9wb3dlci9yZXNldC9hdDkxLXJlc2V0 LmMKPiA+ID4gKysrIGIvZHJpdmVycy9wb3dlci9yZXNldC9hdDkxLXJlc2V0LmMKPiA+ID4gQEAg LTE3LDYgKzE3LDcgQEAKPiA+ID4gwqAjaW5jbHVkZSA8bGludXgvb2ZfYWRkcmVzcy5oPgo+ID4g PiDCoCNpbmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9kZXZpY2UuaD4KPiA+ID4gwqAjaW5jbHVkZSA8 bGludXgvcmVib290Lmg+Cj4gPiA+ICsjaW5jbHVkZSA8bGludXgvcmVzZXQtY29udHJvbGxlci5o Pgo+ID4gPiAKPiA+ID4gwqAjaW5jbHVkZSA8c29jL2F0OTEvYXQ5MXNhbTlfZGRyc2RyLmg+Cj4g PiA+IMKgI2luY2x1ZGUgPHNvYy9hdDkxL2F0OTFzYW05X3NkcmFtYy5oPgo+ID4gPiBAQCAtNTMs MTIgKzU0LDE2IEBAIGVudW0gcmVzZXRfdHlwZSB7Cj4gPiA+IMKgc3RydWN0IGF0OTFfcmVzZXQg ewo+ID4gPiDCoMKgwqDCoMKgwqDCoCB2b2lkIF9faW9tZW0gKnJzdGNfYmFzZTsKPiA+ID4gwqDC oMKgwqDCoMKgwqAgdm9pZCBfX2lvbWVtICpyYW1jX2Jhc2VbMl07Cj4gPiA+ICvCoMKgwqDCoMKg wqAgdm9pZCBfX2lvbWVtICpkZXZfYmFzZTsKPiA+ID4gK8KgwqDCoMKgwqDCoCBzdHJ1Y3QgcmVz ZXRfY29udHJvbGxlcl9kZXYgcmNkZXY7Cj4gPiA+IMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBjbGsg KnNjbGs7Cj4gPiA+IMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBub3RpZmllcl9ibG9jayBuYjsKPiA+ ID4gwqDCoMKgwqDCoMKgwqAgdTMyIGFyZ3M7Cj4gPiA+IMKgwqDCoMKgwqDCoMKgIHUzMiByYW1j X2xwcjsKPiA+ID4gwqB9Owo+ID4gPiAKPiA+ID4gKyNkZWZpbmUgdG9fYXQ5MV9yZXNldChyKcKg wqDCoMKgwqDCoCBjb250YWluZXJfb2Yociwgc3RydWN0Cj4gPiA+IGF0OTFfcmVzZXQsIHJjZGV2 KQo+ID4gPiArCj4gPiA+IMKgc3RydWN0IGF0OTFfcmVzZXRfZGF0YSB7Cj4gPiA+IMKgwqDCoMKg wqDCoMKgIHUzMiByZXNldF9hcmdzOwo+ID4gPiDCoMKgwqDCoMKgwqDCoCB1MzIgbl9kZXZpY2Vf cmVzZXQ7Cj4gPiA+IEBAIC0xOTEsNiArMTk2LDc5IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2Zf ZGV2aWNlX2lkCj4gPiA+IGF0OTFfcmVzZXRfb2ZfbWF0Y2hbXSA9IHsKPiA+ID4gwqB9Owo+ID4g PiDCoE1PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIGF0OTFfcmVzZXRfb2ZfbWF0Y2gpOwo+ID4gPiAK PiA+ID4gK3N0YXRpYyBpbnQgYXQ5MV9yZXNldF91cGRhdGUoc3RydWN0IHJlc2V0X2NvbnRyb2xs ZXJfZGV2ICpyY2RldiwKPiA+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIGlkLCBib29sIGFzc2VydCkKPiA+ID4g K3sKPiA+ID4gK8KgwqDCoMKgwqDCoCBzdHJ1Y3QgYXQ5MV9yZXNldCAqcmVzZXQgPSB0b19hdDkx X3Jlc2V0KHJjZGV2KTsKPiA+ID4gK8KgwqDCoMKgwqDCoCB1MzIgdmFsOwo+ID4gPiArCj4gPiA+ ICvCoMKgwqDCoMKgwqAgdmFsID0gcmVhZGxfcmVsYXhlZChyZXNldC0+ZGV2X2Jhc2UpOwo+ID4g PiArwqDCoMKgwqDCoMKgIGlmIChhc3NlcnQpCj4gPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIHZhbCB8PSBCSVQoaWQpOwo+ID4gPiArwqDCoMKgwqDCoMKgIGVsc2UKPiA+ID4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdmFsICY9IH5CSVQoaWQpOwo+ID4gPiArwqDCoMKg wqDCoMKgIHdyaXRlbF9yZWxheGVkKHZhbCwgcmVzZXQtPmRldl9iYXNlKTsKPiA+IAo+ID4gVGhp cyByZWFkLW1vZGlmeS11cGRhdGUgc2hvdWxkIGJlIHByb3RlY3RlZCBieSBhIHNwaW5sb2NrLgo+ ID4gCj4gPiA+ICsKPiA+ID4gK8KgwqDCoMKgwqDCoCByZXR1cm4gMDsKPiA+ID4gK30KPiA+ID4g Kwo+ID4gPiArc3RhdGljIGludCBhdDkxX3Jlc2V0X2Fzc2VydChzdHJ1Y3QgcmVzZXRfY29udHJv bGxlcl9kZXYgKnJjZGV2LAo+ID4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcgaWQpCj4gPiA+ICt7Cj4gPiA+ICvC oMKgwqDCoMKgwqAgcmV0dXJuIGF0OTFfcmVzZXRfdXBkYXRlKHJjZGV2LCBpZCwgdHJ1ZSk7Cj4g PiA+ICt9Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyBpbnQgYXQ5MV9yZXNldF9kZWFzc2VydChzdHJ1 Y3QgcmVzZXRfY29udHJvbGxlcl9kZXYKPiA+ID4gKnJjZGV2LAo+ID4gPiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBs b25nIGlkKQo+ID4gPiArewo+ID4gPiArwqDCoMKgwqDCoMKgIHJldHVybiBhdDkxX3Jlc2V0X3Vw ZGF0ZShyY2RldiwgaWQsIGZhbHNlKTsKPiA+ID4gK30KPiA+ID4gKwo+ID4gPiArc3RhdGljIGlu dCBhdDkxX3Jlc2V0X2Rldl9zdGF0dXMoc3RydWN0IHJlc2V0X2NvbnRyb2xsZXJfZGV2Cj4gPiA+ ICpyY2RldiwKPiA+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcgaWQpCj4gPiA+ICt7Cj4gPiA+ICvC oMKgwqDCoMKgwqAgc3RydWN0IGF0OTFfcmVzZXQgKnJlc2V0ID0gdG9fYXQ5MV9yZXNldChyY2Rl dik7Cj4gPiA+ICvCoMKgwqDCoMKgwqAgdTMyIHZhbDsKPiA+ID4gKwo+ID4gPiArwqDCoMKgwqDC oMKgIHZhbCA9IHJlYWRsX3JlbGF4ZWQocmVzZXQtPmRldl9iYXNlKTsKPiA+ID4gKwo+ID4gPiAr wqDCoMKgwqDCoMKgIHJldHVybiAhISh2YWwgJiBCSVQoaWQpKTsKPiA+ID4gK30KPiA+ID4gKwo+ ID4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCByZXNldF9jb250cm9sX29wcyBhdDkxX3Jlc2V0X29w cyA9IHsKPiA+ID4gK8KgwqDCoMKgwqDCoCAuYXNzZXJ0ID0gYXQ5MV9yZXNldF9hc3NlcnQsCj4g PiA+ICvCoMKgwqDCoMKgwqAgLmRlYXNzZXJ0ID0gYXQ5MV9yZXNldF9kZWFzc2VydCwKPiA+ID4g K8KgwqDCoMKgwqDCoCAuc3RhdHVzID0gYXQ5MV9yZXNldF9kZXZfc3RhdHVzLAo+ID4gPiArfTsK PiA+ID4gKwo+ID4gPiArc3RhdGljIGludCBhdDkxX3Jlc2V0X29mX3hsYXRlKHN0cnVjdCByZXNl dF9jb250cm9sbGVyX2Rldgo+ID4gPiAqcmNkZXYsCj4gPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNvbnN0IHN0cnVjdCBvZl9w aGFuZGxlX2FyZ3MKPiA+ID4gKnJlc2V0X3NwZWMpCj4gPiA+ICt7Cj4gPiA+ICvCoMKgwqDCoMKg wqAgcmV0dXJuIHJlc2V0X3NwZWMtPmFyZ3NbMF07Cj4gPiA+ICt9Cj4gPiAKPiA+IEZvciAxOjEg bWFwcGluZ3MgdGhlcmUgaXMgbm8gbmVlZCBmb3IgYSBjdXN0b20gb2ZfeGxhdGUgaGFuZGxlci4K PiA+IEp1c3QKPiA+IGxlYXZlIG9mX3hsYXRlIGFuZCBvZl9yZXNldF9uX2NlbGxzIGVtcHR5Lgo+ IAo+IEkndmUgZG91YmxlIGNoZWNrZWQgdGhhdC4gVGhpcyB3b3VsZCB3b3JrIGlmIHJlc2V0IGlk cyBhcmUgY29udGludW91cwo+IGZyb20KPiB6ZXJvIHRvIHJjZGV2Lm5yX3Jlc2V0cy4gVGhpcyB0 aGUgb2ZfcmVzZXRfc2ltcGxlX3hsYXRlOgo+IAo+IHN0YXRpYyBpbnQgb2ZfcmVzZXRfc2ltcGxl X3hsYXRlKHN0cnVjdCByZXNldF9jb250cm9sbGVyX2RldiAqcmNkZXYsCj4gwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjb25z dCBzdHJ1Y3Qgb2ZfcGhhbmRsZV9hcmdzCj4gKnJlc2V0X3NwZWMpCj4gewo+IMKgwqDCoMKgwqDC oMKgwqBpZiAocmVzZXRfc3BlYy0+YXJnc1swXSA+PSByY2Rldi0+bnJfcmVzZXRzKQo+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgcmV0dXJuIC1FSU5WQUw7Cj4gwqDCoMKgwqDCoMKg wqDCoHJldHVybiByZXNldF9zcGVjLT5hcmdzWzBdOwo+IH0KPiAKPiBCdXQgaW4gdGhpcyBkcml2 ZXIncyBjYXNlIHdlIGhhdmUgMyBpZHM6IDQsIDUsIDYuIFRoYXQgaXMgdGhlIHJlYXNvbgo+IEkg aGFkIHRoaXMgc2ltcGxlIHhsYXRlIGZ1bmN0aW9uLgoKSSBzZWUuIEluIHRoYXQgY2FzZSBJJ2Qg c2F5IGtlZXAgdGhlIGN1c3RvbSBvZl94bGF0ZSBidXQgbGV0IGl0IHJldHVybgotRUlOVkFMIGlm IHRoZSBhcmdzWzBdIHZhbHVlIGlzIG5vdCA0LCA1LCBvciA2LgoKT3IgeW91IGNvdWxkIHNldCBu cl9yZXNldHMgdG8gNywgYnV0IHVubGVzcyB0aGVyZSBhcmUgbW9yZSByZXNldHMgYXQKdGhlwqBs b3dlciBiaXRzLCB0aGF0IHdvdWxkbid0IG5lY2Vzc2FyaWx5IGJlIGJldHRlci4KCnJlZ2FyZHMK UGhpbGlwcAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1240FC4167B for ; Wed, 6 Apr 2022 00:26:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1588459AbiDFAQE convert rfc822-to-8bit (ORCPT ); Tue, 5 Apr 2022 20:16:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1455406AbiDEP77 (ORCPT ); Tue, 5 Apr 2022 11:59:59 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1565D49241 for ; Tue, 5 Apr 2022 08:15:19 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbktf-0008C6-St; Tue, 05 Apr 2022 17:15:07 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nbktg-001FZW-En; Tue, 05 Apr 2022 17:15:07 +0200 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1nbkte-0007xb-A6; Tue, 05 Apr 2022 17:15:06 +0200 Message-ID: Subject: Re: [PATCH 6/8] power: reset: at91-reset: add reset_controller_dev support From: Philipp Zabel To: Claudiu.Beznea@microchip.com, robh+dt@kernel.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, sre@kernel.org Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Date: Tue, 05 Apr 2022 17:15:06 +0200 In-Reply-To: <9683a951-160a-b4e4-9494-c2e6ee51582e@microchip.com> References: <20220405112724.2760905-1-claudiu.beznea@microchip.com> <20220405112724.2760905-7-claudiu.beznea@microchip.com> <0ff9a7cd2e6261a0de32db3bf16901e3737efef8.camel@pengutronix.de> <9683a951-160a-b4e4-9494-c2e6ee51582e@microchip.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Claudio, On Di, 2022-04-05 at 14:47 +0000, Claudiu.Beznea@microchip.com wrote: > Hi, Philipp, > > On 05.04.2022 14:47, Philipp Zabel wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > > > > Hi Claudiu, > > > > On Di, 2022-04-05 at 14:27 +0300, Claudiu Beznea wrote: > > > SAMA7G5 reset controller has 5 extra lines that goes to different > > > devices > > > (3 lines to USB PHYs, 1 line to DDR controller, one line DDR PHY > > > controller). These reset lines could be requested by different > > > controller > > > drivers (e.g. USB PHY driver) and these controllers' drivers > > > could > > > assert/deassert these lines when necessary. Thus add support for > > > reset_controller_dev which brings this functionality. > > > > > > Signed-off-by: Claudiu Beznea > > > --- > > >  drivers/power/reset/at91-reset.c | 92 > > > ++++++++++++++++++++++++++++++-- > > >  1 file changed, 88 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/power/reset/at91-reset.c > > > b/drivers/power/reset/at91-reset.c > > > index 0d721e27f545..b04df54c15d2 100644 > > > --- a/drivers/power/reset/at91-reset.c > > > +++ b/drivers/power/reset/at91-reset.c > > > @@ -17,6 +17,7 @@ > > >  #include > > >  #include > > >  #include > > > +#include > > > > > >  #include > > >  #include > > > @@ -53,12 +54,16 @@ enum reset_type { > > >  struct at91_reset { > > >         void __iomem *rstc_base; > > >         void __iomem *ramc_base[2]; > > > +       void __iomem *dev_base; > > > +       struct reset_controller_dev rcdev; > > >         struct clk *sclk; > > >         struct notifier_block nb; > > >         u32 args; > > >         u32 ramc_lpr; > > >  }; > > > > > > +#define to_at91_reset(r)       container_of(r, struct > > > at91_reset, rcdev) > > > + > > >  struct at91_reset_data { > > >         u32 reset_args; > > >         u32 n_device_reset; > > > @@ -191,6 +196,79 @@ static const struct of_device_id > > > at91_reset_of_match[] = { > > >  }; > > >  MODULE_DEVICE_TABLE(of, at91_reset_of_match); > > > > > > +static int at91_reset_update(struct reset_controller_dev *rcdev, > > > +                            unsigned long id, bool assert) > > > +{ > > > +       struct at91_reset *reset = to_at91_reset(rcdev); > > > +       u32 val; > > > + > > > +       val = readl_relaxed(reset->dev_base); > > > +       if (assert) > > > +               val |= BIT(id); > > > +       else > > > +               val &= ~BIT(id); > > > +       writel_relaxed(val, reset->dev_base); > > > > This read-modify-update should be protected by a spinlock. > > > > > + > > > +       return 0; > > > +} > > > + > > > +static int at91_reset_assert(struct reset_controller_dev *rcdev, > > > +                            unsigned long id) > > > +{ > > > +       return at91_reset_update(rcdev, id, true); > > > +} > > > + > > > +static int at91_reset_deassert(struct reset_controller_dev > > > *rcdev, > > > +                              unsigned long id) > > > +{ > > > +       return at91_reset_update(rcdev, id, false); > > > +} > > > + > > > +static int at91_reset_dev_status(struct reset_controller_dev > > > *rcdev, > > > +                                unsigned long id) > > > +{ > > > +       struct at91_reset *reset = to_at91_reset(rcdev); > > > +       u32 val; > > > + > > > +       val = readl_relaxed(reset->dev_base); > > > + > > > +       return !!(val & BIT(id)); > > > +} > > > + > > > +static const struct reset_control_ops at91_reset_ops = { > > > +       .assert = at91_reset_assert, > > > +       .deassert = at91_reset_deassert, > > > +       .status = at91_reset_dev_status, > > > +}; > > > + > > > +static int at91_reset_of_xlate(struct reset_controller_dev > > > *rcdev, > > > +                              const struct of_phandle_args > > > *reset_spec) > > > +{ > > > +       return reset_spec->args[0]; > > > +} > > > > For 1:1 mappings there is no need for a custom of_xlate handler. > > Just > > leave of_xlate and of_reset_n_cells empty. > > I've double checked that. This would work if reset ids are continuous > from > zero to rcdev.nr_resets. This the of_reset_simple_xlate: > > static int of_reset_simple_xlate(struct reset_controller_dev *rcdev, >                                  const struct of_phandle_args > *reset_spec) > { >         if (reset_spec->args[0] >= rcdev->nr_resets) >                 return -EINVAL; >         return reset_spec->args[0]; > } > > But in this driver's case we have 3 ids: 4, 5, 6. That is the reason > I had this simple xlate function. I see. In that case I'd say keep the custom of_xlate but let it return -EINVAL if the args[0] value is not 4, 5, or 6. Or you could set nr_resets to 7, but unless there are more resets at the lower bits, that wouldn't necessarily be better. regards Philipp