From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 01/14] Fix whitespace weirdness
Date: Wed, 13 Mar 2019 13:14:29 -0500 [thread overview]
Message-ID: <f9272b3c-2955-4d26-4330-f5792e346040@gmail.com> (raw)
In-Reply-To: <20190312111008.29258-2-jonas@norrbonn.se>
[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]
Hi Jonas,
On 03/12/2019 06:09 AM, Jonas Bonn wrote:
> ---
> drivers/atmodem/network-registration.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c
> index 2482dfc3..1704f98c 100644
> --- a/drivers/atmodem/network-registration.c
> +++ b/drivers/atmodem/network-registration.c
> @@ -1559,12 +1559,12 @@ static void creg_notify(GAtResult *result, gpointer user_data)
> option_query_tech_cb, tq, g_free) > 0)
> return;
> break;
> - case OFONO_VENDOR_GEMALTO:
> - if (g_at_chat_send(nd->chat, "AT^SMONI",
> - smoni_prefix,
> - gemalto_query_tech_cb, tq, g_free) > 0)
> - return;
> - break;
> + case OFONO_VENDOR_GEMALTO:
> + if (g_at_chat_send(nd->chat, "AT^SMONI",
> + smoni_prefix,
> + gemalto_query_tech_cb, tq, g_free) > 0)
You still left some spaces in here. Anyway I fixed this up for you and
applied.
> + return;
> + break;
> }
>
> g_free(tq);
>
Regards,
-Denis
next prev parent reply other threads:[~2019-03-13 18:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 11:09 [PATCH 00/14] ublox patches Jonas Bonn
2019-03-12 11:09 ` [PATCH 01/14] Fix whitespace weirdness Jonas Bonn
2019-03-13 18:14 ` Denis Kenzior [this message]
2019-03-12 11:09 ` [PATCH 02/14] ublox: drop vendor type for Toby L2 model Jonas Bonn
2019-03-13 18:21 ` Denis Kenzior
2019-03-12 11:09 ` [PATCH 03/14] ublox: make device selection more flexible Jonas Bonn
2019-03-13 18:43 ` Denis Kenzior
2019-03-12 11:09 ` [PATCH 04/14] ublox: create model data structures Jonas Bonn
2019-03-13 18:48 ` Denis Kenzior
2019-03-12 11:09 ` [PATCH 05/14] ublox: query device model Jonas Bonn
2019-03-13 18:37 ` Denis Kenzior
2019-03-13 20:24 ` Jonas Bonn
2019-03-12 11:10 ` [PATCH 06/14] ublox: add model flag HAVE_USBCONF Jonas Bonn
2019-03-12 11:10 ` [PATCH 07/14] ublox: query USBCONF for applicable devices Jonas Bonn
2019-03-12 11:10 ` [PATCH 08/14] udevng: ublox: Model string no longer used Jonas Bonn
2019-03-12 11:10 ` [PATCH 09/14] ublox: add device flags Jonas Bonn
2019-03-12 11:10 ` [PATCH 10/14] ublox: add TOBY L4 models Jonas Bonn
2019-03-12 11:10 ` [PATCH 11/14] udevng: detect ublox TOBY L4 Jonas Bonn
2019-03-12 11:10 ` [PATCH 12/14] Separate ATE and AT+CMEE commands Jonas Bonn
2019-03-12 11:10 ` [PATCH 13/14] ublox: extend LTE driver Jonas Bonn
2019-03-12 11:10 ` [PATCH 14/14] ublox: pass model id to LTE plugin Jonas Bonn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9272b3c-2955-4d26-4330-f5792e346040@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.