From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BA96C43331 for ; Tue, 31 Mar 2020 17:13:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4943520848 for ; Tue, 31 Mar 2020 17:13:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g2WAUxku" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4943520848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJKRn-0007sF-EI for qemu-devel@archiver.kernel.org; Tue, 31 Mar 2020 13:13:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48260) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJKQw-0007G5-6T for qemu-devel@nongnu.org; Tue, 31 Mar 2020 13:12:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJKQu-0003oY-4s for qemu-devel@nongnu.org; Tue, 31 Mar 2020 13:12:13 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:26474 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJKQu-0003oJ-1S for qemu-devel@nongnu.org; Tue, 31 Mar 2020 13:12:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585674731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZeGUV/fmekBrqXPnJzgep8AjZx86mvELev1vQ+RcAxo=; b=g2WAUxkuGCATbO2u41uTqFNZi6QUzs2wYOcGVnfpftcbANaZzuDAG8Cn2xBUVB7DXPlX8T diXvwz59L8XiGUz+Jsx+QPvOUOiIpQYXWwePIH4OpWF/3Ff6fS67fVpY89ecTslA8RzFE3 KBSQsIX3nK1OVVxFqx1izIsa5aitMW0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-9tIzQzB-M8iUiey8BcNxnQ-1; Tue, 31 Mar 2020 13:12:06 -0400 X-MC-Unique: 9tIzQzB-M8iUiey8BcNxnQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7F52B13FA; Tue, 31 Mar 2020 17:12:04 +0000 (UTC) Received: from [10.3.113.246] (ovpn-113-246.phx2.redhat.com [10.3.113.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76A02196AE; Tue, 31 Mar 2020 17:12:03 +0000 (UTC) Subject: Re: [PATCH v2] configure: warn if not using a separate build directory To: Markus Armbruster , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20200331155158.381585-1-berrange@redhat.com> <87wo70sdnr.fsf@dusky.pond.sub.org> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Tue, 31 Mar 2020 12:12:02 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <87wo70sdnr.fsf@dusky.pond.sub.org> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , Stefan Hajnoczi , qemu-devel@nongnu.org, Liviu Ionescu , Paolo Bonzini , =?UTF-8?Q?Michal_Such=c3=a1nek?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Aleksandar Markovic Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/31/20 11:16 AM, Markus Armbruster wrote: > Daniel P. Berrang=C3=A9 writes: >=20 >> Running configure directly from the source directory is a build >> configuration that will go away in future. It is also not currently >> covered by any automated testing. Display a deprecation warning if >> the user attempts to use an in-srcdir build setup, so that they are >> aware that they're building QEMU in an undesirable manner. >> >> Signed-off-by: Daniel P. Berrang=C3=A9 >> --- >> >> +if test "$in_srcdir" =3D "yes"; then >> + echo >> + echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS DEPRECATED" >=20 > I don't like shouted warnings, but it's consistent with what we have. The grammar is also a bit awkward to parse; maybe: support for building in the source directory is deprecated --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org