From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2750ECAAD8 for ; Sun, 18 Sep 2022 21:25:32 +0000 (UTC) Received: from localhost ([::1]:52990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oa1n9-00074V-Ko for qemu-devel@archiver.kernel.org; Sun, 18 Sep 2022 17:25:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oa1mK-0005XN-7t; Sun, 18 Sep 2022 17:24:40 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:42667) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oa1mH-0004pp-L4; Sun, 18 Sep 2022 17:24:39 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 9412575A150; Sun, 18 Sep 2022 23:24:32 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 8321374638A; Sun, 18 Sep 2022 23:24:31 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 7EB8974632C; Sun, 18 Sep 2022 23:24:31 +0200 (CEST) Date: Sun, 18 Sep 2022 23:24:31 +0200 (CEST) From: BALATON Zoltan To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, clg@kaod.org, Daniel Henrique Barboza , Peter Maydell Subject: Re: [PATCH v5 16/21] ppc4xx_sdram: Move ppc4xx DDR and DDR2 SDRAM controller models together In-Reply-To: <8495fbef-7eda-fea5-1cf2-60dcb0a50dc4@amsat.org> Message-ID: References: <08665c5c248adc3fa4a44cc05065c38126bb8bfb.1663531117.git.balaton@eik.bme.hu> <8495fbef-7eda-fea5-1cf2-60dcb0a50dc4@amsat.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-1142125177-1663536271=:20833" Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-1142125177-1663536271=:20833 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Sun, 18 Sep 2022, Philippe Mathieu-Daudé wrote: > Hi Zoltan, > > On 18/9/22 22:24, BALATON Zoltan wrote: >> Move the PPC4xx DDR and DDR2 SDRAM contrller models into a new file >> called ppc4xx_sdram to separate from other device models and put them >> in one place allowing sharing some code between them. >> >> Signed-off-by: BALATON Zoltan >> --- >> hw/ppc/meson.build | 3 +- >> hw/ppc/ppc440_uc.c | 332 ----------------- >> hw/ppc/ppc4xx_devs.c | 414 --------------------- >> hw/ppc/ppc4xx_sdram.c | 771 ++++++++++++++++++++++++++++++++++++++++ >> include/hw/ppc/ppc4xx.h | 24 +- >> 5 files changed, 785 insertions(+), 759 deletions(-) > > This seems a proper cleanup, but even using `git-diff > --color-moved=dimmed-zebra` I'm having hard time reviewing this single > patch. > Looking at the changes in the ppc4xx_sdram_types[] array, it > seems we can be move one model at a time, right? I could try to break this patch up some more if absolutely necessary but I've already spent a lot of time rebasing this series as every little change in earlier patch leads to conflicts later then patches get squashed during rebase and I have to redo it again to separate them. So if you can't review it looking at it some more I could try a v6 but don't want if can be avoided. I'll wait for Cédric's comments too in any case to only do as many respins as needed. Regards, BALATON Zoltan > [...] >> +static const TypeInfo ppc4xx_sdram_types[] = { >> + { >> + .name = TYPE_PPC4xx_SDRAM_DDR, >> + .parent = TYPE_PPC4xx_DCR_DEVICE, >> + .instance_size = sizeof(Ppc4xxSdramDdrState), >> + .class_init = ppc4xx_sdram_ddr_class_init, >> + }, { >> + .name = TYPE_PPC4xx_SDRAM_DDR2, >> + .parent = TYPE_PPC4xx_DCR_DEVICE, >> + .instance_size = sizeof(Ppc4xxSdramDdr2State), >> + .class_init = ppc4xx_sdram_ddr2_class_init, >> + } >> +}; >> + >> +DEFINE_TYPES(ppc4xx_sdram_types) > [...] > > --3866299591-1142125177-1663536271=:20833--