From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier Date: Tue, 1 Aug 2017 06:56:41 -0400 Message-ID: References: <150154569340.4135.11548126443780491627.stgit@anamdev.jf.intel.com> <150154788503.4135.7051219373661945937.stgit@anamdev.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: alexander.h.duyck@intel.com, kiran.patil@intel.com, netdev@vger.kernel.org, mitch.a.williams@intel.com, alexander.duyck@gmail.com, neerav.parikh@intel.com, sridhar.samudrala@intel.com, carolyn.wyborny@intel.com, Or Gerlitz To: Amritha Nambiar , intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com Return-path: Received: from mail-it0-f68.google.com ([209.85.214.68]:38789 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751727AbdHAK4n (ORCPT ); Tue, 1 Aug 2017 06:56:43 -0400 Received: by mail-it0-f68.google.com with SMTP id h199so1325563ith.5 for ; Tue, 01 Aug 2017 03:56:43 -0700 (PDT) In-Reply-To: <150154788503.4135.7051219373661945937.stgit@anamdev.jf.intel.com> Content-Language: en-GB Sender: netdev-owner@vger.kernel.org List-ID: On 17-07-31 08:38 PM, Amritha Nambiar wrote: > This patch enables tc-flower based hardware offloads. tc/flower > filter provided by the kernel is configured as driver specific > cloud filter. The patch implements functions and admin queue > commands needed to support cloud filters in the driver and > adds cloud filters to configure these tc-flower filters. > > The only action supported is to redirect packets to a traffic class > on the same device. > > # tc qdisc add dev eth0 ingress > # ethtool -K eth0 hw-tc-offload on > > # tc filter add dev eth0 protocol ip parent ffff:\ > prio 1 flower dst_mac 3c:fd:fe:a0:d6:70 skip_sw indev eth0\ > action mirred ingress redirect dev eth0 tc 0 > Out of curiosity - did you need to say "indev eth0" there? Also: Is it possible to add an skbmark? Example something like these that directs two flows to the same queue but different skb marks: # tc filter add dev eth0 protocol ip parent ffff: \ prio 2 flower dst_ip 192.168.3.5/32 \ ip_proto udp dst_port 2a skip_sw \ action skbedit mark 11 \ action mirred ingress redirect dev eth0 tcqueue 1 # tc filter add dev eth0 protocol ip parent ffff: \ prio 1 flower dst_mac 3c:fd:fe:a0:d6:70 skip_sw \ action skbedit mark 12 \ action mirred ingress redirect dev eth0 tcqueue 1 cheers, jamal From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Date: Tue, 1 Aug 2017 06:56:41 -0400 Subject: [Intel-wired-lan] [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier In-Reply-To: <150154788503.4135.7051219373661945937.stgit@anamdev.jf.intel.com> References: <150154569340.4135.11548126443780491627.stgit@anamdev.jf.intel.com> <150154788503.4135.7051219373661945937.stgit@anamdev.jf.intel.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 17-07-31 08:38 PM, Amritha Nambiar wrote: > This patch enables tc-flower based hardware offloads. tc/flower > filter provided by the kernel is configured as driver specific > cloud filter. The patch implements functions and admin queue > commands needed to support cloud filters in the driver and > adds cloud filters to configure these tc-flower filters. > > The only action supported is to redirect packets to a traffic class > on the same device. > > # tc qdisc add dev eth0 ingress > # ethtool -K eth0 hw-tc-offload on > > # tc filter add dev eth0 protocol ip parent ffff:\ > prio 1 flower dst_mac 3c:fd:fe:a0:d6:70 skip_sw indev eth0\ > action mirred ingress redirect dev eth0 tc 0 > Out of curiosity - did you need to say "indev eth0" there? Also: Is it possible to add an skbmark? Example something like these that directs two flows to the same queue but different skb marks: # tc filter add dev eth0 protocol ip parent ffff: \ prio 2 flower dst_ip 192.168.3.5/32 \ ip_proto udp dst_port 2a skip_sw \ action skbedit mark 11 \ action mirred ingress redirect dev eth0 tcqueue 1 # tc filter add dev eth0 protocol ip parent ffff: \ prio 1 flower dst_mac 3c:fd:fe:a0:d6:70 skip_sw \ action skbedit mark 12 \ action mirred ingress redirect dev eth0 tcqueue 1 cheers, jamal