From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 972D8168 for ; Tue, 4 Jan 2022 20:52:56 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id i11so50127043ljm.13 for ; Tue, 04 Jan 2022 12:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hQXt2kCpfG17wQ1j0L2RQe+/2vBRsqY/bfs0/xljrmk=; b=Sl6kYQCb3QpKqVRvV+KqRiCE6mav78rEOgyuwrXmG0oiUQKGAudDcsSOVFG172QqKl lsyMpFUhe750++f0TIjr8WLhKNIwA55tclWp1quOopzdmbV1mZ9mFZaXiIGJaBooFt84 YfT+wTiBvMjjxhs5SCX1VFbTct2ID3Jzhkd1PwGwGZ9S9fC2Bo+/QROM6dQClKSs1lW0 JGTsphOv1SZWSXCADf5NrWYYv+n8rJ3IpDbvvXCmgNdg10ixNAwAXZww7Clw1D5/KS20 Yt/ogRKlgnah9D/cpkkGxp9/ClIXSAFnsbdNiWoBBObKBHndH1kDZBovDxtrNcR+WIW7 dz4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hQXt2kCpfG17wQ1j0L2RQe+/2vBRsqY/bfs0/xljrmk=; b=SBBgxkewJX8CLhjLytIVfW7/4wIC1BRRoV1HrtCzPe0Vzlg5WZYawrfrvOnKN/7I1V wIDamQ7ehcaYjVEjjWSGOZYrwyRGQKu/qbAefZe6VxHaGZ6d64hvYRm86+49ewEOXRPw gcx59PhnQloBII913xX53nYQPN69Am1O2QGfUfgFG2scE5f1ZOYhf430aTQ0ikP0G7fc An5X3/7gWYfL/DLwNSJsqkahwdZ15RoHuO3iY0CJ9BCNND1b6LzYt1bxuxMlSabjyDOp q+GUF00TJ9OWEDhqE6y4RCnyFCrvyVOtXab5lv+faA0MFb4Oh3CSHEc7XYDpH2/ZvEKr WlTg== X-Gm-Message-State: AOAM531zBOjq7EyPfUqc8gF8NbzwBEV2pbaRsqh+F4H48ULUCiqIjqYH OqLUj6c58r6Kqsi10HQd2K0= X-Google-Smtp-Source: ABdhPJyQK7kBxykRgNtvFA6LuKt3Snmy/xF5WKSxPxjbxF5RTO+yMs1pT9KzaOvYRnmX1y1aOn55UQ== X-Received: by 2002:a05:651c:10a6:: with SMTP id k6mr40926577ljn.194.1641329574663; Tue, 04 Jan 2022 12:52:54 -0800 (PST) Received: from [192.168.1.11] ([94.103.235.38]) by smtp.gmail.com with ESMTPSA id c4sm4015245lfm.160.2022.01.04.12.52.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jan 2022 12:52:54 -0800 (PST) Message-ID: Date: Tue, 4 Jan 2022 23:52:53 +0300 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 5/5] staging: r8188eu: turbo scan is always off for r8188eu Content-Language: en-US To: Martin Kaiser Cc: Greg Kroah-Hartman , Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220102175932.89127-1-martin@kaiser.cx> <20220102175932.89127-6-martin@kaiser.cx> <6d33d346-b797-aeb3-8b1b-64332e05fb87@gmail.com> From: Pavel Skripkin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/4/22 23:51, Martin Kaiser wrote: > Hi Pavel, > > Thus wrote Pavel Skripkin (paskripkin@gmail.com): > >> It's a bit unrelated to the patch, but I found it while reviewing this. It's >> in the same function rtl8188e_PHY_RF6052SetCckTxPower(): > >> 89: u32 TxAGC[2] = {0, 0}; >> ... >> 92 u8 *ptr; >> ... >> 129 for (idx1 = RF_PATH_A; idx1 <= RF_PATH_B; idx1++) { >> 130 ptr = (u8 *)(&TxAGC[idx1]); >> 131 for (idx2 = 0; idx2 < 4; idx2++) { >> 132 if (*ptr > RF6052_MAX_TX_PWR) >> 133 *ptr = RF6052_MAX_TX_PWR; >> 134 ptr++; >> 135 } >> 136 } > > >> What is going on here? Code just checks and writes to random place on stack >> outside TxAGC array? I might be missing something, but it looks wrong... > > TxAGC is two 32-bit values, i.e. 2 x 4 Bytes. The outer loop selects a > 32-bit array entry, the inner loop iterates over each byte of this entry > and checks that it is <= RF6052_MAX_TX_PWR. I don't think this writes past > the end of the TxAGC[] array. > Oh.... I should have go to sleep earlier that evening, sorry. I've missed, that this array is u32, but not u8. Sorry for that noise :( With regards, Pavel Skripkin