From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760064AbcLPJYS (ORCPT ); Fri, 16 Dec 2016 04:24:18 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36011 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753896AbcLPJYM (ORCPT ); Fri, 16 Dec 2016 04:24:12 -0500 Subject: Re: [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub To: Kamalesh Babulal , Michael Ellerman , Jessica Yu References: <1481868864-27283-1-git-send-email-kamalesh@linux.vnet.ibm.com> Cc: Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , linuxppc-dev@lists.ozlabs.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org From: Balbir Singh Message-ID: Date: Fri, 16 Dec 2016 20:21:47 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481868864-27283-1-git-send-email-kamalesh@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/12/16 17:14, Kamalesh Babulal wrote: > commit 425595a7fc20 ("livepatch: reuse module loader code > to write relocations") offloads livepatch module relocation > write to arch specific module loader code. > > Remove unused klp_write_module_reloc() function stub. > > Signed-off-by: Kamalesh Babulal > --- > arch/powerpc/include/asm/livepatch.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/powerpc/include/asm/livepatch.h b/arch/powerpc/include/asm/livepatch.h > index a402f7f..47a03b9 100644 > --- a/arch/powerpc/include/asm/livepatch.h > +++ b/arch/powerpc/include/asm/livepatch.h > @@ -28,13 +28,6 @@ static inline int klp_check_compiler_support(void) > return 0; > } > > -static inline int klp_write_module_reloc(struct module *mod, unsigned long > - type, unsigned long loc, unsigned long value) > -{ > - /* This requires infrastructure changes; we need the loadinfos. */ > - return -ENOSYS; > -} > - Makes sense Acked-by: Balbir Singh