From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kumar, Mahesh" Subject: Re: [PATCH 00/10] Improve crc-core driver interface Date: Tue, 26 Jun 2018 12:02:05 +0530 Message-ID: References: <20180626062259.15563-1-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2009075929==" Return-path: In-Reply-To: <20180626062259.15563-1-mahesh1.kumar@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============2009075929== Content-Type: multipart/alternative; boundary="------------F6333E048F6FCF5429AB5DA5" Content-Language: en-US This is a multi-part message in MIME format. --------------F6333E048F6FCF5429AB5DA5 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc:dri-devel@lists.freedesktop.org On 6/26/2018 11:52 AM, Mahesh Kumar wrote: > This series improves crc-core <-> driver interface. > This series adds following functionality in the crc-core > - Now control node will print all the available sources if > implemented by driver along with current source. > - Setting of sorce will fail if provided source is not supported > - cleanup of crtc_crc_open function first allocate memory before > enabling CRC generation > - Don't block open() call instead wait in crc read call. > > Following IGT will fail due to crc-core <-> driver interface change > igt@kms_pipe_crc_basic@bad-source > ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X > ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence > In nonblocking crc tests we'll get lesser crc's due to skipping crc > > AMD/Rockchip/rcar code path is not validated and need inputs > > Changes: > - Add dri-devel in Cc > > Mahesh Kumar (10): > drm: crc: Introduce verify_crc_source callback > drm: crc: Introduce pre_crc_read function > drm: crc: Introduce get_crc_sources callback > drm/rockchip/crc: Implement verify_crc_source callback > drm/amdgpu_dm/crc: Implement verify_crc_source callback > drm/rcar-du/crc: Implement verify_crc_source callback > drm/i915/crc: implement verify_crc_source callback > drm/i915/crc: implement get_crc_sources callback > drm/crc: Cleanup crtc_crc_open function > Revert "drm: crc: Wait for a frame before returning from open()" > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 +- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 20 +++- > drivers/gpu/drm/drm_debugfs_crc.c | 62 ++++++----- > drivers/gpu/drm/i915/intel_display.c | 2 + > drivers/gpu/drm/i915/intel_drv.h | 8 +- > drivers/gpu/drm/i915/intel_pipe_crc.c | 124 ++++++++++++++++++++- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 45 +++++++- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 27 ++++- > include/drm/drm_crtc.h | 42 ++++++- > 10 files changed, 288 insertions(+), 50 deletions(-) > --------------F6333E048F6FCF5429AB5DA5 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit 
Cc: dri-devel@lists.freedesktop.org

On 6/26/2018 11:52 AM, Mahesh Kumar wrote:
This series improves crc-core <-> driver interface.
This series adds following functionality in the crc-core
 - Now control node will print all the available sources if
   implemented by driver along with current source.
 - Setting of sorce will fail if provided source is not supported
 - cleanup of crtc_crc_open function first allocate memory before
   enabling CRC generation
 - Don't block open() call instead wait in crc read call.

Following IGT will fail due to crc-core <-> driver interface change
igt@kms_pipe_crc_basic@bad-source <now setting bad-source itself will fail>
ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X 
ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence
In nonblocking crc tests we'll get lesser crc's due to skipping crc

AMD/Rockchip/rcar code path is not validated and need inputs

Changes:
 - Add dri-devel in Cc

Mahesh Kumar (10):
  drm: crc: Introduce verify_crc_source callback
  drm: crc: Introduce pre_crc_read function
  drm: crc: Introduce get_crc_sources callback
  drm/rockchip/crc: Implement verify_crc_source callback
  drm/amdgpu_dm/crc: Implement verify_crc_source callback
  drm/rcar-du/crc: Implement verify_crc_source callback
  drm/i915/crc: implement verify_crc_source callback
  drm/i915/crc: implement get_crc_sources callback
  drm/crc: Cleanup crtc_crc_open function
  Revert "drm: crc: Wait for a frame before returning from open()"

 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c  |   1 +
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h  |   7 +-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c  |  20 +++-
 drivers/gpu/drm/drm_debugfs_crc.c                  |  62 ++++++-----
 drivers/gpu/drm/i915/intel_display.c               |   2 +
 drivers/gpu/drm/i915/intel_drv.h                   |   8 +-
 drivers/gpu/drm/i915/intel_pipe_crc.c              | 124 ++++++++++++++++++++-
 drivers/gpu/drm/rcar-du/rcar_du_crtc.c             |  45 +++++++-
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c        |  27 ++++-
 include/drm/drm_crtc.h                             |  42 ++++++-
 10 files changed, 288 insertions(+), 50 deletions(-)

--------------F6333E048F6FCF5429AB5DA5-- --===============2009075929== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2009075929==--