From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x2242n4Wb+s4ZA+HfsNNEldD01MpBX/8l+vFQ8VgEcHxZrfx7n8fI+A9PGlVYgqtnG8RSG3Uf ARC-Seal: i=1; a=rsa-sha256; t=1518380858; cv=none; d=google.com; s=arc-20160816; b=kNKXDjpxn5g9R1jT+idQZw3+fCKJWuPaXC1FpVHUTJcOFlM24Nf0NiMWL3QcNDClxk NTzYeTjJx4hjYCRJ5sm1WNiU/oPvGd1vDqVaA0pED65fORwJm3FovkA4HuqhAukTdUQe HOtwaQyz8vqVF+VZO260BGMh6SyS+yln8z0l9IAJzzJGns4D5tS8knHJkuIwfCMJeY2j 4t2Ph9C3QCXA0/Mca/6nPkKdeBEF7PHjT1m/0wclQJClGVswK9ajuR1f8vIqLS6jiw28 xwgWlcxCH9p7zVRS90mCxuEKwp/qroXnYITPc4GwRp7MOMCo5HnqcKpbpME5AFxudIzv lVOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature:delivered-to:list-id:list-subscribe:list-unsubscribe :list-help:list-post:precedence:mailing-list :arc-authentication-results; bh=QRSm1Nc6TebnZVOSgVBzpvS8y9TFc9rygqDZ4NjtEg8=; b=QN8fzIufxucKvqZSALR5OBFwyuEtkjYAX6ZESd5Vb3NRA2ROuD3OqjaCwKCAGjE4jm 8Ubp3Zkd8pKkqIlb6OOOA2xIffehBdfvfjdapWXk/KBAdVOhYRbR0IEgm5HNJtQpQKTl 1N2eJMpXxUabpihE3z/x9AlsfuminobKZ5Wvkf/5Fc/n8aHyHrj927Olp2xfZK3H+fh7 oySgfWAb+UR4NCyUCV8gRJQEEZgD/pQJQJS5pO7n6v7ozztuysOiDndaDaMQmDUqHMpA cZGARNa2CQRiM9A/Nhomns34STDgtt92651pyFcQYfSeVDNLczhcgP3SxkXG++D2dM1W 6ghQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=jF06J4IS; spf=pass (google.com: domain of kernel-hardening-return-11706-gregkh=linuxfoundation.org@lists.openwall.com designates 195.42.179.200 as permitted sender) smtp.mailfrom=kernel-hardening-return-11706-gregkh=linuxfoundation.org@lists.openwall.com Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=jF06J4IS; spf=pass (google.com: domain of kernel-hardening-return-11706-gregkh=linuxfoundation.org@lists.openwall.com designates 195.42.179.200 as permitted sender) smtp.mailfrom=kernel-hardening-return-11706-gregkh=linuxfoundation.org@lists.openwall.com Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm List-Post: List-Help: List-Unsubscribe: List-Subscribe: Subject: Re: [PATCH 2/6] genalloc: selftest To: Philippe Ombredanne , Igor Stoppa Cc: Matthew Wilcox , Jonathan Corbet , Kees Cook , mhocko@kernel.org, labbott@redhat.com, jglisse@redhat.com, Christoph Hellwig , cl@linux.com, linux-security-module@vger.kernel.org, linux-mm@kvack.org, LKML , kernel-hardening@lists.openwall.com References: <20180211031920.3424-1-igor.stoppa@huawei.com> <20180211031920.3424-3-igor.stoppa@huawei.com> From: Randy Dunlap Message-ID: Date: Sun, 11 Feb 2018 12:27:14 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1591489783349137888?= X-GMAIL-MSGID: =?utf-8?q?1592137727224199640?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 02/11/18 12:22, Philippe Ombredanne wrote: > On Sun, Feb 11, 2018 at 4:19 AM, Igor Stoppa wrote: >> Introduce a set of macros for writing concise test cases for genalloc. >> >> The test cases are meant to provide regression testing, when working on >> new functionality for genalloc. >> >> Primarily they are meant to confirm that the various allocation strategy >> will continue to work as expected. >> >> The execution of the self testing is controlled through a Kconfig option. >> >> Signed-off-by: Igor Stoppa > > > >> --- /dev/null >> +++ b/include/linux/genalloc-selftest.h >> @@ -0,0 +1,26 @@ >> +/* SPDX-License-Identifier: GPL-2.0 > > nit... For a comment in .h this line should be instead its own comment > as the first line: >> +/* SPDX-License-Identifier: GPL-2.0 */ Why are we treating header files (.h) differently than .c files? Either one can use the C++ "//" comment syntax. > > >> --- /dev/null >> +++ b/lib/genalloc-selftest.c >> @@ -0,0 +1,400 @@ >> +/* SPDX-License-Identifier: GPL-2.0 > > And for a comment in .c this line should use C++ style as the first line: > >> +// SPDX-License-Identifier: GPL-2.0 > > Please check the docs for this (I know this can feel surprising but > this has been debated at great length on list) > > Thank you! > -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 From: rdunlap@infradead.org (Randy Dunlap) Date: Sun, 11 Feb 2018 12:27:14 -0800 Subject: [PATCH 2/6] genalloc: selftest In-Reply-To: References: <20180211031920.3424-1-igor.stoppa@huawei.com> <20180211031920.3424-3-igor.stoppa@huawei.com> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On 02/11/18 12:22, Philippe Ombredanne wrote: > On Sun, Feb 11, 2018 at 4:19 AM, Igor Stoppa wrote: >> Introduce a set of macros for writing concise test cases for genalloc. >> >> The test cases are meant to provide regression testing, when working on >> new functionality for genalloc. >> >> Primarily they are meant to confirm that the various allocation strategy >> will continue to work as expected. >> >> The execution of the self testing is controlled through a Kconfig option. >> >> Signed-off-by: Igor Stoppa > > > >> --- /dev/null >> +++ b/include/linux/genalloc-selftest.h >> @@ -0,0 +1,26 @@ >> +/* SPDX-License-Identifier: GPL-2.0 > > nit... For a comment in .h this line should be instead its own comment > as the first line: >> +/* SPDX-License-Identifier: GPL-2.0 */ Why are we treating header files (.h) differently than .c files? Either one can use the C++ "//" comment syntax. > > >> --- /dev/null >> +++ b/lib/genalloc-selftest.c >> @@ -0,0 +1,400 @@ >> +/* SPDX-License-Identifier: GPL-2.0 > > And for a comment in .c this line should use C++ style as the first line: > >> +// SPDX-License-Identifier: GPL-2.0 > > Please check the docs for this (I know this can feel surprising but > this has been debated at great length on list) > > Thank you! > -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id 29F2F6B0007 for ; Sun, 11 Feb 2018 15:27:24 -0500 (EST) Received: by mail-wm0-f69.google.com with SMTP id b193so1594683wmd.7 for ; Sun, 11 Feb 2018 12:27:24 -0800 (PST) Received: from casper.infradead.org (casper.infradead.org. [2001:8b0:10b:1236::1]) by mx.google.com with ESMTPS id l16si5502209wrl.33.2018.02.11.12.27.22 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Feb 2018 12:27:22 -0800 (PST) Subject: Re: [PATCH 2/6] genalloc: selftest References: <20180211031920.3424-1-igor.stoppa@huawei.com> <20180211031920.3424-3-igor.stoppa@huawei.com> From: Randy Dunlap Message-ID: Date: Sun, 11 Feb 2018 12:27:14 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Philippe Ombredanne , Igor Stoppa Cc: Matthew Wilcox , Jonathan Corbet , Kees Cook , mhocko@kernel.org, labbott@redhat.com, jglisse@redhat.com, Christoph Hellwig , cl@linux.com, linux-security-module@vger.kernel.org, linux-mm@kvack.org, LKML , kernel-hardening@lists.openwall.com On 02/11/18 12:22, Philippe Ombredanne wrote: > On Sun, Feb 11, 2018 at 4:19 AM, Igor Stoppa wrote: >> Introduce a set of macros for writing concise test cases for genalloc. >> >> The test cases are meant to provide regression testing, when working on >> new functionality for genalloc. >> >> Primarily they are meant to confirm that the various allocation strategy >> will continue to work as expected. >> >> The execution of the self testing is controlled through a Kconfig option. >> >> Signed-off-by: Igor Stoppa > > > >> --- /dev/null >> +++ b/include/linux/genalloc-selftest.h >> @@ -0,0 +1,26 @@ >> +/* SPDX-License-Identifier: GPL-2.0 > > nit... For a comment in .h this line should be instead its own comment > as the first line: >> +/* SPDX-License-Identifier: GPL-2.0 */ Why are we treating header files (.h) differently than .c files? Either one can use the C++ "//" comment syntax. > > >> --- /dev/null >> +++ b/lib/genalloc-selftest.c >> @@ -0,0 +1,400 @@ >> +/* SPDX-License-Identifier: GPL-2.0 > > And for a comment in .c this line should use C++ style as the first line: > >> +// SPDX-License-Identifier: GPL-2.0 > > Please check the docs for this (I know this can feel surprising but > this has been debated at great length on list) > > Thank you! > -- ~Randy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org