From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53992C43331 for ; Thu, 26 Mar 2020 15:39:21 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EBBB20714 for ; Thu, 26 Mar 2020 15:39:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="h6qlvfhj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EBBB20714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHUat-0008Cu-Q2; Thu, 26 Mar 2020 15:38:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHUar-0008Cp-T9 for xen-devel@lists.xenproject.org; Thu, 26 Mar 2020 15:38:53 +0000 X-Inumbo-ID: e50dcf06-6f77-11ea-8813-12813bfff9fa Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e50dcf06-6f77-11ea-8813-12813bfff9fa; Thu, 26 Mar 2020 15:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1585237133; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=GyGSNVa4VBiWrv00G0trgYXaLyPp1NkmIJydRvNUAec=; b=h6qlvfhjnoDzPftpzAZ5JyotdNcXaEElngkezJ7GVW8zakqOrsOiLP4D M8pTkZgvtkEGDr1rh6iLpu/zatIn3Msw27QJ/s4oBX4qCMlgloE6i3Uzb gorKrL65zohaEt1LuC3KRpR9OhL+ba6hnuLBOYOaaoyuRyusnrPgXjdz0 M=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 3HnLZ+r5KCJcwp8mafGbdDrjWnnaBQYl+xKWMDuQdfhq1LtTofkuikaddUNHhIXC8AuwvYeQ2x ImcOkpPctWAaFHBM4Biw2s7ZdOKA9wBKLDYWL/aHQIN4XHEhfb2OoCgfetPfm4gWpVTrXNvime MA342X34hl9OHyOHMmOde1o6PzJ8s6UvDrR70JY67OqqnQXLDJhT8PmrUxpl0T3cq9vZMsqfce 2Se67O8pQ1v4/ysBAuAkrqts8TqMkj0iR2d7QpTQFob7QTaDH8R+G3+L3l5TPEoEFgkjS8kfbU Ses= X-SBRS: 2.7 X-MesageID: 14703029 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.72,308,1580792400"; d="scan'208";a="14703029" To: Jan Beulich , Julien Grall References: <20200320212453.21685-1-andrew.cooper3@citrix.com> <20200320212453.21685-5-andrew.cooper3@citrix.com> From: Andrew Cooper Message-ID: Date: Thu, 26 Mar 2020 15:38:48 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) Subject: Re: [Xen-devel] [PATCH 4/4] xen: Introduce a xmemdup_bytes() helper X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 23/03/2020 08:38, Jan Beulich wrote: > On 21.03.2020 23:19, Julien Grall wrote: >> On Fri, 20 Mar 2020 at 21:26, Andrew Cooper wrote: >>> --- a/xen/include/xen/xmalloc.h >>> +++ b/xen/include/xen/xmalloc.h >>> @@ -51,6 +51,17 @@ >>> #define xmalloc_bytes(_bytes) _xmalloc(_bytes, SMP_CACHE_BYTES) >>> #define xzalloc_bytes(_bytes) _xzalloc(_bytes, SMP_CACHE_BYTES) >>> >>> +/* Allocate untyped storage and copying an existing instance. */ >>> +#define xmemdup_bytes(_src, _nr) \ >>> + ({ \ >>> + unsigned long nr_ = (_nr); \ >>> + void *dst_ = xmalloc_bytes(nr_); \ >> The nr_ vs _nr is really confusing to read. Could you re-implement the >> function as a static inline? > And even if that wouldn't work out - what's the point of having > macro argument names with leading underscores? Consistency with all the other code in this file. > This isn't any > better standard-wise (afaict) than other uses of leading > underscores for identifiers which aren't CU-scope. It is a parameter describing textural replacement within the body.  There is 0 interaction with external namespacing standards. ~Andrew