From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btg9a-000251-Kv for qemu-devel@nongnu.org; Mon, 10 Oct 2016 15:22:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btg9Y-0005QL-EN for qemu-devel@nongnu.org; Mon, 10 Oct 2016 15:22:25 -0400 References: <1475232808-4852-1-git-send-email-vsementsov@virtuozzo.com> <1475232808-4852-19-git-send-email-vsementsov@virtuozzo.com> <344ea26a-b476-965a-920e-19a4ff94be7c@redhat.com> <90502d55-4edf-73e7-18c2-306d3ebc3822@redhat.com> From: Eric Blake Message-ID: Date: Mon, 10 Oct 2016 14:22:15 -0500 MIME-Version: 1.0 In-Reply-To: <90502d55-4edf-73e7-18c2-306d3ebc3822@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DsM9JAFrwAFJC3tBF3cceF0I4H6WMqXt2" Subject: Re: [Qemu-devel] [PATCH 18/22] qapi: add md5 checksum of last dirty bitmap level to query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DsM9JAFrwAFJC3tBF3cceF0I4H6WMqXt2 From: Eric Blake To: Max Reitz , Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com, pbonzini@redhat.com Message-ID: Subject: Re: [PATCH 18/22] qapi: add md5 checksum of last dirty bitmap level to query-block References: <1475232808-4852-1-git-send-email-vsementsov@virtuozzo.com> <1475232808-4852-19-git-send-email-vsementsov@virtuozzo.com> <344ea26a-b476-965a-920e-19a4ff94be7c@redhat.com> <90502d55-4edf-73e7-18c2-306d3ebc3822@redhat.com> In-Reply-To: <90502d55-4edf-73e7-18c2-306d3ebc3822@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/10/2016 12:03 PM, Max Reitz wrote: >> I'm not sure what the right way would be to get this information out >> (...maybe make it optional and set it only if qtest_enabled() is true?= ), >> but in my opinion this is not the right way. >=20 > By the way, the cleanest way I can come up with (which I didn't write > about in my first reply because it's not so trivial) would be some kind= > of debugging QMP command convention. For instance, we could say that al= l > debugging commands have an x-debug- prefix, and then you could add an > x-debug-get-bitmap-md5 to read the MD5 hash of a named bitmap. That > would appear to be the cleanest way to do this to me. Anything named x- is automatically not stable, and therefore free to use in the testsuite without having to worry about keeping it backwards compatible (libvirt won't touch x- commands). The suggestion of x-debug- to mark it as specifically for debug use is reasonable. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DsM9JAFrwAFJC3tBF3cceF0I4H6WMqXt2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX++pnAAoJEKeha0olJ0NqApMH/1Ay3hJ8VltIDf/IZwFqKBSH IoWUrAnFaNZ13pRdJK/uqQblVasjwNUl7Ax34DsOp03dooYSyb4e72JS0IiUXFGu slF4jjNCeTn1CrXcrLWqyKM/orbEf9Njk5HSBXsfLbelClW/lznIwG2ijec0nCZ2 e38h4zlQ9xMaHVN1OEsTN0AsxJxb+GhsQ9/rkRlAHgDlGFFkfY67DvfztuTcDxWj iwCGxAo/9DNlN19wZZX1CNYCQzrMcdU4QVw16DewC693hvmuU5e5NQ2LsULM3g1a p5tBNb5CAPWKVMxVtHohT/9ZVQeayj7EhWaLBv99NSF9LLxq3XfpGPOYOpb4N5I= =r7jh -----END PGP SIGNATURE----- --DsM9JAFrwAFJC3tBF3cceF0I4H6WMqXt2--