From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 06/18] drm/amdgpu/sriov:fix memory leak after gpu reset Date: Mon, 18 Sep 2017 11:12:47 +0200 Message-ID: References: <1505715122-23904-1-git-send-email-Monk.Liu@amd.com> <1505715122-23904-7-git-send-email-Monk.Liu@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1505715122-23904-7-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Monk Liu , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMTguMDkuMjAxNyB1bSAwODoxMSBzY2hyaWViIE1vbmsgTGl1Ogo+IGRvaW5nIGdwdSByZXNl dCB3aWxsIHJlcnVuIGFsbCBod19pbml0IGFuZCB0aHVzCj4gdWNvZGVfaW5pdF9ibyBpcyBpbnZv a2VkIGFnYWluLCBzbyB3ZSBuZWVkIHRvIHNraXAKPiB0aGUgZndfYnVmIGFsbG9jYXRpb24gZHVy aW5nIHNyaW92IGdwdSByZXNldCB0byBhdm9pZAo+IG1lbW9yeSBsZWFrLgo+Cj4gQ2hhbmdlLUlk OiBJMzExMzFlZGExYmQ0NWVhMmY1YmRjNTBjNWRhNWZjNWE5ZmU5MDI3ZAo+IFNpZ25lZC1vZmYt Ynk6IE1vbmsgTGl1IDxNb25rLkxpdUBhbWQuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1LmggICAgICAgfCAgMyArKwo+ICAgZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X3Vjb2RlLmMgfCA2NCArKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0tCj4gICAyIGZpbGVzIGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDMyIGRlbGV0aW9ucygt KQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgKPiBpbmRleCA2ZmYyOTU5Li4zZDBj NjMzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgKPiBAQCAtMTE4NSw2ICsx MTg1LDkgQEAgc3RydWN0IGFtZGdwdV9maXJtd2FyZSB7Cj4gICAKPiAgIAkvKiBncHUgaW5mbyBm aXJtd2FyZSBkYXRhIHBvaW50ZXIgKi8KPiAgIAljb25zdCBzdHJ1Y3QgZmlybXdhcmUgKmdwdV9p bmZvX2Z3Owo+ICsKPiArCXZvaWQgKmZ3X2J1Zl9wdHI7Cj4gKwl1aW50NjRfdCBmd19idWZfbWM7 Cj4gICB9Owo+ICAgCj4gICAvKgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfdWNvZGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91 Y29kZS5jCj4gaW5kZXggZjMwNjM3NC4uNjU2NDkwMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdWNvZGUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV91Y29kZS5jCj4gQEAgLTM2MCw4ICszNjAsNiBAQCBzdGF0aWMgaW50 IGFtZGdwdV91Y29kZV9wYXRjaF9qdChzdHJ1Y3QgYW1kZ3B1X2Zpcm13YXJlX2luZm8gKnVjb2Rl LAo+ICAgaW50IGFtZGdwdV91Y29kZV9pbml0X2JvKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2 KQo+ICAgewo+ICAgCXN0cnVjdCBhbWRncHVfYm8gKipibyA9ICZhZGV2LT5maXJtd2FyZS5md19i dWY7Cj4gLQl1aW50NjRfdCBmd19tY19hZGRyOwo+IC0Jdm9pZCAqZndfYnVmX3B0ciA9IE5VTEw7 Cj4gICAJdWludDY0X3QgZndfb2Zmc2V0ID0gMDsKPiAgIAlpbnQgaSwgZXJyOwo+ICAgCXN0cnVj dCBhbWRncHVfZmlybXdhcmVfaW5mbyAqdWNvZGUgPSBOVUxMOwo+IEBAIC0zNzIsMzcgKzM3MCwz OSBAQCBpbnQgYW1kZ3B1X3Vjb2RlX2luaXRfYm8oc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYp Cj4gICAJCXJldHVybiAwOwo+ICAgCX0KPiAgIAo+IC0JZXJyID0gYW1kZ3B1X2JvX2NyZWF0ZShh ZGV2LCBhZGV2LT5maXJtd2FyZS5md19zaXplLCBQQUdFX1NJWkUsIHRydWUsCj4gLQkJCQlhbWRn cHVfc3Jpb3ZfdmYoYWRldikgPyBBTURHUFVfR0VNX0RPTUFJTl9WUkFNIDogQU1ER1BVX0dFTV9E T01BSU5fR1RULAo+IC0JCQkJQU1ER1BVX0dFTV9DUkVBVEVfVlJBTV9DT05USUdVT1VTLAo+IC0J CQkJTlVMTCwgTlVMTCwgMCwgYm8pOwo+IC0JaWYgKGVycikgewo+IC0JCWRldl9lcnIoYWRldi0+ ZGV2LCAiKCVkKSBGaXJtd2FyZSBidWZmZXIgYWxsb2NhdGUgZmFpbGVkXG4iLCBlcnIpOwo+IC0J CWdvdG8gZmFpbGVkOwo+IC0JfQo+ICsJaWYgKCFhbWRncHVfc3Jpb3ZfdmYoYWRldikgfHwgIWFk ZXYtPmluX3NyaW92X3Jlc2V0KSB7CgpJbnN0ZWFkIG9mIGFsbCB0aGlzIGJldHRlciB1c2UgYW1k Z3B1X2JvX2NyZWF0ZV9rZXJuZWwoKSwgdGhpcyBzaG91bGQgCmFscmVhZHkgaW5jbHVkZSBtb3N0 IG9mIHRoZSBoYW5kbGluZyBuZWNlc3NhcnkgaGVyZS4KCkNocmlzdGlhbi4KCj4gKwkJZXJyID0g YW1kZ3B1X2JvX2NyZWF0ZShhZGV2LCBhZGV2LT5maXJtd2FyZS5md19zaXplLCBQQUdFX1NJWkUs IHRydWUsCj4gKwkJCQkJYW1kZ3B1X3NyaW92X3ZmKGFkZXYpID8gQU1ER1BVX0dFTV9ET01BSU5f VlJBTSA6IEFNREdQVV9HRU1fRE9NQUlOX0dUVCwKPiArCQkJCQlBTURHUFVfR0VNX0NSRUFURV9W UkFNX0NPTlRJR1VPVVMsCj4gKwkJCQkJTlVMTCwgTlVMTCwgMCwgYm8pOwo+ICsJCWlmIChlcnIp IHsKPiArCQkJZGV2X2VycihhZGV2LT5kZXYsICIoJWQpIEZpcm13YXJlIGJ1ZmZlciBhbGxvY2F0 ZSBmYWlsZWRcbiIsIGVycik7Cj4gKwkJCWdvdG8gZmFpbGVkOwo+ICsJCX0KPiAgIAo+IC0JZXJy ID0gYW1kZ3B1X2JvX3Jlc2VydmUoKmJvLCBmYWxzZSk7Cj4gLQlpZiAoZXJyKSB7Cj4gLQkJZGV2 X2VycihhZGV2LT5kZXYsICIoJWQpIEZpcm13YXJlIGJ1ZmZlciByZXNlcnZlIGZhaWxlZFxuIiwg ZXJyKTsKPiAtCQlnb3RvIGZhaWxlZF9yZXNlcnZlOwo+IC0JfQo+ICsJCWVyciA9IGFtZGdwdV9i b19yZXNlcnZlKCpibywgZmFsc2UpOwo+ICsJCWlmIChlcnIpIHsKPiArCQkJZGV2X2VycihhZGV2 LT5kZXYsICIoJWQpIEZpcm13YXJlIGJ1ZmZlciByZXNlcnZlIGZhaWxlZFxuIiwgZXJyKTsKPiAr CQkJZ290byBmYWlsZWRfcmVzZXJ2ZTsKPiArCQl9Cj4gICAKPiAtCWVyciA9IGFtZGdwdV9ib19w aW4oKmJvLCBhbWRncHVfc3Jpb3ZfdmYoYWRldikgPyBBTURHUFVfR0VNX0RPTUFJTl9WUkFNIDog QU1ER1BVX0dFTV9ET01BSU5fR1RULAo+IC0JCQkJJmZ3X21jX2FkZHIpOwo+IC0JaWYgKGVycikg ewo+IC0JCWRldl9lcnIoYWRldi0+ZGV2LCAiKCVkKSBGaXJtd2FyZSBidWZmZXIgcGluIGZhaWxl ZFxuIiwgZXJyKTsKPiAtCQlnb3RvIGZhaWxlZF9waW47Cj4gLQl9Cj4gKwkJZXJyID0gYW1kZ3B1 X2JvX3BpbigqYm8sIGFtZGdwdV9zcmlvdl92ZihhZGV2KSA/IEFNREdQVV9HRU1fRE9NQUlOX1ZS QU0gOiBBTURHUFVfR0VNX0RPTUFJTl9HVFQsCj4gKwkJCQkJJmFkZXYtPmZpcm13YXJlLmZ3X2J1 Zl9tYyk7Cj4gKwkJaWYgKGVycikgewo+ICsJCQlkZXZfZXJyKGFkZXYtPmRldiwgIiglZCkgRmly bXdhcmUgYnVmZmVyIHBpbiBmYWlsZWRcbiIsIGVycik7Cj4gKwkJCWdvdG8gZmFpbGVkX3BpbjsK PiArCQl9Cj4gICAKPiAtCWVyciA9IGFtZGdwdV9ib19rbWFwKCpibywgJmZ3X2J1Zl9wdHIpOwo+ IC0JaWYgKGVycikgewo+IC0JCWRldl9lcnIoYWRldi0+ZGV2LCAiKCVkKSBGaXJtd2FyZSBidWZm ZXIga21hcCBmYWlsZWRcbiIsIGVycik7Cj4gLQkJZ290byBmYWlsZWRfa21hcDsKPiAtCX0KPiAr CQllcnIgPSBhbWRncHVfYm9fa21hcCgqYm8sICZhZGV2LT5maXJtd2FyZS5md19idWZfcHRyKTsK PiArCQlpZiAoZXJyKSB7Cj4gKwkJCWRldl9lcnIoYWRldi0+ZGV2LCAiKCVkKSBGaXJtd2FyZSBi dWZmZXIga21hcCBmYWlsZWRcbiIsIGVycik7Cj4gKwkJCWdvdG8gZmFpbGVkX2ttYXA7Cj4gKwkJ fQo+ICAgCj4gLQlhbWRncHVfYm9fdW5yZXNlcnZlKCpibyk7Cj4gKwkJYW1kZ3B1X2JvX3VucmVz ZXJ2ZSgqYm8pOwo+ICsJfQo+ICAgCj4gLQltZW1zZXQoZndfYnVmX3B0ciwgMCwgYWRldi0+Zmly bXdhcmUuZndfc2l6ZSk7Cj4gKwltZW1zZXQoYWRldi0+ZmlybXdhcmUuZndfYnVmX3B0ciwgMCwg YWRldi0+ZmlybXdhcmUuZndfc2l6ZSk7Cj4gICAKPiAgIAkvKgo+ICAgCSAqIGlmIFNNVSBsb2Fk ZWQgZmlybXdhcmUsIGl0IG5lZWRuJ3QgYWRkIFNNQywgVVZELCBhbmQgVkNFCj4gQEAgLTQyMSwx NCArNDIxLDE0IEBAIGludCBhbWRncHVfdWNvZGVfaW5pdF9ibyhzdHJ1Y3QgYW1kZ3B1X2Rldmlj ZSAqYWRldikKPiAgIAkJdWNvZGUgPSAmYWRldi0+ZmlybXdhcmUudWNvZGVbaV07Cj4gICAJCWlm ICh1Y29kZS0+ZncpIHsKPiAgIAkJCWhlYWRlciA9IChjb25zdCBzdHJ1Y3QgY29tbW9uX2Zpcm13 YXJlX2hlYWRlciAqKXVjb2RlLT5mdy0+ZGF0YTsKPiAtCQkJYW1kZ3B1X3Vjb2RlX2luaXRfc2lu Z2xlX2Z3KGFkZXYsIHVjb2RlLCBmd19tY19hZGRyICsgZndfb2Zmc2V0LAo+IC0JCQkJCQkgICAg KHZvaWQgKikoKHVpbnQ4X3QgKilmd19idWZfcHRyICsgZndfb2Zmc2V0KSk7Cj4gKwkJCWFtZGdw dV91Y29kZV9pbml0X3NpbmdsZV9mdyhhZGV2LCB1Y29kZSwgYWRldi0+ZmlybXdhcmUuZndfYnVm X21jICsgZndfb2Zmc2V0LAo+ICsJCQkJCQkgICAgYWRldi0+ZmlybXdhcmUuZndfYnVmX3B0ciAr IGZ3X29mZnNldCk7Cj4gICAJCQlpZiAoaSA9PSBBTURHUFVfVUNPREVfSURfQ1BfTUVDMSAmJgo+ ICAgCQkJICAgIGFkZXYtPmZpcm13YXJlLmxvYWRfdHlwZSAhPSBBTURHUFVfRldfTE9BRF9QU1Ap IHsKPiAgIAkJCQljb25zdCBzdHJ1Y3QgZ2Z4X2Zpcm13YXJlX2hlYWRlcl92MV8wICpjcF9oZHI7 Cj4gICAJCQkJY3BfaGRyID0gKGNvbnN0IHN0cnVjdCBnZnhfZmlybXdhcmVfaGVhZGVyX3YxXzAg Kil1Y29kZS0+ZnctPmRhdGE7Cj4gLQkJCQlhbWRncHVfdWNvZGVfcGF0Y2hfanQodWNvZGUsIGZ3 X21jX2FkZHIgKyBmd19vZmZzZXQsCj4gLQkJCQkJCSAgICBmd19idWZfcHRyICsgZndfb2Zmc2V0 KTsKPiArCQkJCWFtZGdwdV91Y29kZV9wYXRjaF9qdCh1Y29kZSwgIGFkZXYtPmZpcm13YXJlLmZ3 X2J1Zl9tYyArIGZ3X29mZnNldCwKPiArCQkJCQkJICAgIGFkZXYtPmZpcm13YXJlLmZ3X2J1Zl9w dHIgKyBmd19vZmZzZXQpOwo+ICAgCQkJCWZ3X29mZnNldCArPSBBTElHTihsZTMyX3RvX2NwdShj cF9oZHItPmp0X3NpemUpIDw8IDIsIFBBR0VfU0laRSk7Cj4gICAJCQl9Cj4gICAJCQlmd19vZmZz ZXQgKz0gQUxJR04odWNvZGUtPnVjb2RlX3NpemUsIFBBR0VfU0laRSk7CgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QK YW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==