Re: [PATCH v2 04/11] tests/acceptance: add kernel record/replay test for x86_64

[Pavel Dovgalyuk <dovgaluk@ispras.ru>]

On 28.05.2020 16:26, Alex Bennée wrote:
> Pavel Dovgalyuk <dovgaluk@ispras.ru> writes:
>
>> On 27.05.2020 18:41, Alex Bennée wrote:
>>> Pavel Dovgalyuk <Pavel.Dovgaluk@gmail.com> writes:
>>>
>>>> This patch adds a test for record/replay an execution of x86_64 machine.
>>>> Execution scenario includes simple kernel boot, which allows testing
>>>> basic hardware interaction in RR mode.
>>>>
>>>> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
>>>> ---
>>>>    0 files changed
>>>>
>>>> diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py
>>>> index b8b277ad2f..c7526f1aba 100644
>>>> --- a/tests/acceptance/replay_kernel.py
>>>> +++ b/tests/acceptance/replay_kernel.py
>>>> @@ -55,3 +55,19 @@ class ReplayKernel(LinuxKernelUtils):
>>>>                        True, shift, args)
>>>>            self.run_vm(kernel_path, kernel_command_line, console_pattern,
>>>>                        False, shift, args)
>>>> +
>>>> +    def test_x86_64_pc(self):
>>>> +        """
>>>> +        :avocado: tags=arch:x86_64
>>>> +        :avocado: tags=machine:pc
>>>> +        """
>>>> +        kernel_url = ('https://archives.fedoraproject.org/pub/archive/fedora'
>>>> +                      '/linux/releases/29/Everything/x86_64/os/images/pxeboot'
>>>> +                      '/vmlinuz')
>>>> +        kernel_hash = '23bebd2680757891cf7adedb033532163a792495'
>>>> +        kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
>>>> +
>>>> +        kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyS0'
>>>> +        console_pattern = 'Kernel command line: %s' % kernel_command_line
>>>> +
>>>> +        self.run_rr(kernel_path, kernel_command_line, console_pattern)
>>> This test fails for me on the replay:
>> Have you applied latest RR patches?
> I have the following on top of the acceptance patches:
>
> a36c23042fe * review/record-replay-acceptance-v2 icount: fix shift=auto for record/replay
> 4ab2164c10b * replay: synchronize on every virtual timer callback
> 66104ce6e4b * replay: notify the main loop when there are no instructions
>
Please also try adding "replay: implement fair mutex"