From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6948C4BA24 for ; Thu, 27 Feb 2020 00:41:12 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F91C21D7E for ; Thu, 27 Feb 2020 00:41:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="owLhTFFX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F91C21D7E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8B8E0166C; Thu, 27 Feb 2020 01:40:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8B8E0166C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582764070; bh=WGITMeNm9IghyFy9BIxe8aNF3+BLI70qjTtd3Kc3nwY=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=owLhTFFXNazGwT1ghEp9MCgW38qwIeKLww3z5arBf4nrPPw8S4vuV9oBuzDrJhbzh 8Fwd6d8ciPyKWQceYvpuTUjJVkk8zV30gt3w8K4gMVTIha6YetfiGTr07fg7QYx0Tr zhUnoT0KiqlkS2tWh3SOZ6lkm8lKRgxLE0dJ8wCY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 213DDF8014D; Thu, 27 Feb 2020 01:40:20 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5B89FF8014E; Thu, 27 Feb 2020 01:40:18 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 38410F800E8 for ; Thu, 27 Feb 2020 01:40:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 38410F800E8 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2020 16:40:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,490,1574150400"; d="scan'208";a="285159557" Received: from unknown (HELO [10.251.27.58]) ([10.251.27.58]) by FMSMGA003.fm.intel.com with ESMTP; 26 Feb 2020 16:40:11 -0800 Subject: Re: [PATCH 6/8] ASoC: soc-pcm: check DAI's activity more simply To: Kuninori Morimoto References: <87eeuh97k4.wl-kuninori.morimoto.gx@renesas.com> <875zft97i4.wl-kuninori.morimoto.gx@renesas.com> <704a2cb1-ebcd-d433-0b8a-0f8d97d72fa5@linux.intel.com> <87v9ns7tpk.wl-kuninori.morimoto.gx@renesas.com> From: Pierre-Louis Bossart Message-ID: Date: Wed, 26 Feb 2020 18:40:10 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87v9ns7tpk.wl-kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Linux-ALSA , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >>> - if ((playback && playback_active == 1) || >>> - (!playback && capture_active == 1)) >>> + if (codec_dai->active == 1) >> >> nit-pick: we have two tests in soc-pcm.c >> >> if (codec_dai->active) >> if (codec_dai->active == 1) >> >> The two are functionality equivalent but it'd be good to choose one >> version - or possibly use 'active' as a boolean. > > In my understanding, dai->active can be 0/1/2. I see, I guess I missed this completely. Thanks Morimoto-san for the precision.