From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9WJu-0006iq-Ej for qemu-devel@nongnu.org; Wed, 23 Nov 2016 07:06:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9WJp-0003PJ-HZ for qemu-devel@nongnu.org; Wed, 23 Nov 2016 07:06:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49256) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9WJp-0003OL-CG for qemu-devel@nongnu.org; Wed, 23 Nov 2016 07:06:29 -0500 References: <1479874588-1969-1-git-send-email-eblake@redhat.com> <1479874588-1969-3-git-send-email-eblake@redhat.com> <1983787067.1379664.1479893001061.JavaMail.zimbra@redhat.com> <21053836-664b-d6a2-d324-bf9b942e3a15@redhat.com> From: Paolo Bonzini Message-ID: Date: Wed, 23 Nov 2016 13:06:18 +0100 MIME-Version: 1.0 In-Reply-To: <21053836-664b-d6a2-d324-bf9b942e3a15@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TJIedFHfiFwtVTKDsuIHKcADg48UpVnCB" Subject: Re: [Qemu-devel] [PATCH 2/3] test-qga: Avoid qobject_from_jsonf("%"PRId64) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, programmingkidx@gmail.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TJIedFHfiFwtVTKDsuIHKcADg48UpVnCB From: Paolo Bonzini To: Eric Blake Cc: qemu-devel@nongnu.org, programmingkidx@gmail.com, armbru@redhat.com Message-ID: Subject: Re: [PATCH 2/3] test-qga: Avoid qobject_from_jsonf("%"PRId64) References: <1479874588-1969-1-git-send-email-eblake@redhat.com> <1479874588-1969-3-git-send-email-eblake@redhat.com> <1983787067.1379664.1479893001061.JavaMail.zimbra@redhat.com> <21053836-664b-d6a2-d324-bf9b942e3a15@redhat.com> In-Reply-To: <21053836-664b-d6a2-d324-bf9b942e3a15@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 23/11/2016 11:36, Eric Blake wrote: > This is the key, look at: > $ git grep -A2 strdup_printf tests/test-qga.c >=20 > and you'll see that my change is no grosser than the rest of the file. >=20 Oh well... I guess with a better commit message the patch is fine. Paolo --TJIedFHfiFwtVTKDsuIHKcADg48UpVnCB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJYNYY7AAoJEL/70l94x66DqU4IAJ00XX9rqDAAdK99surlQ7SA DRmisOl9By+cQC9pdfQP6y4e/KefcPlYBL8YT58jCpc+Sn0EiMY7LxZpkrOH33Ju GH4YflpJ2LmnG2qnh/4N4EuKKDIUAuZCF27RGwEXqoBtSuHK6JjmL8+dGdP46C0l Gtsmb6/5nQPyy0sNkQLw9XQJi2XJJxSTRBC19J6wMLnWqGQtXfV80Dl91/oJP3y7 6LaN6f0xTgGpbo9BVFyVHWc2Iy9VLRm2f843kQ1yDzMzrvdfOD38Yd8I5OxSwrfq wEV+35POIkc/cU3JuLC604UngdkE+Lv605eIVsShV4BTZogWuCgsI68dopbhyuk= =YONK -----END PGP SIGNATURE----- --TJIedFHfiFwtVTKDsuIHKcADg48UpVnCB--