From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2583329B0 for ; Thu, 2 Mar 2023 14:06:44 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 096BB1FB; Thu, 2 Mar 2023 06:07:24 -0800 (PST) Received: from [10.1.25.48] (FVFF763DQ05P.cambridge.arm.com [10.1.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5F8143F587; Thu, 2 Mar 2023 06:06:38 -0800 (PST) Message-ID: Date: Thu, 2 Mar 2023 14:06:37 +0000 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC kvmtool 18/31] arm64: Populate initial realm contents To: Piotr Sawicki Cc: Alexandru Elisei , Andrew Jones , Christoffer Dall , Fuad Tabba , Jean-Philippe Brucker , Joey Gouly , Marc Zyngier , Mark Rutland , Oliver Upton , Paolo Bonzini , Quentin Perret , Steven Price , Thomas Huth , Will Deacon , Zenghui Yu , linux-coco@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230127112248.136810-1-suzuki.poulose@arm.com> <20230127113932.166089-1-suzuki.poulose@arm.com> <20230127113932.166089-19-suzuki.poulose@arm.com> <7a0e256d-3ce1-3218-c930-ed518a679b8b@gmail.com> From: Suzuki K Poulose In-Reply-To: <7a0e256d-3ce1-3218-c930-ed518a679b8b@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Piotr On 02/03/2023 14:03, Piotr Sawicki wrote: > Hi, > >> From: Alexandru Elisei >> >> Populate the realm memory with the initial contents, which include >> the device tree blob, the kernel image, and initrd, if specified, >> or the firmware image. >> >> Populating an image in the realm involves two steps: >>   a) Mark the IPA area as RAM - INIT_IPA_REALM >>   b) Load the contents into the IPA - POPULATE_REALM >> >> Wherever we know the actual size of an image in memory, we make >> sure the "memory area" is initialised to RAM. >> e.g., Linux kernel image size from the header which includes the bss etc. >> The "file size" on disk for the Linux image is much smaller. >> We mark the region of size Image.header.size as RAM (a), from the kernel >> load address. And load the Image file into the memory (b) above. >> At the moment we only detect the Arm64 Linux Image header format. >> >> Since we're already touching the code that copies the >> initrd in guest memory, let's do a bit of cleaning and remove a >> useless local variable. >> >> Signed-off-by: Alexandru Elisei >> [ Make sure the Linux kernel image area is marked as RAM ] >> Signed-off-by: Suzuki K Poulose >> diff --git a/arm/kvm.c b/arm/kvm.c >> index acb627b2..57c5b5f7 100644 >> --- a/arm/kvm.c >> +++ b/arm/kvm.c >> @@ -6,6 +6,7 @@ >>   #include "kvm/fdt.h" >>   #include "arm-common/gic.h" >> +#include >>   #include >> @@ -167,6 +168,9 @@ bool kvm__arch_load_kernel_image(struct kvm *kvm, >> int fd_kernel, int fd_initrd, >>       pr_debug("Loaded kernel to 0x%llx (%llu bytes)", >>            kvm->arch.kern_guest_start, kvm->arch.kern_size); > > > I've noticed that multiple calling of the measurement test from the > kvm-unit-tests suite results in different Realm Initial Measurements, > although the kernel image is always the same. > > After short investigation, I've found that the RIM starts being > different while populating the last 4kB chunk of the kernel image. > The issue occurs when the image size is not aligned to the page size (4kB). > > After zeroing the unused area of the last chunk, the measurements become > repeatable. > That is a good point. We could memset() the remaining bits of the 4K page to 0. I will make this change. Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F985C678D4 for ; Thu, 2 Mar 2023 14:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YwjpxF0D3u89TnM9vyS48Fqp7OByJDKOzOI/zgmIIOo=; b=00ONB3c4sSeaiM 38Z2zZIyl70XDLCM77kWuEEhpDewdK6DJ/BdGY7hPGmZ0wy3diwRrmqevVQotTf4qSnkAipfUU/Db xfntf6MH++8UDVLdnfGv7gt06ymbxcUEvE7Xj6Bm5bqQAixv+q7CQYjDq/utkpKTjyN9zWWURal6Z zg7xUv6F1trnVn45n0dTZdLYiAliprxHGJkSOo9JavCxOMCrnfJ0Xfx7wWILCNZnpoPGGeWfKGXjD viccQ2WpbxC6swu7IdBVX6T8yuy4dxfvZQZpaCIf7/Wv8vdMz6AsXUi6HTr5+L3J2fgAT2aQQkVZa 0XBj9/ZxnzSiASx1clkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXja5-002Pif-Vh; Thu, 02 Mar 2023 14:06:50 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXja2-002PhW-6n for linux-arm-kernel@lists.infradead.org; Thu, 02 Mar 2023 14:06:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 096BB1FB; Thu, 2 Mar 2023 06:07:24 -0800 (PST) Received: from [10.1.25.48] (FVFF763DQ05P.cambridge.arm.com [10.1.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5F8143F587; Thu, 2 Mar 2023 06:06:38 -0800 (PST) Message-ID: Date: Thu, 2 Mar 2023 14:06:37 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC kvmtool 18/31] arm64: Populate initial realm contents To: Piotr Sawicki Cc: Alexandru Elisei , Andrew Jones , Christoffer Dall , Fuad Tabba , Jean-Philippe Brucker , Joey Gouly , Marc Zyngier , Mark Rutland , Oliver Upton , Paolo Bonzini , Quentin Perret , Steven Price , Thomas Huth , Will Deacon , Zenghui Yu , linux-coco@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230127112248.136810-1-suzuki.poulose@arm.com> <20230127113932.166089-1-suzuki.poulose@arm.com> <20230127113932.166089-19-suzuki.poulose@arm.com> <7a0e256d-3ce1-3218-c930-ed518a679b8b@gmail.com> From: Suzuki K Poulose In-Reply-To: <7a0e256d-3ce1-3218-c930-ed518a679b8b@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230302_060646_380111_9ADC7D69 X-CRM114-Status: GOOD ( 19.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUGlvdHIKCk9uIDAyLzAzLzIwMjMgMTQ6MDMsIFBpb3RyIFNhd2lja2kgd3JvdGU6Cj4gSGks Cj4gCj4+IEZyb206IEFsZXhhbmRydSBFbGlzZWkgPGFsZXhhbmRydS5lbGlzZWlAYXJtLmNvbT4K Pj4KPj4gUG9wdWxhdGUgdGhlIHJlYWxtIG1lbW9yeSB3aXRoIHRoZSBpbml0aWFsIGNvbnRlbnRz LCB3aGljaCBpbmNsdWRlCj4+IHRoZSBkZXZpY2UgdHJlZSBibG9iLCB0aGUga2VybmVsIGltYWdl LCBhbmQgaW5pdHJkLCBpZiBzcGVjaWZpZWQsCj4+IG9yIHRoZSBmaXJtd2FyZSBpbWFnZS4KPj4K Pj4gUG9wdWxhdGluZyBhbiBpbWFnZSBpbiB0aGUgcmVhbG0gaW52b2x2ZXMgdHdvIHN0ZXBzOgo+ PiDCoCBhKSBNYXJrIHRoZSBJUEEgYXJlYSBhcyBSQU0gLSBJTklUX0lQQV9SRUFMTQo+PiDCoCBi KSBMb2FkIHRoZSBjb250ZW50cyBpbnRvIHRoZSBJUEEgLSBQT1BVTEFURV9SRUFMTQo+Pgo+PiBX aGVyZXZlciB3ZSBrbm93IHRoZSBhY3R1YWwgc2l6ZSBvZiBhbiBpbWFnZSBpbiBtZW1vcnksIHdl IG1ha2UKPj4gc3VyZSB0aGUgIm1lbW9yeSBhcmVhIiBpcyBpbml0aWFsaXNlZCB0byBSQU0uCj4+ IGUuZy4sIExpbnV4IGtlcm5lbCBpbWFnZSBzaXplIGZyb20gdGhlIGhlYWRlciB3aGljaCBpbmNs dWRlcyB0aGUgYnNzIGV0Yy4KPj4gVGhlICJmaWxlIHNpemUiIG9uIGRpc2sgZm9yIHRoZSBMaW51 eCBpbWFnZSBpcyBtdWNoIHNtYWxsZXIuCj4+IFdlIG1hcmsgdGhlIHJlZ2lvbiBvZiBzaXplIElt YWdlLmhlYWRlci5zaXplIGFzIFJBTSAoYSksIGZyb20gdGhlIGtlcm5lbAo+PiBsb2FkIGFkZHJl c3MuIEFuZCBsb2FkIHRoZSBJbWFnZSBmaWxlIGludG8gdGhlIG1lbW9yeSAoYikgYWJvdmUuCj4+ IEF0IHRoZSBtb21lbnQgd2Ugb25seSBkZXRlY3QgdGhlIEFybTY0IExpbnV4IEltYWdlIGhlYWRl ciBmb3JtYXQuCj4+Cj4+IFNpbmNlIHdlJ3JlIGFscmVhZHkgdG91Y2hpbmcgdGhlIGNvZGUgdGhh dCBjb3BpZXMgdGhlCj4+IGluaXRyZCBpbiBndWVzdCBtZW1vcnksIGxldCdzIGRvIGEgYml0IG9m IGNsZWFuaW5nIGFuZCByZW1vdmUgYQo+PiB1c2VsZXNzIGxvY2FsIHZhcmlhYmxlLgo+Pgo+PiBT aWduZWQtb2ZmLWJ5OiBBbGV4YW5kcnUgRWxpc2VpIDxhbGV4YW5kcnUuZWxpc2VpQGFybS5jb20+ Cj4+IFsgTWFrZSBzdXJlIHRoZSBMaW51eCBrZXJuZWwgaW1hZ2UgYXJlYSBpcyBtYXJrZWQgYXMg UkFNIF0KPj4gU2lnbmVkLW9mZi1ieTogU3V6dWtpIEsgUG91bG9zZSA8c3V6dWtpLnBvdWxvc2VA YXJtLmNvbT4KCgo+PiBkaWZmIC0tZ2l0IGEvYXJtL2t2bS5jIGIvYXJtL2t2bS5jCj4+IGluZGV4 IGFjYjYyN2IyLi41N2M1YjVmNyAxMDA2NDQKPj4gLS0tIGEvYXJtL2t2bS5jCj4+ICsrKyBiL2Fy bS9rdm0uYwo+PiBAQCAtNiw2ICs2LDcgQEAKPj4gwqAgI2luY2x1ZGUgImt2bS9mZHQuaCIKPj4g wqAgI2luY2x1ZGUgImFybS1jb21tb24vZ2ljLmgiCj4+ICsjaW5jbHVkZSA8YXNtL3JlYWxtLmg+ Cj4+IMKgICNpbmNsdWRlIDxzeXMvcmVzb3VyY2UuaD4KPj4gQEAgLTE2Nyw2ICsxNjgsOSBAQCBi b29sIGt2bV9fYXJjaF9sb2FkX2tlcm5lbF9pbWFnZShzdHJ1Y3Qga3ZtICprdm0sIAo+PiBpbnQg ZmRfa2VybmVsLCBpbnQgZmRfaW5pdHJkLAo+PiDCoMKgwqDCoMKgIHByX2RlYnVnKCJMb2FkZWQg a2VybmVsIHRvIDB4JWxseCAoJWxsdSBieXRlcykiLAo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCBr dm0tPmFyY2gua2Vybl9ndWVzdF9zdGFydCwga3ZtLT5hcmNoLmtlcm5fc2l6ZSk7Cj4gCj4gCj4g SSd2ZSBub3RpY2VkIHRoYXQgbXVsdGlwbGUgY2FsbGluZyBvZiB0aGUgbWVhc3VyZW1lbnQgdGVz dCBmcm9tIHRoZSAKPiBrdm0tdW5pdC10ZXN0cyBzdWl0ZSByZXN1bHRzIGluIGRpZmZlcmVudCBS ZWFsbSBJbml0aWFsIE1lYXN1cmVtZW50cywgCj4gYWx0aG91Z2ggdGhlIGtlcm5lbCBpbWFnZSBp cyBhbHdheXMgdGhlIHNhbWUuCj4gCj4gQWZ0ZXIgc2hvcnQgaW52ZXN0aWdhdGlvbiwgSSd2ZSBm b3VuZCB0aGF0IHRoZSBSSU0gc3RhcnRzIGJlaW5nIAo+IGRpZmZlcmVudCB3aGlsZSBwb3B1bGF0 aW5nIHRoZSBsYXN0IDRrQiBjaHVuayBvZiB0aGUga2VybmVsIGltYWdlLgo+IFRoZSBpc3N1ZSBv Y2N1cnMgd2hlbiB0aGUgaW1hZ2Ugc2l6ZSBpcyBub3QgYWxpZ25lZCB0byB0aGUgcGFnZSBzaXpl ICg0a0IpLgo+IAo+IEFmdGVyIHplcm9pbmcgdGhlIHVudXNlZCBhcmVhIG9mIHRoZSBsYXN0IGNo dW5rLCB0aGUgbWVhc3VyZW1lbnRzIGJlY29tZSAKPiByZXBlYXRhYmxlLgo+IAoKVGhhdCBpcyBh IGdvb2QgcG9pbnQuIFdlIGNvdWxkIG1lbXNldCgpIHRoZSByZW1haW5pbmcgYml0cyBvZiB0aGUg NEsgCnBhZ2UgdG8gMC4gSSB3aWxsIG1ha2UgdGhpcyBjaGFuZ2UuCgpTdXp1a2kKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==