Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue

From: Thomas Zimmermann <tzimmermann@suse.de>
To: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>,
	dri-devel@lists.freedesktop.org
Cc: jenmin_yuan@aspeedtech.com, eich@suse.com,
	tommy_huang@aspeedtech.com, arc_sung@aspeedtech.com,
	airlied@redhat.com
Subject: Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue
Date: Thu, 5 Nov 2020 13:08:32 +0100	[thread overview]
Message-ID: <f9b658a6-8a4d-d512-de90-897af7a6d90d@suse.de> (raw)
In-Reply-To: <20201105094729.106059-1-kuohsiang_chou@aspeedtech.com>

[-- Attachment #1.1.1.1: Type: text/plain, Size: 2396 bytes --]

Hi,

please follow the advise we're giving you. Had you run
scripts/checkpatch.pl on the patch file it would have told you

<<<
ERROR: patch seems to be corrupt (line wrapped?)
#102: FILE: drivers/gpu/drm/ast/ast_tables.h:294:

ERROR: DOS line endings
#106: FILE: drivers/gpu/drm/ast/ast_tables.h:297:
+^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |^M$

ERROR: DOS line endings
#110: FILE: drivers/gpu/drm/ast/ast_tables.h:300:
+^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |^M$

total: 3 errors, 0 warnings, 19 lines checked
>>>

As said before, the mail eich@suse.de is still not relevant any longer.
But you did not add Daniel into CC. Did you run scripts/get_maintainers.pl?

Best regards
Thomas

Am 05.11.20 um 10:47 schrieb KuoHsiang Chou:
> [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz
>       from  Negtive to Positive
> 
> Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>
> ---
>  drivers/gpu/drm/ast/ast_tables.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_tables.h b/drivers/gpu/drm/ast/ast_tables.h
> index 8414e543f260..51efc5b4a55c 100644
> --- a/drivers/gpu/drm/ast/ast_tables.h
> +++ b/drivers/gpu/drm/ast/ast_tables.h
> @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable res_1600x900[] = {
> 
>  static const struct ast_vbios_enhtable res_1920x1080[] = {
>  	{2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5,	/* 60Hz */
> -	 (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
> +	 (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>  	  AST2500PreCatchCRT), 60, 1, 0x38 },
>  	{2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5,	/* 60Hz */
> -	 (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
> +	 (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>  	  AST2500PreCatchCRT), 0xFF, 1, 0x38 },
>  };
> 
> --
> 2.18.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[-- Attachment #1.1.1.2: OpenPGP_0x680DC11D530B7A23.asc --]
[-- Type: application/pgp-keys, Size: 4259 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel